HomePhabricator

Require commit identities when editing commits to resolve an issue with audit…

Authored by epriestley on Jun 24 2019, 4:23 PM.

Description

Require commit identities when editing commits to resolve an issue with audit actions not applying properly

Summary:
See https://discourse.phabricator-community.org/t/cannot-audit-a-git-commit/2848. In D20581, I made some audit behavior dependent upon identities, but the actual edit flow doesn't load them. This can cause us to raise an "attach identities first" exception in the bowels of the edit workflow and trigger unexpected behavior at top level.

Load identities when editing a commit so that the transaction flows have access to identity information and can use it to figure out if a user is an author, etc.

Test Plan:

  • As an auditor, applied an "Accept Commit" action to an open audit after D20581.
  • Before patch: accept no-ops internally since the preconditions throw.
  • After patch: accept works properly.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20612