Page MenuHomePhabricator

Deprecate "bin/phd ... --gently" and update documentation
ClosedPublic

Authored by epriestley on Thu, Jun 20, 9:23 PM.

Details

Summary

Ref T13321. Previously, the behavior was:

  • bin/phd stop --gently: Stop all daemons with PID files that belong to the current instance.
  • bin/phd stop: Stop all daemons with PID files that belong to the current instance. Complain if there are more processes.
  • bin/phd stop --force: Stop all processes that look like daemons, ignoring instances.

The new behavior is:

  • bin/phd stop: Stop all processes that look like daemons and belong to the current instance.
  • bin/phd stop --force: Stop all processes that look like daemons, period.
Test Plan

Grep / documentation only.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jun 20, 9:23 PM

(I'm deprecating (rather than removing) --gently because some deploy stuff in core/ uses it.)

epriestley requested review of this revision.Thu, Jun 20, 9:24 PM
amckinley accepted this revision.Thu, Jun 20, 10:34 PM
This revision is now accepted and ready to land.Thu, Jun 20, 10:34 PM