Page MenuHomePhabricator

Various internal APIs calls use the made up word "topographical" when they mean "topological"
Closed, ResolvedPublic

Description

See PHI1271. The word "topographical" is incorrectly used in place of the word "topological" in several internal APIs, e.g. getTopographicallySortedNodes(). The actual behavior of these methods is to produce a (depth-first) (stable) topological ordering.

To avoid looking silly to future generations, we should correct this misuse of terminology and then deny our mistake categorically.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

epriestley created this task.

The power is in my hands, now.

epriestley added a revision: Restricted Differential Revision.Jun 20 2019, 7:05 PM
epriestley added a revision: Restricted Differential Revision.Jun 20 2019, 7:11 PM
epriestley added a revision: Restricted Differential Revision.Jun 20 2019, 7:15 PM
epriestley added a commit: Restricted Diffusion Commit.Jun 20 2019, 11:02 PM
epriestley added a commit: Restricted Diffusion Commit.Jun 20 2019, 11:05 PM
epriestley added a commit: Restricted Diffusion Commit.Jun 20 2019, 11:12 PM