Paths

Table of Contentst

Differential D20597

Replace made-up use of "topographical" ordering with professional, high-quality academic use of "topological" ordering
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 7:05 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological"

Commits

rPHU674d69718e88: (stable) Promote 2019 Week 25
rPHU8eaf1b38d417: Replace made-up use of "topographical" ordering with professional, high-quality…

Summary

Ref T13325. See PHI1271. The word "topographical" is misused in a couple of APIs here when we mean "topological".

We also have a function which produces a "topological" ordering of a graph which may contain cycles, which isn't a real thing and can't really have a good name, but this is now "rough topological ordering".

Test Plan

Ran unit tests, grepped for topograph.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 20 2019, 7:05 PM

Harbormaster completed remote builds in B23002: Diff 49130.Jun 20 2019, 7:05 PM

epriestley requested review of this revision.Jun 20 2019, 7:05 PM

epriestley mentioned this in D20599: Update "phabricator/" for "topological" API changes.Jun 20 2019, 7:19 PM

amckinley accepted this revision.Jun 20 2019, 7:51 PM

This revision is now accepted and ready to land.Jun 20 2019, 7:51 PM

yelirekim awarded a token.Jun 20 2019, 7:51 PM

No wonder I couldn't pass the Facebook eng interview!!

epriestley edited the summary of this revision. (Show Details)Jun 20 2019, 7:53 PM

Closed by commit rPHU8eaf1b38d417: Replace made-up use of "topographical" ordering with professional, high-quality… (authored by epriestley). · Explain WhyJun 20 2019, 11:02 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU8eaf1b38d417: Replace made-up use of "topographical" ordering with professional, high-quality….

epriestley added a commit: rPHU674d69718e88: (stable) Promote 2019 Week 25.Jun 22 2019, 2:38 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

AbstractDirectedGraph.php

24 lines

__tests__/

AbstractDirectedGraphTestCase.php

22 lines

Diff 49148

View Options

src/utils/AbstractDirectedGraph.php

View Options

src/utils/tests/AbstractDirectedGraphTestCase.php

Replace made-up use of "topographical" ordering with professional, high-quality academic use of "topological" orderingClosedPublicActions