Page MenuHomePhabricator

Replace made-up use of "topographical" ordering with professional, high-quality academic use of "topological" ordering
ClosedPublic

Authored by epriestley on Jun 20 2019, 7:05 PM.
Tags
None
Referenced Files
F15464226: D20597.id49130.diff
Wed, Apr 2, 7:30 AM
F15434927: D20597.id.diff
Tue, Mar 25, 6:05 AM
F15381645: D20597.diff
Mar 14 2025, 8:43 AM
F15282526: D20597.id49148.diff
Mar 4 2025, 12:18 AM
F15282525: D20597.id49130.diff
Mar 4 2025, 12:18 AM
F15282523: D20597.id.diff
Mar 4 2025, 12:18 AM
F15282522: D20597.diff
Mar 4 2025, 12:18 AM
Unknown Object (File)
Feb 14 2025, 1:08 AM
Subscribers
None
Tokens
"Pterodactyl" token, awarded by yelirekim.

Details

Summary

Ref T13325. See PHI1271. The word "topographical" is misused in a couple of APIs here when we mean "topological".

We also have a function which produces a "topological" ordering of a graph which may contain cycles, which isn't a real thing and can't really have a good name, but this is now "rough topological ordering".

Test Plan

Ran unit tests, grepped for topograph.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable