Page MenuHomePhabricator

Replace made-up use of "topographical" ordering with professional, high-quality academic use of "topological" ordering
ClosedPublic

Authored by epriestley on Thu, Jun 20, 7:05 PM.

Details

Summary

Ref T13325. See PHI1271. The word "topographical" is misused in a couple of APIs here when we mean "topological".

We also have a function which produces a "topological" ordering of a graph which may contain cycles, which isn't a real thing and can't really have a good name, but this is now "rough topological ordering".

Test Plan

Ran unit tests, grepped for topograph.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jun 20, 7:05 PM
epriestley requested review of this revision.Thu, Jun 20, 7:05 PM
amckinley accepted this revision.Thu, Jun 20, 7:51 PM
This revision is now accepted and ready to land.Thu, Jun 20, 7:51 PM

No wonder I couldn't pass the Facebook eng interview!!

epriestley edited the summary of this revision. (Show Details)Thu, Jun 20, 7:53 PM