Render object monograms and embedding references more gracefully when building a Remarkup table of contents
ClosedPublic
Actions

Authored by epriestley on Mar 16 2018, 10:37 PM.

Details

Reviewers: None
Maniphest Tasks: T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki
T13102: Plans: 2018 Week 11 Bonus Content
Commits: rP2fa904921e1a: Render object monograms and embedding references more gracefully when building…

Summary

Fixes T8845. Ref T13102. See PHI467. Currently, object monograms like L1 which appear in Remarkup headers render incorrectly (with an internal placeholder "x") in the table of contents:

Screen Shot 2018-03-16 at 3.31.55 PM.png (347×372 px, 21 KB)

Instead, render them down to just, e.g., L1 in plain text.

For {P123} I just rendered it to {P123} since it's not really clear to me what users intend. This could be adjusted if there's some reasonable thing that someone is trying to do with this.

Test Plan

Wrote a Phriction document with several object references (like L1 and {P123}) in headers. After patch, saw "x"-free, sensible-looking header names in the table of contents.