Page MenuHomePhabricator

Fix some minor errors (DarkConsole warning, unstable Ferret sort)
ClosedPublic

Authored by epriestley on Mar 18 2018, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 19 2024, 4:42 AM
Unknown Object (File)
Jan 16 2024, 9:23 AM
Unknown Object (File)
Jan 15 2024, 9:39 PM
Unknown Object (File)
Jan 7 2024, 4:42 PM
Unknown Object (File)
Jan 5 2024, 1:37 PM
Unknown Object (File)
Jan 3 2024, 7:38 PM
Unknown Object (File)
Dec 30 2023, 4:55 PM
Unknown Object (File)
Dec 28 2023, 3:01 AM
Subscribers
None

Details

Summary

DarkConsole could warn when "Analyze Query Plans" was not active.

msort() is not stable, so Ferret results with similar relevance could be returned out-of-order.

Test Plan

Saw fewer traces and more-stable result ordering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2018, 10:12 PM
This revision was automatically updated to reflect the committed changes.