Page MenuHomePhabricator

Fix some minor errors (DarkConsole warning, unstable Ferret sort)
ClosedPublic

Authored by epriestley on Mar 18 2018, 10:02 PM.
Tags
None
Referenced Files
F18875647: D19236.diff
Wed, Nov 5, 6:36 PM
F18855312: D19236.id46060.diff
Sat, Nov 1, 4:51 AM
F18740832: D19236.id.diff
Oct 2 2025, 6:03 AM
F18739213: D19236.diff
Oct 1 2025, 8:24 PM
F18705724: D19236.diff
Sep 28 2025, 12:50 PM
F18704509: D19236.id.diff
Sep 28 2025, 7:52 AM
F18650496: D19236.id46060.diff
Sep 21 2025, 12:52 AM
F18645224: D19236.id46059.diff
Sep 19 2025, 7:06 AM
Subscribers
None

Details

Summary

DarkConsole could warn when "Analyze Query Plans" was not active.

msort() is not stable, so Ferret results with similar relevance could be returned out-of-order.

Test Plan

Saw fewer traces and more-stable result ordering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2018, 10:12 PM
This revision was automatically updated to reflect the committed changes.