Paths

Table of Contentst

Differential D19236

Fix some minor errors (DarkConsole warning, unstable Ferret sort)
ClosedPublic
Actions

Authored by epriestley on Mar 18 2018, 10:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 21, 4:44 PM

	Unknown Object (File)
	Tue, Jan 21, 11:00 AM

	Unknown Object (File)
	Mon, Jan 20, 8:22 AM

	Unknown Object (File)
	Mon, Jan 20, 2:22 AM

	Unknown Object (File)
	Sat, Jan 18, 3:21 AM

	Unknown Object (File)
	Thu, Jan 16, 10:38 AM

	Unknown Object (File)
	Tue, Jan 14, 12:34 PM

	Unknown Object (File)
	Fri, Jan 10, 11:17 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rPc5e4bd8187c6: Fix some minor errors (DarkConsole warning, unstable Ferret sort)

Summary

DarkConsole could warn when "Analyze Query Plans" was not active.

msort() is not stable, so Ferret results with similar relevance could be returned out-of-order.

Test Plan

Saw fewer traces and more-stable result ordering.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 18 2018, 10:02 PM

Harbormaster completed remote builds in B19878: Diff 46059.Mar 18 2018, 10:03 PM

epriestley requested review of this revision.Mar 18 2018, 10:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2018, 10:12 PM

Closed by commit rPc5e4bd8187c6: Fix some minor errors (DarkConsole warning, unstable Ferret sort) (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

console/

plugin/

DarkConsoleServicesPlugin.php

2 lines

search/

fulltextstorage/

PhabricatorFerretFulltextStorageEngine.php

2 lines

Diff 46060

View Options

src/applications/console/plugin/DarkConsoleServicesPlugin.php