Differential D19238

Add an async driver for document rendering and a crude "Hexdump" document engine
ClosedPublic
Actions

Authored by epriestley on Mar 19 2018, 5:59 PM.

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rPf646153f4dbe: Add an async driver for document rendering and a crude "Hexdump" document engine

Summary

Depends on D19237. Ref T13105. This adds a (very basic) "Hexdump" engine (mostly just to have a second option to switch to) and a selector for choosing view modes.

Test Plan

Viewed some files, switched between audio/video/image/hexdump.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 19 2018, 5:59 PM

Harbormaster failed remote builds in B19881: Diff 46062!Mar 19 2018, 5:59 PM

epriestley requested review of this revision.Mar 19 2018, 7:40 PM

epriestley added a child revision: D19239: Add filesize limits for document rendering engines and support partial/complete rendering.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2018, 10:18 PM

Closed by commit rPf646153f4dbe: Add an async driver for document rendering and a crude "Hexdump" document engine (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13108: Plans: 2018 Week 12 Bonus Content.Mar 20 2018, 2:46 PM

Revision Contents
Changeset List

		Path
M		resources/celerity/map.php (13 lines)
M		src/__phutil_library_map__.php (4 lines)
M		src/applications/files/application/PhabricatorFilesApplication.php (2 lines)
A	M	src/applications/files/controller/PhabricatorFileDocumentController.php (113 lines)
M		src/applications/files/controller/PhabricatorFileInfoController.php (66 lines)
M		src/applications/files/document/PhabricatorAudioDocumentEngine.php (4 lines)
M		src/applications/files/document/PhabricatorDocumentEngine.php (48 lines)
M		src/applications/files/document/PhabricatorDocumentRef.php (8 lines)
A	M	src/applications/files/document/PhabricatorHexdumpDocumentEngine.php (83 lines)
M		src/applications/files/document/PhabricatorImageDocumentEngine.php (4 lines)
M		src/applications/files/document/PhabricatorVideoDocumentEngine.php (4 lines)
M		src/applications/files/document/PhabricatorVoidDocumentEngine.php (4 lines)
M		webroot/rsrc/css/phui/phui-property-list-view.css (11 lines)
A	M	webroot/rsrc/js/application/files/behavior-document-engine.js (67 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46062	b3fc6ce		Mar 19 2018, 5:59 PM	★	★
Diff 2	46065	01f22a8	rPf646153f4dbe6303856a2f383526d1c539a3b060	Mar 19 2018, 10:18 PM	★	★

Status	Author	Revision
Closed	epriestley	D19239 Add filesize limits for document rendering engines and support partial/complete rendering
Closed	epriestley	D19238 Add an async driver for document rendering and a crude "Hexdump" document engine
Closed	epriestley	D19237 Roughly modularize document rendering in Files