Paths

Table of Contentst

Differential D19235

Give all commands from DiffusionCommandEngine a default 15 minute timeout
ClosedPublic
Actions

Authored by epriestley on Mar 17 2018, 12:15 AM.

Tags

None

Referenced Files

	F14055673: D19235.diff
	Sat, Nov 16, 2:36 PM

	F14038591: D19235.id46057.diff
	Mon, Nov 11, 12:34 AM

	F14008569: D19235.id46058.diff
	Wed, Oct 30, 1:15 AM

	F14006703: D19235.id46057.diff
	Mon, Oct 28, 3:35 PM

	F14002198: D19235.id46058.diff
	Fri, Oct 25, 4:12 PM

	F13985664: D19235.diff
	Sun, Oct 20, 10:14 PM

	F13985660: D19235.id.diff
	Sun, Oct 20, 10:09 PM

	F13985657: D19235.id46057.diff
	Sun, Oct 20, 10:08 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13108: Plans: 2018 Week 12 Bonus Content
Commits: rP7e43b7405512: Give all commands from DiffusionCommandEngine a default 15 minute timeout

Summary

Ref T13108. See PHI364. See the task and issue for discussion.

If a git fetch during synchronization hangs, the whole node currently hangs. While the causes of a git fetch hang aren't clear, we don't expect synchronization to ever reasonably take more than 15 minutes, so add a default timeout.

Test Plan

Will deploy and observe; this is difficult to reproduce or test directly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 17 2018, 12:15 AM

Harbormaster completed remote builds in B19876: Diff 46057.Mar 17 2018, 12:16 AM

epriestley requested review of this revision.Mar 17 2018, 12:16 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2018, 12:22 AM

Closed by commit rP7e43b7405512: Give all commands from DiffusionCommandEngine a default 15 minute timeout (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

protocol/

DiffusionCommandEngine.php

5 lines

Diff 46058

View Options

src/applications/diffusion/protocol/DiffusionCommandEngine.php

Give all commands from DiffusionCommandEngine a default 15 minute timeoutClosedPublicActions