Page MenuHomePhabricator
Differential D19239

Add filesize limits for document rendering engines and support partial/complete rendering
ClosedPublic
Actions

Authored by epriestley on Mar 19 2018, 7:40 PM.
Tags
None
Referenced Files
F18921717: D19239.id46063.diff
Nov 9 2025, 2:36 PM
F18862449: D19239.id.diff
Nov 2 2025, 7:23 PM
F18848843: D19239.diff
Oct 30 2025, 6:34 AM
F18798593: D19239.id.diff
Oct 17 2025, 7:06 AM
F18772559: D19239.diff
Oct 9 2025, 3:06 AM
F18764928: D19239.diff
Oct 7 2025, 8:38 AM
F18509455: D19239.id.diff
Sep 5 2025, 3:25 AM
F18502426: D19239.diff
Sep 4 2025, 10:26 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rP4aafce686202: Add filesize limits for document rendering engines and support partial/complete…
Summary

Depends on D19238. Ref T13105. Give document engines some reasonable automatic support for degrading gracefully when someone tries to hexdump a 100MB file or similar.

Also, make "Video" sort above "Audio" for files which could be rendered either way.

Test Plan

Viewed audio, video, image, and other files. Adjusted limits and saw full, partial, and fallback/error rendering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 19 2018, 7:40 PM
Harbormaster completed remote builds in B19882: Diff 46063.Mar 19 2018, 7:41 PM
epriestley requested review of this revision.Mar 19 2018, 7:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2018, 10:18 PM
Closed by commit rP4aafce686202: Add filesize limits for document rendering engines and support partial/complete… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46066

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/document/PhabricatorAudioDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentRef.php

Loading...
View Options

src/applications/files/document/PhabricatorHexdumpDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorImageDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorVideoDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorVoidDocumentEngine.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
View Options

webroot/rsrc/js/application/files/behavior-document-engine.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

Loading...
Phabricator · Built by Phacility