Page MenuHomePhabricator

Add filesize limits for document rendering engines and support partial/complete rendering
ClosedPublic

Authored by epriestley on Mar 19 2018, 7:40 PM.

Details

Summary

Depends on D19238. Ref T13105. Give document engines some reasonable automatic support for degrading gracefully when someone tries to hexdump a 100MB file or similar.

Also, make "Video" sort above "Audio" for files which could be rendered either way.

Test Plan

Viewed audio, video, image, and other files. Adjusted limits and saw full, partial, and fallback/error rendering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2018, 10:18 PM
This revision was automatically updated to reflect the committed changes.