HomePhabricator

Fix a possible `count(null)` in DifferentialRevisionActionTransaction

Description

Fix a possible count(null) in DifferentialRevisionActionTransaction

Summary:
This change prevents the following error when using PHP 7.2:

ERROR 2: count(): Parameter must be an array or an object that implements Countable at [/usr/local/lib/php/phabricator/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php:132]

A similar issue was fixed in D18964

Test Plan: Tested in a live system.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19242

Details

Provenance
tolbrinoAuthored on Mar 21 2018, 2:39 PM
epriestleyCommitted on Mar 21 2018, 2:39 PM
epriestleyPushed on Mar 21 2018, 2:39 PM
Reviewer
Blessed Reviewers
Differential Revision
D19242: Fix a possible `count(null)` in DifferentialRevisionActionTransaction
Parents
rP3bf8d5682ed0: Fix outdated link for Font Awesome icon set
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19891
Build 26957: Run Core Tests