Page MenuHomePhabricator
Feed All Stories

Jan 31 2018

epriestley updated the task description for T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Jan 31 2018, 4:48 PM · Plans, Differential, Harbormaster
epriestley added a comment to T8232: Automatically claim a task when a differential is submitted.

I think T11934 and an explicit !claim Txxx action (which would mean "reassign + ref"; maybe with a !claim-and-fix Txxx to mean "reassign + fixes" or some kind of !claim+fix X syntax which expands to !claim <args>; !fix <args>) is a possible way forward on this, but I don't want to make "ref" automatically mean "claim".

Jan 31 2018, 3:51 PM · Differential, Maniphest
epriestley closed T10050: Differential-to-Asana integration, like with JIRA as Wontfix.

Because of the high degree of complexity there's basically zero chance we'll ever build this without active customer interest, and we have none today. Closing this until interest arises.

Jan 31 2018, 3:48 PM · Doorkeeper, Differential, Asana, Feature Request
epriestley closed T3906: Generalize the "Ref / Fixes" relationship between revisions and tasks in all systems as Wontfix.

We don't have any use cases for this today so I don't plan to pursue it. It's conceptually reasonable, but complex, and there's no customer interest.

Jan 31 2018, 3:45 PM · Restricted Project, Differential, Doorkeeper
epriestley added a comment to T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.

T11934 is a possible way forward on this (and other niche things) without adding a lot of Javascript and UI complexity, by supporting it through !fixes.

Jan 31 2018, 3:44 PM · Customer Impact, Maniphest, Differential
epriestley added a comment to T5132: Document the special syntax you can use in commit messages to cause effects.

One possible approach for this is:

Jan 31 2018, 3:41 PM · Guides, Diffusion
epriestley closed T1751: Consider ways to improve revert handling as Resolved.

I'm going to roll this forward into T13057.

Jan 31 2018, 3:39 PM · Restricted Project, Diffusion, Differential
epriestley triaged T13057: Formalize "reverts" and "resurrects" between revisions as Normal priority.
Jan 31 2018, 3:38 PM · Differential
epriestley closed T8345: Add task tabs for "Mentions" and "Merged" as Resolved.

We shipped "Mentions" and "Duplicates" some time ago.

Jan 31 2018, 3:13 PM · Restricted Project, FreeBSD, Maniphest
epriestley closed T8345: Add task tabs for "Mentions" and "Merged", a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jan 31 2018, 3:13 PM · Maniphest
epriestley closed T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs as Resolved.

See T13056 for followup.

Jan 31 2018, 2:40 PM · Transactions, Ops, Phacility
epriestley triaged T13056: Remove "data" from edge infrastructure as Low priority.
Jan 31 2018, 2:40 PM · Infrastructure
epriestley added a comment to T13055: Maybe "translation.override" should be locked.

One attack is that you can override the content of email and then send invite or welcome mail that says whatever you want, whether the victim has a Phabricator account (welcome) or not (invite).

Jan 31 2018, 12:33 PM · Config, Security
epriestley triaged T13055: Maybe "translation.override" should be locked as Low priority.
Jan 31 2018, 4:20 AM · Config, Security
epriestley closed T6187: Allow query results to be exported to spreadsheet rendered in the browser as Wontfix.

After T13049 this is relatively within reach, but we haven't seen other requests for it so I don't currently plan to pursue it.

Jan 31 2018, 12:38 AM · ApplicationSearch
epriestley added a revision to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file: Unknown Object (Differential Revision).
Jan 31 2018, 12:25 AM · Security

Jan 30 2018

epriestley added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

This is relevant now that work related to T13049 has added CSV support.

Jan 30 2018, 11:54 PM · Security
epriestley closed T3461: Improve documentation around Maniphest Excel exports as Wontfix.

More or less obsoleted by work in T13049.

Jan 30 2018, 11:49 PM · Maniphest
epriestley closed T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.) as Resolved.

That's as far as I plan to take this for now. I think the additional features described above (filter, reorder, reformat, and broader field and application support) are all reasonable if use cases arise, but am not currently aware of use cases. We can return to that stuff when use cases arise.

Jan 30 2018, 11:48 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 9:35 PM · Plans, Data Exporters
epriestley triaged T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction as Normal priority.
Jan 30 2018, 8:53 PM · Plans, Differential, Harbormaster
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

I just let that run for a while but it finished at some point:

Jan 30 2018, 8:43 PM · Transactions, Ops, Phacility
epriestley updated the task description for T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.).
Jan 30 2018, 8:38 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 8:16 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 8:07 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 7:52 PM · Plans, Data Exporters
epriestley closed T10655: Phacility cluster mail deliverability issue as Resolved.
Jan 30 2018, 7:14 PM · Ops, Phacility
epriestley added a comment to T10655: Phacility cluster mail deliverability issue .

I'm going to roll this forward into T12677 since SES managed to one-up this by a healthy margin in T12237.

Jan 30 2018, 7:14 PM · Ops, Phacility
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

(They got back to me and we're scheduling a call.)

Jan 30 2018, 7:01 PM · Phacility, Security, Mail
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 4:06 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 3:59 PM · Plans, Data Exporters
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

Mailgun has yet to respond to me after about three weeks, so I send them a followup.

Jan 30 2018, 3:25 PM · Phacility, Security, Mail
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 3:06 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 2:12 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 1:54 PM · Plans, Data Exporters
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.
...
 OPTIMIZE  Optimizing table "<instance>_audit"."audit_transaction"...
  DONE  Compacted table by 139 GB in 910,219ms.
...
Jan 30 2018, 12:53 PM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

The compaction completed overnight. I'm optimizing the tables now.

Jan 30 2018, 12:32 PM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

Pool is full again, repo is upgrading, edges are compacting on the instance shard.

Jan 30 2018, 3:23 AM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

web004 is deploying now.

Jan 30 2018, 3:16 AM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

web004 died abruptly so I'm going to fix that and deploy these changes at the same time.

Jan 30 2018, 3:12 AM · Transactions, Ops, Phacility

Jan 29 2018

epriestley updated the task description for T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.).
Jan 29 2018, 11:10 PM · Plans, Data Exporters
epriestley closed T5391: Support custom fields in 'Export to Excel' as Resolved.

Resolved by D18959 + D18960. See also T13049.

Jan 29 2018, 11:08 PM · Data Exporters
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

Even on our fairly normal data, the effect was a little bit more dramatic than I'd expected:

Jan 29 2018, 11:04 PM · Transactions, Ops, Phacility
epriestley closed T5166: Expand the BulkJob tool as Resolved.

D18962 uses this to implement "Export Data" for large result sets.

Jan 29 2018, 10:59 PM · Restricted Project, Phacility, Daemons
epriestley closed T5166: Expand the BulkJob tool, a subtask of T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag, as Resolved.
Jan 29 2018, 10:59 PM · Drydock, Diffusion
epriestley closed T5166: Expand the BulkJob tool, a subtask of T7307: Daemons UI is confusing when you aren't an administrator, as Resolved.
Jan 29 2018, 10:59 PM · Daemons, Phacility
epriestley closed T5166: Expand the BulkJob tool, a subtask of T6004: When moving a wiki page with subpages prompt to also move subpages, as Resolved.
Jan 29 2018, 10:59 PM · Phriction
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

I'm going to optimize + probe secure001 now and see if any of the tables above shrunk. I'm expecting a very modest effect combined with zero user visible changes in the UI despite throwing away a bunch of data.

Jan 29 2018, 8:42 PM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

Took like 3-ish minutes and did this:

Jan 29 2018, 8:40 PM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

I double checked that our backups are working.

Jan 29 2018, 8:35 PM · Transactions, Ops, Phacility
epriestley removed a project from T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs: 🐳.
Jan 29 2018, 7:41 PM · Transactions, Ops, Phacility
epriestley added a project to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs: 🐳.

Editing some edges on the new code as a sanity check before I compact things.

Jan 29 2018, 7:41 PM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

(Pushing this to secure, stuff might be funky for a minute while I gently massage the database.)

Jan 29 2018, 7:36 PM · Transactions, Ops, Phacility
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 7:31 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 4:59 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 4:52 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 4:25 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 3:57 PM · Plans, Data Exporters
epriestley added a comment to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.).

It looks like PHPExcel was formally deprecated on December 24, 2017 but I'm not planning to switch to its successor, PhpSpreadsheet, until we run into some specific motivator.

Jan 29 2018, 3:46 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 3:35 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 3:26 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 3:22 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 5:28 AM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 3:04 AM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 2:35 AM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 29 2018, 2:28 AM · Plans, Data Exporters
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Jan 29 2018, 1:54 AM · Herald
epriestley added a comment to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.).

See PHI324.

Jan 29 2018, 1:31 AM · Plans, Data Exporters

Jan 28 2018

epriestley added a comment to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.).

See PHI323.

Jan 28 2018, 3:53 PM · Plans, Data Exporters
epriestley closed T12484: Write some tests for Phortune as Resolved.

This hasn't had any stability issues for a while.

Jan 28 2018, 12:20 AM · Phortune
epriestley closed T12495: Provide a conduit method to retrieve inline comments associated with a diff as Resolved.

transaction.search now returns comments and inlines, including path, line, length, and reply information.

Jan 28 2018, 12:19 AM · Feature Request
epriestley closed T12974: Upgrading: "Ferret" Fulltext Engine as Resolved.

I think everything we know about has been resolved.

Jan 28 2018, 12:03 AM · Installing & Upgrading, Search

Jan 27 2018

epriestley moved T4190: Rebuild remarkup image proxying from Backlog to Intermediate on the Contributor Onboarding board.
Jan 27 2018, 11:49 PM · Contributor Onboarding, Remarkup
yelirekim updated the task description for T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console.
Jan 27 2018, 10:10 PM · Daemons
epriestley moved T11138: mail is not delivered if metamta.placeholder-to-recipient is null from v3 to Stamps/Failover on the Mail board.
Jan 27 2018, 9:58 PM · Mail, Bug Report
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Jan 27 2018, 9:58 PM · Plans, Must Encrypt Mail, Mail
epriestley moved T9141: Rename "MetaMTA" to "Mail" from v3 to Far Future on the Mail board.
Jan 27 2018, 9:57 PM · Restricted Project, Mail
epriestley moved T10448: Modularize mail tags from v3 to Stamps/Failover on the Mail board.
Jan 27 2018, 9:57 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley moved T7477: Handle inbound email with phabricator address in the CC from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:57 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley moved T4776: Notify users when someone takes an action that takes them off an object's recipient list from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:56 PM · Mail, Restricted Project, Transactions
epriestley moved T11363: Differential "revision updated" mail preference is pretty useless from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:56 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley moved T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Backlog to Future on the Mail board.
Jan 27 2018, 9:56 PM · Diffusion (v3), Differential, Mail
epriestley closed T12033: Large diffs can still repeatedly fail to insert as Resolved.

This is resolved as far as I'm aware. See also T11767 (improvements to these limits), PHI125 (similar issue with non-UTF8 attachments failing to insert) and T13053 (planning).

Jan 27 2018, 9:55 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley closed T12033: Large diffs can still repeatedly fail to insert, a subtask of T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion, as Resolved.
Jan 27 2018, 9:55 PM · Diffusion (v3), Differential, Mail
epriestley moved T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045] from Backlog to Future on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Security
epriestley moved T12404: Implement a first-party SMTP client from Backlog to Future on the Mail board.
Jan 27 2018, 9:54 PM · Infrastructure, Mail
epriestley moved T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Bug Report
epriestley moved T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Bug Report
epriestley moved T12677: Support multiple mail delivery services for automatic failover from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Phacility, Mail
epriestley moved T12689: Mail is still received after resigning from a revision from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Differential, Bug Report
epriestley moved T13037: An attacker gained staff access to Mailgun and was able to read customer API keys from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Phacility, Security, Mail
epriestley moved T13053: Plans: Mail Tags and Failover from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:53 PM · Plans, Must Encrypt Mail, Mail
epriestley closed T11337: Mail v3 as Wontfix.

I'm rolling this forward into T13053.

Jan 27 2018, 9:53 PM · llvm, Mail
epriestley triaged T13053: Plans: Mail Tags and Failover as Normal priority.
Jan 27 2018, 9:52 PM · Plans, Must Encrypt Mail, Mail
epriestley added a project to T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console: Daemons.
Jan 27 2018, 9:10 PM · Daemons
epriestley added a comment to T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console.

If that doesn't work, you might try adding some logging to PhabricatorDaemonEventListener->handleLogEvent() to see if the sequence of events you're receiving matches my expectations or not. It's hard to log out of this context because normal tools (var_dump(), phlog(), throw new Exception(), etc) won't necessarily end up anywhere very helpful, but you can do this to create an ad-hoc logfile:

Jan 27 2018, 8:54 PM · Daemons
epriestley added a comment to T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console.

The daemon log (at /daemon/) shows status icons for running (or recently-known) daemons. This stuff lives in PhabricatorDaemonLogViewController. The status PhabricatorDaemonLog::STATUS_WAIT represents two (slightly-more-than-two) different scenarios:

Jan 27 2018, 8:51 PM · Daemons
avivey awarded T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console a Like token.
Jan 27 2018, 8:18 PM · Daemons
yelirekim triaged T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console as Low priority.
Jan 27 2018, 5:36 PM · Daemons
epriestley added a revision to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs: Restricted Differential Revision.
Jan 27 2018, 3:33 PM · Transactions, Ops, Phacility