Page MenuHomePhabricator
Feed All Stories

Apr 13 2017

amckinley closed T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations as Resolved.
Apr 13 2017, 8:57 PM · Contributor Onboarding, Bug Report
amckinley closed T12532: `syntax.filemap` does not validate input as Resolved.
Apr 13 2017, 8:57 PM · Contributor Onboarding, Config, Bug Report
amckinley added a revision to T12532: `syntax.filemap` does not validate input: Unknown Object (Differential Revision).
Apr 13 2017, 8:52 PM · Contributor Onboarding, Config, Bug Report
amckinley claimed T12532: `syntax.filemap` does not validate input.
Apr 13 2017, 8:25 PM · Contributor Onboarding, Config, Bug Report
amckinley added a revision to T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations: Unknown Object (Differential Revision).
Apr 13 2017, 8:23 PM · Contributor Onboarding, Bug Report
epriestley awarded T12524: Modernize Countdown a Mountain of Wealth token.
Apr 13 2017, 8:19 PM · Countdown
amckinley closed T12524: Modernize Countdown as Resolved.
Apr 13 2017, 8:16 PM · Countdown
amckinley claimed T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations.
Apr 13 2017, 8:15 PM · Contributor Onboarding, Bug Report
amckinley added a revision to T12524: Modernize Countdown: Unknown Object (Differential Revision).
Apr 13 2017, 8:02 PM · Countdown
chad added a revision to T12550: Move Conpherence to Modular Transactions: Unknown Object (Differential Revision).
Apr 13 2017, 8:00 PM · Conpherence (v4)
chad renamed T11934: Make email commands ("/subscribe") work in all contexts, including Conpherence ("/me") from Conpherence action/emote support (/me) to Add basic slash commands to Conpherence.
Apr 13 2017, 7:43 PM · Conpherence (v4), Feature Request
chad closed T12551: Disabled participants shouldn't be listed in the sidebar as Wontfix.
Apr 13 2017, 7:37 PM · Conpherence (v4)
chad added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Yup, no one in general chat is disabled.

Apr 13 2017, 7:37 PM · Conpherence (v4)
amckinley added a revision to T12524: Modernize Countdown: Unknown Object (Differential Revision).
Apr 13 2017, 7:18 PM · Countdown
amckinley created P2038 (An Untitled Masterwork).
Apr 13 2017, 7:16 PM
amckinley edited P2037 search results.
Apr 13 2017, 7:10 PM
amckinley edited P2037 search results.
Apr 13 2017, 7:09 PM
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

"RU SUB" DKP are the best DKP.

Apr 13 2017, 7:03 PM · Conpherence (v4)
amckinley created P2037 search results.
Apr 13 2017, 7:02 PM
chad added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Apr 13 2017, 6:59 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

There are probably a couple of tags on hovercards and maybe user profiles which should be color-coordianted for consistency.

Apr 13 2017, 6:45 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Orange and red/vermillion are already used for "Away" and "Busy", and I think green would be confusing (similar to "online"), so maybe indigo/pink/blue/violet?

Apr 13 2017, 6:44 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

"Busy" and "Away" are temporal too. I think all three states are important: they indicate that you shouldn't expect a response from the user.

Apr 13 2017, 6:42 PM · Conpherence (v4)
chad added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Maybe like, yellow or orange... indigo... vermillion?

Apr 13 2017, 6:42 PM · Conpherence (v4)
chad added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

At a minimum I'd prefer a different icon than administratively disabled. Mostly, I don't think it matters this information is conveyed, since it sounds like it's expected to be temporal?

Apr 13 2017, 6:39 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

If auth.require-email-verification is off, they receive notifications in Phabricator itself.
If auth.require-email-verification is on, they can not log in or see anything until they verify their email addresses.

Apr 13 2017, 6:36 PM · Conpherence (v4)
chad added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Like if we just send notifications if you're not verified, I think that's sufficient

Apr 13 2017, 6:33 PM · Conpherence (v4)
chad added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Do they get notifications? Or we cut out completely? Basically I'd like to remove the dot for email-not-verified if possible.

Apr 13 2017, 6:31 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

(Although I think the dots appeared before that change, when you enabled auth.require-email-verification to combat printer faxers.)

Apr 13 2017, 6:30 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Right.

Apr 13 2017, 6:30 PM · Conpherence (v4)
chad added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Do we not send email to unverified people now?

Apr 13 2017, 6:27 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

(But almost no users in General Chat are actually disabled, I think -- all the dots are for unverified users. Not sure if those should act the same, since we probably wouldn't sort away/busy users to the bottom? Also, why not just kick those users out in normal cases?)

Apr 13 2017, 6:26 PM · Conpherence (v4)
epriestley added a comment to T12551: Disabled participants shouldn't be listed in the sidebar.

Maybe just sort them to the bottom?

Apr 13 2017, 6:25 PM · Conpherence (v4)
chad renamed T12200: Typeahead completion (of any kind) does not work with Persistent Chat on from Typeahead completion (of any kind) does not work in Persistent Chat to Typeahead completion (of any kind) does not work with Persistent Chat on.
Apr 13 2017, 6:08 PM · Conpherence (v4), Quicksand, Bug Report
chad created T12551: Disabled participants shouldn't be listed in the sidebar.
Apr 13 2017, 6:03 PM · Conpherence (v4)
amckinley claimed T12524: Modernize Countdown.
Apr 13 2017, 5:59 PM · Countdown
amckinley added a revision to T12524: Modernize Countdown: Unknown Object (Differential Revision).
Apr 13 2017, 5:59 PM · Countdown
cspeckmim added a project to T8109: Using 'arc feature' on mercurial repository gave an exception: Bug Report (Needs Information).
Apr 13 2017, 5:48 PM · Bug Report (Needs Information), Mercurial, Arcanist
amckinley added a comment to T11934: Make email commands ("/subscribe") work in all contexts, including Conpherence ("/me").

Would also like to see "/here" in Conpherence send a notification to all users in the current room.

Apr 13 2017, 5:36 PM · Conpherence (v4), Feature Request
chad created T12550: Move Conpherence to Modular Transactions.
Apr 13 2017, 5:27 PM · Conpherence (v4)
chad added a comment to T12549: Conpherence @mention auto-complete should prioritize members of the room.

I have to type @epri and @amck to find you both, and it's my most common mention.

Apr 13 2017, 5:25 PM · Conpherence (v4), Feature Request
chad added a comment to T12549: Conpherence @mention auto-complete should prioritize members of the room.

This should probably work globally on any object.

Apr 13 2017, 5:25 PM · Conpherence (v4), Feature Request
amckinley created T12549: Conpherence @mention auto-complete should prioritize members of the room.
Apr 13 2017, 5:22 PM · Conpherence (v4), Feature Request
chad closed T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 4:19 PM · Conpherence (v4), Security
chad closed T11704: Conpherence should have a 'joinable' search filter? as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 4:19 PM · Conpherence (v4)
epriestley added a revision to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`: Unknown Object (Differential Revision).
Apr 13 2017, 2:55 PM · Auth, Bug Report
epriestley added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

In particular, when you connect over HTTP to a security.require-https install, we normally just immediately redirect you to https://....

Apr 13 2017, 2:13 PM · Auth, Bug Report
epriestley added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

Was this on a test install on localhost? I can only reproduce this if the remote address is part of cluster.addresses.

Apr 13 2017, 1:42 PM · Auth, Bug Report
epriestley added a comment to T12548: Unable to initialize database with invalid credentials in configuration file.

This could definitely be more clear, but I think this is currently expected -- you still need to have valid configuration even when providing additional administrative credentials.

Apr 13 2017, 1:25 PM · Database, Bug Report
epriestley added a comment to T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.

(And I think "Conpherence as an announcement tool" is a very marginal use case anyway -- today, Phame is probably better already?)

Apr 13 2017, 12:22 PM · Conpherence (v4), Security
epriestley added a comment to T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.

That seems reasonable to me. We could implement a "read-only" equivalent later by having a flag like "require edit permission to send messages to this room" if we need it. That probably makes more sense anyway -- I can't really think of any use cases where a room is sort-of read-only, but the users who can post to it are different than users who can edit it.

Apr 13 2017, 12:20 PM · Conpherence (v4), Security
epriestley added a comment to T12525: amckinley's Onboarding.

To clarify, I meant this:

Apr 13 2017, 12:01 PM · Phacility, Contributor Onboarding
hach-que added a comment to T12525: amckinley's Onboarding.

Well, this is a GitHub-like isn't it? In the context of what was quoted, it was specifically GitHub itself that was mentioned.

Apr 13 2017, 7:36 AM · Phacility, Contributor Onboarding
rabahmeradi added a comment to T12525: amckinley's Onboarding.

I'd guess most people use the free Phacility plan because they need private repositories.

I don't think so because there are GitHub like solution that offer private repositories for free.

Apr 13 2017, 7:33 AM · Phacility, Contributor Onboarding
hach-que added a comment to T12525: amckinley's Onboarding.

I'd personally be completely happy if all free users use GitHub forever and we only take their paying users

Apr 13 2017, 7:22 AM · Phacility, Contributor Onboarding
joshuaspence created T12548: Unable to initialize database with invalid credentials in configuration file.
Apr 13 2017, 7:01 AM · Database, Bug Report
joshuaspence renamed T12547: Confusing error message when trying to register an account over HTTP with `security.require-https` from Unable to create initial user account to Confusing error message when trying to register an account over HTTP with `security.require-https`.
Apr 13 2017, 6:21 AM · Auth, Bug Report
joshuaspence added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

Actually, I figured it out... The problem was that I had security.require-https set to true but I hadn't yet setup HTTPS so I was only using plain old HTTP.

Apr 13 2017, 6:20 AM · Auth, Bug Report
joshuaspence added a comment to T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.

I tried to reproduce this on a Phacility host, but it doesn't reproduce there because the first user account is setup via OAuth.

Apr 13 2017, 5:50 AM · Auth, Bug Report
joshuaspence created T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`.
Apr 13 2017, 5:49 AM · Auth, Bug Report
chad moved T8429: New Conpherence count appears even if I get an email of the message from Backlog to v4 on the Conpherence board.
Apr 13 2017, 5:20 AM · Conpherence (v4)
chad moved T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for from Backlog to v4 on the Conpherence board.
Apr 13 2017, 4:47 AM · Conpherence (v4), Security
chad added a revision to T11704: Conpherence should have a 'joinable' search filter?: Unknown Object (Differential Revision).
Apr 13 2017, 4:11 AM · Conpherence (v4)
chad added a revision to T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for: Unknown Object (Differential Revision).
Apr 13 2017, 4:11 AM · Conpherence (v4), Security
chad claimed T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.
Apr 13 2017, 3:50 AM · Conpherence (v4), Security
chad added a comment to T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.

I think we should remove the CAN_JOIN. If you can see it, you can join it. I don't see any parallel in Slack and looks like there are mods that add it forceably by kicking you off a channel if you leave a message. lulz.

Apr 13 2017, 3:49 AM · Conpherence (v4), Security
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Unknown Object (Differential Revision).
Apr 13 2017, 2:20 AM · Search, Customer Impact, Bug Report
epriestley closed T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 2:08 AM · Search, Customer Impact, Bug Report
epriestley closed T12003: Explain to users how fulltext queries are parsed and executed as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 2:08 AM · Search
epriestley closed T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 12:57 AM · Search
epriestley added a comment to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty.

I'm only like 85% sure that D17667 really fixes things so yell if it still looks ~weird~.

Apr 13 2017, 12:57 AM · Search
chad added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

(◍•ᴗ•◍)

Apr 13 2017, 12:52 AM · Search
alanh added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

\o/

Apr 13 2017, 12:41 AM · Search
epriestley closed T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it as Resolved.

Searching for ひらがな or 漢字汉字 or 漢字汉 now finds this task. Searching for 漢字 or 汉字 does not, but I think that's because they're under the minimum token length.

Apr 13 2017, 12:19 AM · Search
epriestley closed T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it, a subtask of T12003: Explain to users how fulltext queries are parsed and executed, as Resolved.
Apr 13 2017, 12:18 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

漢字汉

Apr 13 2017, 12:09 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

ひらがな
漢字汉字

Apr 13 2017, 12:08 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

漢字
汉字

Apr 13 2017, 12:07 AM · Search
epriestley renamed T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token from Stemming + MySQL Fulltext search can lead to unexpected results to MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.
Apr 13 2017, 12:05 AM · Search, Customer Impact, Bug Report
epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Unknown Object (Differential Revision).
Apr 13 2017, 12:05 AM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Unknown Object (Differential Revision).
Apr 13 2017, 12:04 AM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Unknown Object (Differential Revision).
Apr 13 2017, 12:04 AM · Search, Customer Impact, Bug Report

Apr 12 2017

epriestley closed T12537: Ambiguous display of commits in maniphest as Resolved.

Great! Handling of branches is definitely something we'd like to improve in the future, but most of the improvements we have planned require significant amounts of work. If you eventually run into limitations with this approach, hopefully we'll have some improvements in place by then.

Apr 12 2017, 11:24 PM · Feature Request
razvanm added a comment to T12537: Ambiguous display of commits in maniphest.

I can confirm that the solution works properly. Once again, thanks! :-)

Apr 12 2017, 11:21 PM · Feature Request
razvanm added a comment to T12537: Ambiguous display of commits in maniphest.

Thanks for the suggestion. I'm trying that now.

Apr 12 2017, 10:49 PM · Feature Request
epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Unknown Object (Differential Revision).
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Unknown Object (Differential Revision).
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Unknown Object (Differential Revision).
Apr 12 2017, 10:44 PM · Search, Customer Impact, Bug Report
epriestley added a revision to T7860: When users search for "#x y", treat "#x" as a project hashtag: Unknown Object (Differential Revision).
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Unknown Object (Differential Revision).
Apr 12 2017, 10:43 PM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Unknown Object (Differential Revision).
Apr 12 2017, 10:43 PM · Search, Customer Impact, Bug Report
epriestley added a revision to T7860: When users search for "#x y", treat "#x" as a project hashtag: Unknown Object (Differential Revision).
Apr 12 2017, 10:43 PM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Unknown Object (Differential Revision).
Apr 12 2017, 10:43 PM · Search
epriestley added a comment to T12537: Ambiguous display of commits in maniphest.

Er, that wasn't even close -- this is simpler and actually works:

Apr 12 2017, 10:17 PM · Feature Request
epriestley added a comment to T12537: Ambiguous display of commits in maniphest.

I think you could do something like this (made-up pseudocode because my bash is garbage):

Apr 12 2017, 10:13 PM · Feature Request
razvanm added a comment to T12537: Ambiguous display of commits in maniphest.

We routinely have multiple commits on multiple branches because we mirror (via Harbormaster) our master branch to an experimental/master branch. This is safe because the two branches are never touching the same paths.

Apr 12 2017, 10:07 PM · Feature Request
epriestley added a revision to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty: Unknown Object (Differential Revision).
Apr 12 2017, 9:58 PM · Search
chad closed T11730: Remove image crop from Conpherence as Resolved by committing Restricted Diffusion Commit.
Apr 12 2017, 9:18 PM · Conpherence (v4)
chad added a revision to T11730: Remove image crop from Conpherence: Restricted Differential Revision.
Apr 12 2017, 9:12 PM · Conpherence (v4)
chad closed T12485: Conpherence MenuItem as Resolved.
Apr 12 2017, 8:48 PM · Conpherence (v4)