Page MenuHomePhabricator

Using 'arc feature' on mercurial repository gave an exception
Closed, InvalidPublic

Description

This only happened on one specific repository I have, doesn't happen in other repos.

[2015-05-07 14:55:43] ERROR 2: max(): Array must contain at least one element at [/Users/cspeck/Projects/phacility/arcanist/src/workflow/ArcanistFeatureWorkflow.php:332]
arcanist(head=master, ref.master=8919a9c5b55e), phutil(head=master, ref.master=cb8cdccb1a50)
  #0 max(array) called at [<arcanist>/src/workflow/ArcanistFeatureWorkflow.php:332]
  #1 ArcanistFeatureWorkflow::printBranches(array, array) called at [<arcanist>/src/workflow/ArcanistFeatureWorkflow.php:94]
  #2 ArcanistFeatureWorkflow::run() called at [<arcanist>/scripts/arcanist.php:378]
[2015-05-07 14:55:43] ERROR 2: max(): Array must contain at least one element at [/Users/cspeck/Projects/phacility/arcanist/src/workflow/ArcanistFeatureWorkflow.php:333]
arcanist(head=master, ref.master=8919a9c5b55e), phutil(head=master, ref.master=cb8cdccb1a50)
  #0 max(array) called at [<arcanist>/src/workflow/ArcanistFeatureWorkflow.php:333]
  #1 ArcanistFeatureWorkflow::printBranches(array, array) called at [<arcanist>/src/workflow/ArcanistFeatureWorkflow.php:94]
  #2 ArcanistFeatureWorkflow::run() called at [<arcanist>/scripts/arcanist.php:378]

Arcanist on my machine is at 6f7bedaceb6857a084b4914679a43fdedfb720da

I'm not sure what information you would want about my repo, but here's some exploratory output:

host128:product cspeck$ hg book
   master                    93075:745f2fa99cb7
host128:product cspeck$ hg head
changeset:   93076:166ff857f1e5
tag:         tip
user:        cspeck
date:        Wed May 06 16:10:58 2015 -0400
summary:     Task #12345 - Cleaned up the report template wizard which was also leaking report.

host128:product cspeck$ hg par
changeset:   93076:166ff857f1e5
tag:         tip
user:        cspeck
date:        Wed May 06 16:10:58 2015 -0400
summary:     Task #12345 - Cleaned up the report template wizard which was also leaking report.

host128:product cspeck$ hg out
comparing with ssh://machine/repos/release-6.5/product
searching for changes
changeset:   93076:166ff857f1e5
tag:         tip
user:        cspeck
date:        Wed May 06 16:10:58 2015 -0400
summary:     Task #12345 - Cleaned up the report template wizard which was also leaking report.

host128:product cspeck$ cat .arcconfig 
{
  "project.name"          :  "product release-6.5",
  "phabricator.uri"       :  "https://repo.mycompany.com/",
  "repository.callsign"   :  "PRODUCT",
  "history.immutable"     :  false,
  "arc.land.onto.default" :  "master"
}

host128:product cspeck$ hg glog -l 3 --template="{node}"
@  166ff857f1e5469a4964196480c77348d6aa9578
|
o  745f2fa99cb711a38d98abd739d7eeb7aab5e2c1
|
o  401ad66dae4fa07570f5f09126ab87ee153f9c2b
|

Event Timeline

cspeckmim raised the priority of this task from to Needs Triage.
cspeckmim updated the task description. (Show Details)
cspeckmim added a subscriber: cspeckmim.

I pulled new commits into the problematic repository without thinking, then checked arc feature again and it's working again, sorry.

I couldn't get this to happen with the HGTEST repo, but with mine it seems like I can sometimes reproduce this by updating the working set to a changeset that is not head, or another bookmark.

epriestley added a subscriber: epriestley.

I'm just going to nuke this since there's no repro. This workflow has also been rewritten on the experimental branch and the specific error encountered here should now be impossible.