Ah. From the workaround ("View Unified", then "View Side-by-Side") I'm guessing the menu maybe isn't refreshing properly somehow, but I'm not sure how to reproduce it given the provided steps.

I might have misunderstood the ticket to being no "show less context" option after you're show more context.

I can't immediately reproduce this -- were you able to, @chad?

I merged T11740 and T11739 here since they're approximately the same problem from our perspective ("make messages adhere to project rules, where the project rules are immutable").

We use a heuristic to guess which function, class, etc., the context is in. Git uses some similar heuristic.

This feature request doesn't state a root problem. Please see Contributing Feature Requests and Describing Root Problems.

This feature request doesn't state a root problem. Please see Contributing Feature Requests and Describing Root Problems.

What problem specifically are you trying to solve? See Contributing Feature Requests and Describing Root Problems.

I'm referring to that area in general, but I'm talking about e.g. the src/applications/conpherence/application/PhabricatorConpherenceApplication.php section. The grey area above the diff shows

'/conpherence/' => array(

when it should say something like

public function getRoutes() {

Are you referring to the function in the grey area above the diff?

There isn't enough information here for the upstream to move forward on this ticket. It appears to be a local PHP issue, but without further information we don't know how to detect or warn you about this set up. If you're using PHP7 for example, it's not currently supported. If you're using PHP5.6, make sure XML is enabled.

Unfortunately we don't accept feature requests along this vein. We require root problems on every request. See Contributing Feature Requests and Describing Root Problems. In this case, we'd want to understand why you're needing to award and rescind tokens so often to begin with. This isn't a common workflow we feel needs to be optimized (since Tokens are optional).

The code is a little better factored now and it's possible that the patch to DifferentialInlineCommentMailView is a pretty small one (and it may work in both text and HTML modes, as a possible benefit, although I suspect your install's use of HTML mail is much lower than most).

@epriestley - makes sense; I've been approached by some folks about our setup because they wanted kernel devs to get an actual code review system, who apparently have a similar mindset to compiler developers, but that's probably a long shot anyway :)

@klimek Your install is the only install we're aware of that is interested in a rendering mode like that (feedback about the old rendering was generally negative; feedback about the new rendering has been generally positive). Unless we become aware of much wider interest in such a rendering mode, I don't plan to reintroduce it upstream.

Note that this feature (text mode unified diff) is crucial for our deployment (requirement for text-only mails to contain reasonable diff snippets).

@HarryOtto, your message is off topic in this thread and is so tenuously related to anything here that it looks like it might be SEO linkbuilding spam, so I've removed it.

Design atrocity incoming for T10747.

Ah yeah it could be related to that (policy errors/unit test failures), although I wouldn't really describe this as "extremely rare" (except of course when I'm trying to make it happen). Some stats from grepping through logs: since last week it looks like this error has happened 73k times involving 193 distinct diffs. It's like the daemons are laughing at my inability to repro it.

I think there is an extremely rare policy error somewhere in the policy code that we've occasionally seen in the form of sporadic unit test failures. I haven't been able to reproduce them in the same environment and they're false negatives (e.g., prevent access when it would be OK to allow access) so I haven't spent a ton of effort hunting them down, but it's possible that they have the same cause.

Just spent a bit of time trying to repro this in a script but could not. The diffs always load successfully from the script. I even tried waiting until right after one of the errors popped up in the logs and then queried for that diff via the script right away.

Rough overall state of the world is that "all the hard stuff" is mostly "done" but it's probably fairly buggy, so I'm going to push on exports and some UI stuff for a bit and try to catch all those bugs while I do. Also imports are probably hard but I'm going to imagine that they aren't for now.

Yeah, agreed.

Nice idea! Also would be good to flip Description / Invitees boxes on the view page.

I think I'm going to move the recurrence controls to a separate screen, so you'll make a recurring event in two parts:

In T5523#185944, @dariusz wrote:

my expectation would be: have "Move to Workboard Column" available in the "Bulk Edit Tasks" actions.

See Restarting Phabricator, this is required any time you update Phabricator.

I can't break this any more, but if it pops up again can re-open.

I think it sort-of does something if you upload an irregularly-sized image (say, 100x200) instead of a square image. But I don't think it's particularly useful or works well even in that case, and I definitely support getting rid of it.

Can you do that today with view and edit policy?

In T3353#179075, @epriestley wrote:

• Text/Phriction Inline Comments: See T1894 for followup. I'll update this shortly in light of T7643.

Should basically just be UI, yeah.

At least search across all threads I can see works, so It should be all UI to add it per room. I'll take a stab at this next unless there is something other than UI blocking.

Seems like all the pieces are here except UI, @epriestley ?

I confirm, changing All users to Public fixed it. Thanks!

oh god, this looks like a lot of crazy js.