Page MenuHomePhabricator
Create Task
Maniphest T11739

merge commit populated from phabricator fields shows "Summary" field tag in-line with its contents.
Closed, DuplicatePublic
Actions

Description

When creating Differential online (either pasting in the diff or doing "arc diff --preview" then adding the diff to a new revision) then doing "arc land --merge" I get a merge commit with "Summary: " inline with the summary text.

Whereas creating a differential revision with "arc diff" leads to the commit being amended with "Summary" on a separate line to the summary text. Which I prefer as it doesn't change the column length of my commit message.

e.g. the merge request created for for https://phabricator.kde.org/D2935 looks like:

Improve ksmserver debug output

Summary: Correct misleading debug output. Make all ksmserver output (apart from the tests) controllable with QLoggingCategory.

Test Plan: Compiled, logged in and out both with & without "ksmserver.debug=true" in qtlogging.ini

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2935

when I would expect

...
Summary: 
Correct misleading debug output. Make all ksmserver output (apart from the tests) controllable with QLoggingCategory.
...

$ arc version
arcanist 9e82ef979e8148c43b9b8439025d505b1219e213 (25 Aug 2016)
libphutil f8af794b2135904c2f4180647ad6f81775a773a2 (12 Sep 2016)
but a quick skim of recent commits seems to show no relevant changes since

Related Objects

Event Timeline

oliverhenshaw created this task.Oct 6 2016, 5:27 PM
Herald added a subscriber: eadler. · View Herald TranscriptOct 6 2016, 5:27 PM
chad added a subscriber: chad.Oct 6 2016, 5:38 PM

This feature request doesn't state a root problem. Please see Contributing Feature Requests and Describing Root Problems.

epriestley mentioned this in T2920: Modularize the pipeline for producing final commit messages.Oct 6 2016, 5:48 PM
epriestley closed this task as a duplicate of T2920: Modularize the pipeline for producing final commit messages.
oliverhenshaw added a comment.Oct 6 2016, 6:23 PM

I should probably have filed this as a bug report. The issue is that the commit message populated by arcanist looks different, in a surprising way, to the way the Summary information is displayed on the Differential page.

This is fairly independent of project-specific commit message norms IMO.

epriestley added a subscriber: epriestley.Oct 6 2016, 6:28 PM

We'll accept this as a bug report if you describe the conditions which lead to a newline after "Summary:". The expected behavior is that there is no newline.

Phabricator · Built by Phacility