Page MenuHomePhabricator

help limit summary fields to e.g. 80 chars wide
Closed, DuplicatePublic

Description

Fields such as Summary and Test Plan: will be added to the commit message, so it would be nice if the differential tool supported the developer in limiting the text width. Many projects have code styles or good practices that recommend limiting commit titles and bodies to e.g. 80 characters wide.

When the phabricator fields are populated by arcanist then the user can use their favourite editor to e.g. show column number, or to hard wrap or show a vertical guide at some column number. But the web tool doesn't provide this functionality.

This is a bigger issue when creating a Diff request entirely online or with "arc diff --preview" and then typing up the Summary etc. fields in the web tool. And then landing with e.g. "arc land --merge" creates a merge commit populated from the phabricator fields (and pushes it to the remote repo unless you preview with --hold)

e.g. the merge request created for for https://phabricator.kde.org/D2935 looks like:

Improve ksmserver debug output

Summary: Correct misleading debug output. Make all ksmserver output (apart from the tests) controllable with QLoggingCategory.

Test Plan: Compiled, logged in and out both with & without "ksmserver.debug=true" in qtlogging.ini

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2935

where both the "Summary" and "Test Plan" lines are too long. This is compounded by the field names being added inline (see https://secure.phabricator.com/T11739) making the first line of the summary text even longer than expected.