hahaha

And thanks for doing the legwork to pull a reproduction case out of this.

For context, we issue a query that looks like this:

fix is one line long :3

Thanks! This reproduces for me.

How does Pholio manage to not send HTML email? That's quite impressive!

This is generally easy to implement.

Yeah, not on EditEngine.

We could also rip out all CSRF cycling code completely; Rails uses infinite-duration tokens with no cycling. However, the current code hasn't really caused any issues other than this for a number of years, I believe, and there are some practical-if-obscure attacks this can partially mitigate. An example is:

I believe that something in this vein is likely the fix:

Our behavior here is also legitimately wrong, and we can look at fixing this upsteam once we understand what's actually going wrong. I think if you dig in a bit you'll find a set of reproduction steps that are something like this:

Unless they have some seriously alien hands and an predilection to scroll in the middle of the screen

I suspect this will not reproduce for us given the reproduction instructions. The code is structured like this:

A vaguely related issue is that the "Paths" list is not sorted on the "View" UI:

Zzz

I've been busy with important emoji research.

sorry maybe I am supposed to use these now 😱 😱 😱 😱

We un-install it on admin.phacility.com. :) :) :) :)

(The "Dashboard" item may also be affected.)

Ah this probably explains what I have observed on our installation too.

I currently expect to revert this change and decline to implement the feature because it makes using Differential on a phone more difficult for left-handed users (scrolling and leaving comments on a line range become conflated). See T12733#224703 for detailed discussion. If you'd like to champion this feature, let us know in the next 7 seconds.

This is an intentional change to address T1026 (allowing inline ranges to be added via touchscreen devices). Previously, it wasn't possible to comment on a range of lines on, e.g., an iPhone/iPad.

Synthetic comments (made by lint) are currently shown in the sidebar annotation with a pencil ( ) icon.

I don't think that's a very desirable behavior.

How can I reproduce the issue you're encountering?

What behavior would you expect arc to have if git commit ... produces 5GB of output (hypothetically, from a hook which prints 2.5GB of header and footer context and puts the important part in the middle)?

(You are also almost 8 months out of date; we only support recent versions of Phabricator.)

Click on logout then tried to login using google authentication and getting the error.

Please follow all the instructions when submitting a bug report. In particular, we need:

In T12739#224605, @avivey wrote:

Why is this Nuance and not Doorkeeper?

I'm going to close this; there are two possible followups -- each of which is better focused on a more specific set of problems -- but I'm not merging it into either one since I think there's a lot of general ambiguity about problems and use cases here. If you're interested in this, feel free to follow either or both.

This was basically just a work log for an earlier iteration on Nuance focused on bi-directional bridging with GitHub. We're pursuing Nuance again now, but not with the same focus, so I'm going to close this and reorganize things. Some similar task will likely fall out at the end, but with a better focus on where we're actually headed.

• The persistent header should now select more intuitive changesets.
• The scrollbar annotation is now disabled for trackpad "aesthetic" scrollbars (like the 0-width scrollbar on OSX if you don't have a mouse connected to your laptop). If we retain the element, I plan to enable it eventually, it just requires us to move content around and generally make a larger change.
• The scrollbar annotation is now disabled unless phabricator.show-prototypes is enabled.
• The scrollbar annotation should generally work better and be more useful now.
• I've deployed these changes to this host.

I'll tweak the logic, I agree that, e.g., "index.js" should be displayed in your first screenshot (and probably whatever's above it if you scrolled up just a little bit more).

I shored up D17959 a bit, landed it, and deployed it to secure.phabricator.com, then spent some time fiddling with workboards here, but couldn't find any issues with it. We have ~6,500 "wishlist" tasks on this server and it distributed all tasks near 0 (approximately 2,700 tasks) evenly across the range [4096, 4096] fast enough that I didn't notice it. I'm currently inclined not to write a dedicated migration since it seems plausible that all existing installs will survive the first dispersal without much fanfare.

If anyone wants to fix anything else here feel free, but I think we squeezed most of the soup from this stone once D17972 lands.

Oh, yeah, transaction is great. Property feels a little clutter-y since we have the transaction anyway.

I'm fine with keeping it, just thought it might be a legacy holdover from a bygone era.

oh thx :)

I'm planning to fix these, since I think they're easy or actually annoying, and just let everything else sit until we iterate or someone else notices:

In Phriction: