Page MenuHomePhabricator
Feed Advanced Search

May 1 2015

epriestley added a comment to E974: Feed Kitty Cat Again.

Like "meow meow meoww".

May 1 2015, 1:06 AM
epriestley added a comment to E974: Feed Kitty Cat Again.

She sounded really hungry earlier.

May 1 2015, 1:05 AM
lpriestley awarded E974: Feed Kitty Cat Again a Love token.
May 1 2015, 1:05 AM
epriestley renamed E974: Feed Kitty Cat Again from to Feed Kitty Cat Again.
May 1 2015, 1:02 AM
epriestley closed T7975: Calendar icons show through dialogs as Resolved by committing Restricted Diffusion Commit.
May 1 2015, 12:09 AM · Calendar
epriestley added a revision to T7975: Calendar icons show through dialogs: Unknown Object (Differential Revision).
May 1 2015, 12:06 AM · Calendar
joshuaspence added a comment to T8007: Commit was associated with unrelated diff.

There is no relevant "explain why" link because there is no transaction for someone added a commit: rPPfd5a74ad3fa1 on D19839 or someone added a differential revision: D19839 on rPPfd5a74ad3fa1.

May 1 2015, 12:04 AM · Differential, Diffusion

Apr 30 2015

epriestley added a comment to T8007: Commit was associated with unrelated diff.

Does clicking "Explain Why" explain why?

Apr 30 2015, 11:36 PM · Differential, Diffusion
joshuaspence created T8007: Commit was associated with unrelated diff.
Apr 30 2015, 11:34 PM · Differential, Diffusion
joshuaspence added a revision to T1751: Consider ways to improve revert handling: Unknown Object (Differential Revision).
Apr 30 2015, 9:56 PM · Restricted Project, Diffusion, Differential
joshuaspence added a revision to T6888: Extending revert edges: Unknown Object (Differential Revision).
Apr 30 2015, 9:56 PM · Maniphest, Differential
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

At HEAD, the messages are folded individually.

Apr 30 2015, 8:56 PM · Prioritized, Differential
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

Apr 30 2015, 8:49 PM · Prioritized, Differential
joshuaspence added a comment to T7447: Bring inline comments forward across revision updates.

I don't know @epriestley, I found it really confusing to have my comment on a different line entirely.

Apr 30 2015, 8:37 PM · Prioritized, Differential
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

The comments persist even when the code that you're talking about is deleted.

Apr 30 2015, 8:24 PM · Prioritized, Differential
chad awarded T7933: In list views, Calendar events link to months but should link to event detail pages a Haypence token.
Apr 30 2015, 8:01 PM · Calendar
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
Apr 30 2015, 7:30 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
Apr 30 2015, 6:36 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
Apr 30 2015, 5:38 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley updated subscribers of T8003: Total vote count is one less than sum of all options - V27.

You can vote for multiple options, and @cburroughs has.

Apr 30 2015, 5:15 PM · Slowvote
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
Apr 30 2015, 3:19 PM · Restricted Project, Performance, Infrastructure, Phacility
• PickySalamander awarded T5954: Modularize "Export to Excel" as a feature of ApplicationSearch a Like token.
Apr 30 2015, 3:16 PM · Custom Fields, ApplicationSearch
epriestley edited the content of Starmap.
Apr 30 2015, 2:19 PM
joshuaspence added a revision to T2226: Include a setup test for gzip enabled on the server: Unknown Object (Differential Revision).
Apr 30 2015, 1:29 PM · Setup
epriestley claimed T6930: Build Multimeter, a "why is Phabricator slow?" toolset.
Apr 30 2015, 11:53 AM · Restricted Project, Performance, Infrastructure, Phacility
epriestley claimed T7707: Implement a read-through cache layer.
Apr 30 2015, 11:53 AM · Performance
epriestley added a subtask for T5474: Support workboard column triggers which activate when a task is dropped into a column: T6502: Policy to define who can move cards in a workboard.
Apr 30 2015, 10:53 AM · Workboards (v3), Restricted Project
epriestley added a parent task for T6502: Policy to define who can move cards in a workboard: T5474: Support workboard column triggers which activate when a task is dropped into a column.
Apr 30 2015, 10:53 AM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

As a reviewer, I think bringing "Done" comments forward is quite important: it makes it a lot easier for me to verify that they're really done. This is the #1 benefit I've reaped from this feature so far.

Apr 30 2015, 10:52 AM · Prioritized, Differential
epriestley added a comment to T7447: Bring inline comments forward across revision updates.
  • T7999 suggested something along the lines of the "minimal UI".
  • Via IRC, "(btw, the 'moving comments over' feature has been a big hit here.)"
  • Via Twitter, our heroism was recognized.
Apr 30 2015, 10:50 AM · Prioritized, Differential
epriestley merged task T7999: Old done inlines into T7447: Bring inline comments forward across revision updates.
Apr 30 2015, 10:48 AM · PHUI
epriestley updated subscribers of T7447: Bring inline comments forward across revision updates.
Apr 30 2015, 10:48 AM · Prioritized, Differential
epriestley added a comment to T7999: Old done inlines.

(Including discussion of the possibility of summarizing, hiding, etc., older inlines.)

Apr 30 2015, 10:47 AM · PHUI
epriestley added a comment to T7999: Old done inlines.

I'm going to merge this into T7447, which has some ongoing discussion about this feature.

Apr 30 2015, 10:47 AM · PHUI
epriestley updated subscribers of T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies.
Apr 30 2015, 10:46 AM · Maniphest
epriestley merged task T8000: Task Organisation and Indentation into T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies.
Apr 30 2015, 10:46 AM
epriestley added a comment to T8000: Task Organisation and Indentation.

We don't currently plan to implement this. I'm going to merge this into T4207, which discusses one of the major technical issues (subtasks are a graph, not a tree).

Apr 30 2015, 10:45 AM
epriestley added a comment to T7999: Old done inlines.

One reason to show old inlines even when they are marked "Done" is that the reviewer who added the inline may want to verify that it is actually done when they look at the updated diff.

Apr 30 2015, 10:43 AM · PHUI
• mholden awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Apr 30 2015, 7:14 AM · Workboards (v3), Restricted Project
sectioneight awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Apr 30 2015, 6:28 AM · Restricted Project, Badges (v0), People
epriestley merged T7995: Permit Herald to remove reviewer into T5602: Consider flags to disable project features (can tag, can have members, can be reviewer...) .
Apr 30 2015, 12:53 AM · Projects
epriestley merged task T7995: Permit Herald to remove reviewer into T5602: Consider flags to disable project features (can tag, can have members, can be reviewer...) .
Apr 30 2015, 12:53 AM · Herald

Apr 29 2015

epriestley added a comment to T7937: Calendar events should be indexed and supported in global search.
  • Implement supportsSearch() in your Editor and return true;.
  • Implement a SearchIndexer, like ManiphestSearchIndexer.
  • You can test the indexer for non-crashiness easily with bin/search index E123.
  • To test with the actual global search in the UI, you need to:
    • be running the daemons; and
    • restart the daemons after you make any changes to your SearchIndexer.
Apr 29 2015, 11:09 PM · Calendar
epriestley added a comment to T7993: PHUITagView icons wrap over newline.

I hear CSS4 has white-space: nowrap-first-space-but-wrap-the-rest-normally;.

Apr 29 2015, 10:38 PM · PHUI
epriestley added a comment to T7940: Support proper policies in Calendar.
  • Add viewPolicy and editPolicy fields to the object.
  • Add these columns in .sql files.
Apr 29 2015, 10:36 PM · Calendar
epriestley added a comment to T7993: PHUITagView icons wrap over newline.

Particularly after T3670, these might get a lot longer than they are right now in reasonable cases.

Apr 29 2015, 10:33 PM · PHUI
epriestley added a comment to T7993: PHUITagView icons wrap over newline.

Particularly after T3670, these might get a lot longer than they are right now in reasonable cases.

Apr 29 2015, 10:32 PM · PHUI
joshuaspence added a comment to T7993: PHUITagView icons wrap over newline.

Personally, I felt that (at least in the case of my screenshot) it would be better to push the entire tag to the second line.

Apr 29 2015, 10:18 PM · PHUI
joshuaspence added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

When I first read the title of this ticket, I thought that you were going to add gamification.

Apr 29 2015, 10:15 PM · Restricted Project, Badges (v0), People
joshuaspence awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Apr 29 2015, 10:12 PM · Restricted Project, Badges (v0), People
joshuaspence created T7993: PHUITagView icons wrap over newline.
Apr 29 2015, 10:11 PM · PHUI
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

They could, yeah. We'd probably need a "List all users with badge X" UI to avoid losing functionality, but that seems pretty reasonable.

Apr 29 2015, 10:10 PM · Restricted Project, Badges (v0), People
joshuaspence added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

Could badges be used for policies? For example, Blessed Committers could be replaced with a badge potentially. This would (at least partially) solve T5602.

Apr 29 2015, 10:09 PM · Restricted Project, Badges (v0), People
qgil awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Apr 29 2015, 9:19 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

Yep. I personally intend to create hundreds of badges to award myself once this is built.

Apr 29 2015, 9:18 PM · Restricted Project, Badges (v0), People
epriestley created T7991: Show deprecated Conduit method call warning to users.
Apr 29 2015, 9:09 PM · Conduit
epriestley closed T7439: Remove "E" backward compatibility from Conpherence once Calendar is closer to launch as Resolved by committing Restricted Diffusion Commit.
Apr 29 2015, 9:03 PM · Calendar, Conpherence
epriestley closed T7439: Remove "E" backward compatibility from Conpherence once Calendar is closer to launch, a subtask of T7925: Calendar v1 Errata, as Resolved.
Apr 29 2015, 9:03 PM · Calendar
epriestley closed T7439: Remove "E" backward compatibility from Conpherence once Calendar is closer to launch, a subtask of T7570: Conpherence v2 Cleanup, as Resolved.
Apr 29 2015, 9:03 PM · Conpherence
epriestley added a revision to T7439: Remove "E" backward compatibility from Conpherence once Calendar is closer to launch: Unknown Object (Differential Revision).
Apr 29 2015, 8:59 PM · Calendar, Conpherence
epriestley claimed T7439: Remove "E" backward compatibility from Conpherence once Calendar is closer to launch.
Apr 29 2015, 8:56 PM · Calendar, Conpherence
epriestley renamed T7076: Show status of linked revisions for tasks from Show status of linked code reviews for tasks to Show status of linked revisions for tasks.
Apr 29 2015, 8:51 PM · Restricted Project, Differential, Maniphest
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

Here's a rough sketch of this. This is a ton of work and should be split into like 300 revisions. See T6526#107028 for product details.

Apr 29 2015, 8:48 PM · Restricted Project, Badges (v0), People
epriestley assigned T6526: Implement "Badges" or "Medals", for annotating special users to lpriestley.
Apr 29 2015, 8:38 PM · Restricted Project, Badges (v0), People
epriestley closed T7981: "Enable Instance" action on instance dashboard is incorrectly greyed out as manager as Resolved by committing Restricted Diffusion Commit.
Apr 29 2015, 8:38 PM · Phacility
epriestley closed T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs as Resolved by committing Restricted Diffusion Commit.
Apr 29 2015, 8:21 PM · Diffusion
epriestley added a revision to T7981: "Enable Instance" action on instance dashboard is incorrectly greyed out as manager: Unknown Object (Differential Revision).
Apr 29 2015, 3:45 PM · Phacility
epriestley added a revision to T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs: Unknown Object (Differential Revision).
Apr 29 2015, 3:17 PM · Diffusion
epriestley claimed T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs.
Apr 29 2015, 2:04 PM · Diffusion
joshuaspence added a revision to T7220: Repository without Arcanist project fails for symbols import: Unknown Object (Differential Revision).
Apr 29 2015, 1:55 PM · Diffusion
epriestley created T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs.
Apr 29 2015, 1:39 PM · Diffusion
epriestley created T7981: "Enable Instance" action on instance dashboard is incorrectly greyed out as manager.
Apr 29 2015, 1:31 PM · Phacility

Apr 28 2015

epriestley edited the content of Roadmap.
Apr 28 2015, 10:12 PM
epriestley added a comment to T7911: Quicksand fails to navigate back to page 0 on Chrome, Firefox sporadically.

If browsers are carrying state across reloads, maybe we just need to initialize JX.Quicksand.id to window.history.state || 0 (and throw away that object patch).

Apr 28 2015, 9:54 PM · Quicksand
epriestley awarded T7946: Implement PhabricatorTokenReceiverInterface on CalendarEvent a Evil Spooky Haunted Tree token.
Apr 28 2015, 7:06 PM · Calendar
epriestley awarded T7946: Implement PhabricatorTokenReceiverInterface on CalendarEvent a Evil Spooky Haunted Tree token.
Apr 28 2015, 7:06 PM · Calendar
epriestley added a comment to T7978: Persist document scroll position across "back" navigation in Quicksand.

RTL doesn't flip scrollbars for me on that fiddle:

Apr 28 2015, 6:18 PM · Quicksand, PHUI
epriestley added a comment to T7978: Persist document scroll position across "back" navigation in Quicksand.

DarkConsole shares the same scrollbar with the rest of the page, but the chat column has its own scrollbar, and needs to scroll independently of the main page content.

Apr 28 2015, 6:05 PM · Quicksand, PHUI
epriestley added a comment to T7978: Persist document scroll position across "back" navigation in Quicksand.

Disabling the pretty scrollbar alone wouldn't fix this without also removing the container frame which enables the chat column to exist.

Apr 28 2015, 5:50 PM · Quicksand, PHUI
epriestley added a comment to T7978: Persist document scroll position across "back" navigation in Quicksand.

We can possibly fake this with Quickling in the common case once we summon the courage to enable it without the column open.

Apr 28 2015, 5:48 PM · Quicksand, PHUI
epriestley closed T7976: Nested ol's are hard to parse visually as Resolved.

Presumably resolved.

Apr 28 2015, 5:38 PM · Remarkup
epriestley awarded T7444: Code block header styling a Orange Medal token.
Apr 28 2015, 5:30 PM · Design, Remarkup
epriestley added a comment to T7444: Code block header styling.

Nice, I like that.

Apr 28 2015, 5:30 PM · Design, Remarkup
epriestley added a comment to T7935: Give calendar events real invitee lists.

I think invitees are complex enough that we probably don't want to use edges to store them. Edges are good for simple relationships (like a user subscribing to an object) but not as good for more complex relationships. Invitees are likely to have a lot of state eventually (required/optional, invited/attending/declined, maybe annotations like "Speaker" for a talk, "Co-Host" for a party, or "Bringing Salad" vs "Bringing Desert" for a potluck, maybe tracking who invited you, and so on).

Apr 28 2015, 5:29 PM · Calendar
epriestley added a comment to T7975: Calendar icons show through dialogs.

From elsewhere, I think it's so that they're visible in dialogs (like "Edit Task" from a workboard with a custom date field).

Apr 28 2015, 4:33 PM · Calendar
epriestley closed T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work) as Resolved by committing Restricted Diffusion Commit.
Apr 28 2015, 3:56 PM · Diffusion
epriestley claimed T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work).
Apr 28 2015, 3:07 PM · Diffusion
epriestley closed T7971: large file upload OOMs as Resolved.

Yeah, this should be fixed at HEAD for most workflows, see:

Apr 28 2015, 3:06 PM · Files
epriestley added a revision to T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work): Unknown Object (Differential Revision).
Apr 28 2015, 3:03 PM · Diffusion
epriestley added a comment to T4131: Store LDAP domain as credential source for LDAP external accounts.

escalate from that to any other account

Apr 28 2015, 2:44 PM · Security, Auth
epriestley added a comment to T7971: large file upload OOMs.

Are you at HEAD?

Apr 28 2015, 2:27 PM · Files
epriestley added a comment to T4131: Store LDAP domain as credential source for LDAP external accounts.

No -- you point Phabricator at the new LDAP server by using a compromised administrative account and going to Auth → LDAP and changing ldap.mycompany.com to ldap.evil.com.

Apr 28 2015, 2:23 PM · Security, Auth
epriestley added a revision to T3165: Provide Search in Conpherence: Unknown Object (Differential Revision).
Apr 28 2015, 1:45 PM · Conpherence (v4)
epriestley added a revision to T3165: Provide Search in Conpherence: Unknown Object (Differential Revision).
Apr 28 2015, 11:24 AM · Conpherence (v4)

Apr 27 2015

epriestley added a comment to T3165: Provide Search in Conpherence.

Yep, thanks!

Apr 27 2015, 11:41 PM · Conpherence (v4)
epriestley claimed T6038: Design some kind of PHUITagChainView.
Apr 27 2015, 10:49 PM · Design
epriestley added a comment to T7963: Wiki heading CSS emphasizes sub-headings over headings.

See T4213 for discussion of themes/skinning, and an explanation of why we don't expose CSS/HTML as an API.

Apr 27 2015, 10:27 PM · Restricted Project
epriestley added a comment to T7963: Wiki heading CSS emphasizes sub-headings over headings.

I think our use cases are pretty much the same, the documents are just laid out a bit differently.

Apr 27 2015, 10:10 PM · Restricted Project
epriestley added a comment to T7963: Wiki heading CSS emphasizes sub-headings over headings.

I do think the weight and blackness of the subheadings can overwhelm headings a bit, for instance on the Changelog:

Apr 27 2015, 10:00 PM · Restricted Project
epriestley triaged T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules as Wishlist priority.
Apr 27 2015, 8:49 PM · Applications, Herald