Page MenuHomePhabricator

DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs
Closed, ResolvedPublic

Description

The Git ref resolver uses git cat-file --batch-check, but this doesn't let us distinguish between branches (like "master") and commits (like "HEAD^^^").

Since we now filter the results of diffusion.resolveref by TYPE_BRANCH, we may fail to resolve branch refs ("master" -> "origin/master"), particularly for old non-bare repositories (which will always miss the cache, given how the code works today).

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Diffusion.
epriestley added a subscriber: epriestley.
epriestley added a revision: Restricted Differential Revision.Apr 29 2015, 3:17 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Apr 29 2015, 8:21 PM
epriestley added a commit: Restricted Diffusion Commit.