Page MenuHomePhabricator

Old done inlines
Closed, DuplicatePublic

Description

Showing comments for older diff versions is very cool. But if it is marked as 'done' why to show it? Maybe, at least show only header of it and open/hiding full comment on click?

Event Timeline

mkhrystunov raised the priority of this task from to Needs Triage.
mkhrystunov updated the task description. (Show Details)
mkhrystunov added a project: PHUI.
mkhrystunov added a subscriber: mkhrystunov.

One reason to show old inlines even when they are marked "Done" is that the reviewer who added the inline may want to verify that it is actually done when they look at the updated diff.

So maybe it should be shown as a header with a possibility to show full comment? We sometimes encountered situation that there are too many comments in same place, but only few of them are relevant

I'm going to merge this into T7447, which has some ongoing discussion about this feature.

(Including discussion of the possibility of summarizing, hiding, etc., older inlines.)