Page MenuHomePhabricator

Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work)
Closed, ResolvedPublic

Description

Something seems to be wrong starting with 7f43cde.

Trying to view newly created repositories leads to a disheartening DiffusionRefNotFoundException:

Screen Shot 2015-04-28 at 4.29.23 PM.png (1×2 px, 460 KB)

Trying to view a fresh mercurial repository ends with a CommandException with the following error:

Command failed with error #255!
COMMAND
hg log --template='{node}' --rev ''\''default'\'''

STDOUT
(empty)

STDERR
not trusting file /var/repo/this/HG/.hg/hgrc from untrusted user daemon-user, group daemon-user
not trusting file /var/repo/this/HG/.hg/hgrc from untrusted user daemon-user, group daemon-user
abort: unknown revision 'default'!

Existing repositories seem to be working fine, however I've noticed that if I force DiffusionRequest to skip the cache by replacing the line

$cached_results = $cached_query->execute();

with something like

$cached_results = array();

it will fail when trying to view the repository with the same errors as mentioned earlier. I'm hazy on how the cache works here, so there's a chance I haven't really debugged anything here.

Reverting back to 55ff197 makes everything work as usual, at least on the outside.

I'll be just around the corner if you need more info.

Event Timeline

maligree raised the priority of this task from to Needs Triage.
maligree updated the task description. (Show Details)
maligree added a project: Diffusion.
maligree updated the task description. (Show Details)
maligree added a subscriber: maligree.
epriestley triaged this task as Normal priority.

After updating yesterday to check out changes with T7100, we started seeing this issue when creating a new hosted mercurial repository. After updating for this task, the hosted repository no longer shows this error.