Page MenuHomePhabricator
Feed Advanced Search

Jun 5 2020

epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I am dropping support for versions of Mercurial older than 2.1.1 (released in May, 2012). This is the first version that: (a) has phases and (b) does not exit 1 when hg pull succeeds but fetches no changes.

Jun 5 2020, 2:15 PM · Mercurial, Arcanist
epriestley moved T13380: `git push` fatals when CWD does not exist from Backlog to arc land on the Arcanist board.
Jun 5 2020, 6:16 AM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

After changes connected to T13546, the git workflow now looks like this:

Jun 5 2020, 6:15 AM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 5 2020, 12:52 AM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 5 2020, 12:49 AM · Arcanist

Jun 4 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 4 2020, 5:53 PM · Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 5:51 PM · Guides, Arcanist
epriestley updated the task description for T13546: Modernize the "arc land" workflow.
Jun 4 2020, 5:49 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 4 2020, 4:53 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 4 2020, 4:51 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 4 2020, 4:49 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 4 2020, 4:48 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: Unknown Object (Differential Revision).
Jun 4 2020, 4:45 PM · Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 4:37 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 3:39 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 12:49 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 12:48 PM · Guides, Arcanist
scp awarded T2493: Support `arc land` in stacked commits a Love token.
Jun 4 2020, 10:50 AM · Restricted Project, Arcanist
epriestley moved T2920: Modularize the pipeline for producing final commit messages from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:17 AM · Arcanist
epriestley moved T9457: arc diff crashes when trying to stash submodule diffs from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:14 AM · Arcanist
epriestley moved T9898: `git branch --contains X` has cost in the realm of O(commits * branches) from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:13 AM · Restricted Project, Restricted Project, Arcanist
epriestley moved T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:10 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley moved T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:09 AM · Mercurial, Arcanist
epriestley moved T13532: Git commit hooks may mutate commits in "arc land", discarding "Differential Revision: ..." from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:08 AM · Arcanist
epriestley moved T13547: Upgrading: Mid 2020 Changes to "arc land" from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:08 AM · Guides, Arcanist
epriestley closed T5852: arc should ignore abandoned revisions when landing as Wontfix.

After near-future changes connected to T13546 this is ripe for implementation, but I don't think it has come up again in ~6 years so I'm not sure it's actually worth improving. arc has also warned about abandoned revisions for a long time, which may have mooted this. My expectation is that the modern behavior is clear and the remedy is simple (arc land --revision 123) but I'm open to reconsidering this once the changes connected to T13546 have stabilized, if it's still an issue then.

Jun 4 2020, 3:05 AM · Restricted Project, Arcanist
epriestley closed T11535: Make it possible for arc land to disable upstream branch tracking as Wontfix.

After near-future changes connected to T13546, arc.land.onto (previously arc.land.onto.default) has higher priority than upstream branches.

Jun 4 2020, 3:01 AM · Arcanist, Restricted Project
epriestley closed T11535: Make it possible for arc land to disable upstream branch tracking, a subtask of T11362: Arcanist tries to land onto identical remote branch instead of 'master', as Wontfix.
Jun 4 2020, 3:01 AM · Arcanist, Bug Report
epriestley closed T2493: Support `arc land` in stacked commits, a subtask of T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`, as Resolved.
Jun 4 2020, 2:57 AM · Prioritized, Restricted Project, Arcanist
epriestley closed T2493: Support `arc land` in stacked commits as Resolved.

Changes connected to T13546 address this, see T13547 for a preview of new behavior.

Jun 4 2020, 2:57 AM · Restricted Project, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 2:51 AM · Guides, Arcanist

Jun 3 2020

epriestley updated the task description for T13546: Modernize the "arc land" workflow.
Jun 3 2020, 7:30 PM · Arcanist

Jun 2 2020

epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 2 2020, 9:00 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 2 2020, 7:11 PM · Guides, Arcanist
epriestley triaged T13547: Upgrading: Mid 2020 Changes to "arc land" as Normal priority.
Jun 2 2020, 7:10 PM · Guides, Arcanist
epriestley moved T13546: Modernize the "arc land" workflow from Backlog to arc land on the Arcanist board.
Jun 2 2020, 5:13 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

See PHI1013, which would like a way to specify that the branch you want to merge into might be different from the name of the branch you want to push into the remote.

Jun 2 2020, 5:10 PM · Arcanist
epriestley added a comment to T12876: Improve initial arc land experience when destination repo is empty.

I think the general shape of this is:

Jun 2 2020, 4:58 PM · Arcanist

May 31 2020

epriestley updated the task description for T13546: Modernize the "arc land" workflow.
May 31 2020, 12:04 AM · Arcanist

May 30 2020

epriestley triaged T13546: Modernize the "arc land" workflow as Normal priority.
May 30 2020, 11:58 PM · Arcanist
epriestley requested review of D21305: Merge the "--raw" and "--raw-command" flags to "arc diff" into "--raw <path>".
May 30 2020, 11:16 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21305: Merge the "--raw" and "--raw-command" flags to "arc diff" into "--raw <path>".
May 30 2020, 11:16 PM · Arcanist
epriestley updated the task description for T13545: Upgrading: Mid 2020 Changes to "arc diff".
May 30 2020, 11:11 PM · Arcanist, Guides
epriestley triaged T13545: Upgrading: Mid 2020 Changes to "arc diff" as Low priority.
May 30 2020, 11:05 PM · Arcanist, Guides
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 10:55 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 10:49 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 10:47 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 10:42 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 10:30 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 10:26 PM · Arcanist
epriestley added a comment to T13544: Modernize the "arc diff" workflow.

arc diff has a lot of code to deal with handling untracked or uncommitted changes in the working copy. The major motivations for arc caring about this are:

May 30 2020, 10:23 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 9:54 PM · Arcanist
epriestley added a subtask for T13490: Upgrade all "classic" Arcanist workflows to Toolsets: T13544: Modernize the "arc diff" workflow.
May 30 2020, 9:47 PM · Arcanist
epriestley added a parent task for T13544: Modernize the "arc diff" workflow: T13490: Upgrade all "classic" Arcanist workflows to Toolsets.
May 30 2020, 9:47 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 9:47 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: Unknown Object (Differential Revision).
May 30 2020, 9:34 PM · Arcanist
epriestley added a comment to T13544: Modernize the "arc diff" workflow.

I'm not sure --use-commit-message has any real use cases.

May 30 2020, 9:28 PM · Arcanist
epriestley triaged T13544: Modernize the "arc diff" workflow as Normal priority.
May 30 2020, 9:26 PM · Arcanist
epriestley edited the content of Changelog.
May 30 2020, 12:00 PM
epriestley created an object: 2020 Week 21 (Very Late May).
May 30 2020, 11:56 AM

May 28 2020

epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.

Piledriver would also benefit from having some functional equivalent of destroying an Almanac resource. This can be implemented as a piledriver.destroyed property, but a formal disabled state would be cleaner. PHI1331 is vaguely related.

May 28 2020, 5:53 PM · Phacility
epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.
  • When Piledriver destroys a resource pile, it's helpful if it can read the entire authoritative state from sources by using only a pile ID.
    • EC2 can do this with "DescribeTags".
    • Almanac currently can not. Almanac types should support searching by property value.
      • This could be directly on almanac.*.search.
      • Or this could be generic, via T12799.
May 28 2020, 3:23 PM · Phacility

May 27 2020

epriestley closed T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation as Resolved.

Problem 2: Arcanist does not check that messages emitted by linters have a valid line number.

May 27 2020, 7:40 PM · Arcanist
epriestley added a revision to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation: Unknown Object (Differential Revision).
May 27 2020, 7:36 PM · Arcanist
epriestley added a comment to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation.

Problem 3: The cpplint unit tests fail, and the failure appears to be pre-existing and significant.

May 27 2020, 6:56 PM · Arcanist
epriestley added a comment to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation.
  • Problem 4: If a file ends in non-newline whitespace, the text linter may raise a message which removes that line. The renderer then tries to highlight part of it, which fatals.
May 27 2020, 6:28 PM · Arcanist
epriestley added a revision to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation: Unknown Object (Differential Revision).
May 27 2020, 6:26 PM · Arcanist
epriestley added a comment to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation.

Here's a simplified reproduction case for "Problem 1":

May 27 2020, 6:07 PM · Arcanist
epriestley added a comment to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation.
  • Problem 1: cpplint may raise messages at line 0, but arcanist can not render these messages after the severity of runtime-level errors was increased in D21044.
May 27 2020, 6:04 PM · Arcanist
epriestley added a revision to T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation: Unknown Object (Differential Revision).
May 27 2020, 5:58 PM · Arcanist
epriestley triaged T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation as Low priority.
May 27 2020, 5:55 PM · Arcanist

May 26 2020

epriestley closed T13467: Expand the "ddata003" volume as Resolved.

Effectively mooted by T13542.

May 26 2020, 8:32 PM · Phacility
epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.

I've written some Terraform-class tooling which can likely automate all the actual hardware allocations. This needs some more work, but I believe the tricky stuff (mostly: representing resources and allowing templating to reference resources which haven't been built yet) is at least working.

May 26 2020, 8:31 PM · Phacility
epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.

Subnet/NAT issues in T12816.

May 26 2020, 8:18 PM · Phacility
epriestley closed T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction as Resolved.

Continued in T13542.

May 26 2020, 8:13 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T12801: Simplify Almanac services in the Phacility production cluster as Resolved.

The major offender here (services per instance) was fixed by updating caching, and I destroyed all the old services. This is perhaps spiritually continued in T13542.

May 26 2020, 8:11 PM · Almanac, Ops, Phacility
epriestley updated the task description for T13542: Rebalance Phacility instances into a private subnet.
May 26 2020, 8:10 PM · Phacility
epriestley closed T12999: Replace cluster magnetic volumes with SSD volumes as Resolved.

Continued in T13542.

May 26 2020, 8:10 PM · Phacility, Ops
epriestley closed T12856: Evaluate various "infrastructure-as-code" products as Resolved.

Continued in T13542. I wrote a Terraform/CloudFormation-style service in PHP over the last couple of days.

May 26 2020, 8:07 PM · Ops, Phacility
epriestley closed T12816: Setup NAT for the primary Phacility cluster as Resolved.

Continued in T13542.

May 26 2020, 8:03 PM · Ops, Phacility
epriestley updated the task description for T13542: Rebalance Phacility instances into a private subnet.
May 26 2020, 8:03 PM · Phacility
epriestley triaged T13542: Rebalance Phacility instances into a private subnet as Low priority.
May 26 2020, 8:02 PM · Phacility

May 25 2020

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Committer identities ... they're currently stored in a JSON blob so there's no efficient way to query them.

May 25 2020, 2:26 PM · Customer Impact, Diffusion (v3)
tycho.tatitscheff awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Mountain of Wealth token.
May 25 2020, 7:58 AM · Differential, Quick Look
claassen awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Like token.
May 25 2020, 7:55 AM · Differential, Quick Look

May 24 2020

PXke awarded T13540: "Dark Mode" UI issues a Love token.
May 24 2020, 3:52 PM · Design
PXke awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
May 24 2020, 3:31 PM · Differential, Quick Look
PXke awarded Blog Post: Quick Look: Inline Comments on Character Ranges a Love token.
May 24 2020, 3:30 PM · Quick Look, Differential
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Is there a way to find which object(s) an (unmapped) identity was discovered on?

May 24 2020, 2:16 PM · Customer Impact, Diffusion (v3)

May 23 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 23 2020, 3:18 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In previews, suggestions aren't highlighted properly (likely just missing CSS).
May 23 2020, 3:15 PM · Inline Comments, Diffusion, Differential
avivey awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Manufacturing Defect? token.
May 23 2020, 6:19 AM · Differential, Quick Look
mcorteel awarded Blog Post: Quick Look: Inline Comments on Character Ranges a Love token.
May 23 2020, 5:47 AM · Quick Look, Differential
hskiba awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Mountain of Wealth token.
May 23 2020, 2:04 AM · Differential, Quick Look

May 22 2020

cspeckmim awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
May 22 2020, 9:53 PM · Differential, Quick Look
epriestley edited the content of Changelog.
May 22 2020, 9:44 PM
epriestley created an object: 2020 Week 20 (Late May).
May 22 2020, 9:43 PM
epriestley created Blog Post: Quick Look: Suggesting Edits with Inline Comments.
May 22 2020, 9:41 PM · Differential, Quick Look
epriestley added a revision to T13541: Very large repositories may fail initial fetches after 15 minutes: Unknown Object (Differential Revision).
May 22 2020, 12:45 PM · Diffusion
epriestley triaged T13541: Very large repositories may fail initial fetches after 15 minutes as Low priority.
May 22 2020, 12:02 PM · Diffusion