Since many of these options probably don't have "right answers", I'm trying this reasonable-seeming variation on some repositories which seem like they'll benefit from a repack:

• j, etc., can incorrectly select blocks inside a diff inside a suggestion.

See PHI1748. I ran a query against a subset of instances to determine how widespread usage of "Dark Mode" is, to help inform a decision to either implement the mode properly (see T12311) or remove the mode. The query was of this form:

I think (?) this was pretty much resolved by the last round of changes. See T13291 for some followups.

I made a change to drop unchanged context from suggestion views, but I don't particularly like it. It changed this:

• Inline comments with suggestions don't "know" that they're empty when the suggestion is the same as the context text.
  • Create an inline. Suggest edit. Don't change anything. Save. You get a blank inline with no suggestion and no content, when this inline would normally delete itself.

The inline comment context menu does not apply the correct cursor ("pointer").

I still have a lot of inline style attributes to clean up and then I'm sure there will be a long tail of weird edge cases, but this is getting pretty close:

• This isn't necessarily terribly useful in practice, but a UI hint about whether or not we've actually saved a draft would make debugging slightly easier.

Remaining work here is:

• The inline comment context menu does not apply the correct cursor ("pointer").

These particular issues blame to D21027, which began extracting null in all cases where a field has no value for a given commit. This is not entirely faithful, as it can not distinguish between "field absent" and "field present, but with an empty value". At least for author, these are distinct states that can be independently constructed using git hash-object:

From PHI1739, --allow-empty-message supports constructing these commits more easily (via a normal git commit rather than git hash-object).

Second issue:

First issue:

Alas, you can't actually push the perfect commit:

The actual query we use to inspect table information is:

See T13537 for a subtle issue where digestWithNamedKey() keys were cached in APCu on the web tier. Importing instance data may require restarting the web tier until the import process can either dump these caches or version them (versioning may be easier).

So I'm going to turn web off and on again and see if that fixes things; my expectation is that it will.

The specific issue I'm trying to debug is fairly bizarre.

Thanks! I figured out how to make somewhat-reasonable GIFs with ffmpeg.

• The line-triggered reticle should be updated to use the hover-reticle cell style.

• In Jupyter notebooks (and, theoretically, other rich content) we find an inner <td /> before finding the content <td />, preventing context menus from working.

• In Firefox, multi-line selections don't generate a context menu properly.
• Clicking the "New Inline Comment" action disables the oncopy behavior onmousedown but doesn't take the action until onclick. This creates a flash of selected content which spans both sides of the change and looks odd.
• Context selection doesn't activate in unified mode, maybe because data-copy stuff is being used to identify content cells.

• When you create an inline, do nothing, then click "Cancel", inlines briefly count themselves in the paths panel.

I have a patch which allows you to edit published inlines. It "works", but it causes a ton of weird side effects when you perform an edit.

Inline stuff:

Probably kicking this, but:

See PHI1703. The document engine the original comment was made on should be persisted, so email can do something better than dumping unrelated lines of text into the body.