Page MenuHomePhabricator
Feed Advanced Search

Feb 28 2019

n3v3rf411 awarded T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes a Cup of Joe token.
Feb 28 2019, 4:38 AM · Custom Fields, Maniphest

Feb 26 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 26 2019, 5:45 PM · Plans, Harbormaster
epriestley added a revision to T11415: Would like people who can't edit Harbormaster plans to be able to run them: Unknown Object (Differential Revision).
Feb 26 2019, 5:45 PM · Restricted Project, Harbormaster, Feature Request
20after4 awarded T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes a Mountain of Wealth token.
Feb 26 2019, 3:58 PM · Custom Fields, Maniphest
20after4 awarded T13255: transaction.search should accept user PHIDs as constraints a Pterodactyl token.
Feb 26 2019, 3:55 PM · Conduit, Transactions
epriestley added a parent task for T11415: Would like people who can't edit Harbormaster plans to be able to run them: T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 3:27 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a subtask for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): T11415: Would like people who can't edit Harbormaster plans to be able to run them.
Feb 26 2019, 3:27 PM · Plans, Harbormaster
epriestley updated the task description for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 3:26 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 26 2019, 1:49 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 26 2019, 1:24 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 26 2019, 1:17 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Feb 26 2019, 12:48 PM · Plans, Harbormaster
epriestley updated the task description for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 12:48 PM · Plans, Harbormaster
epriestley triaged T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Normal priority.
Feb 26 2019, 12:41 PM · Plans, Harbormaster
epriestley triaged T13257: Plans: Unbeta New Harbormaster Log UI as Normal priority.
Feb 26 2019, 12:36 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 26 2019, 12:35 PM · Plans, Harbormaster
epriestley created U45 Adding New Classes.
Feb 26 2019, 2:55 AM

Feb 25 2019

epriestley closed T7773: Allow code reviews across multiple repos, a subtask of T9287: Working with many repositories, as Wontfix.
Feb 25 2019, 9:45 PM · Restricted Project, Restricted Project, Diffusion
epriestley closed T7773: Allow code reviews across multiple repos as Wontfix.

I'm going to close this as non-actionable since it doesn't clearly describe a use case, there's no current customer interest, and it's not clear what problems we'd like to solve that aren't already solved by a stronger "Depends On". The "Depends On" relationship has also become stronger and better integrated since this was originally filed, and it's possible it addresses some or all of the original use cases.

Feb 25 2019, 9:45 PM · Restricted Project, Differential
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 25 2019, 9:29 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 25 2019, 9:28 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 25 2019, 8:58 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 25 2019, 8:55 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley closed T10853: Make `setCWD('/does/not/exist')` safer on ExecFuture as Resolved by committing Restricted Diffusion Commit.
Feb 25 2019, 8:14 PM · Infrastructure
epriestley updated the task description for T13230: Native Applications.
Feb 25 2019, 8:03 PM · Phacility
epriestley closed T13255: transaction.search should accept user PHIDs as constraints as Resolved.
  • D20208 adds an authorPHIDs constraint.
  • D20209 provides details for transactions which add or remove projects. See above for format and rationale, or just query something and see what pops out.
  • D20211 makes the documentation less bare-bones.
Feb 25 2019, 7:08 PM · Conduit, Transactions
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: Unknown Object (Differential Revision).
Feb 25 2019, 3:26 PM · Conduit, Transactions
epriestley added a comment to T13068: Refinements for "Mute Notifications".

A very mild point in favor of this feature is that we haven't seen any negative feedback or confusion, although I think you might be the first user to say they actually like/use it.

Feb 25 2019, 2:31 PM · Notifications, Mail
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

I ran a query against a subset of instances to determine if "Mute Notifications" sees any usage whatsover (see T13068):

Feb 25 2019, 2:29 PM · Phacility
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: Unknown Object (Differential Revision).
Feb 25 2019, 1:35 PM · Conduit, Transactions
epriestley added a comment to T13255: transaction.search should accept user PHIDs as constraints.

Currently, project tag changes and subscriber changes don't expose data in "transaction.search" because there's no "obviously correct" way to represent these changes in a future-proof way.

Feb 25 2019, 1:27 PM · Conduit, Transactions
epriestley added a comment to T13255: transaction.search should accept user PHIDs as constraints.

To my surprise, it also seems the method does not output any project tag changes that happened on a task?

Feb 25 2019, 1:24 PM · Conduit, Transactions
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: Unknown Object (Differential Revision).
Feb 25 2019, 1:02 PM · Conduit, Transactions
epriestley added a parent task for T4752: Daemons may not have permission to remove files from local disk storage engine: T13256: Update storage engines in Files to a modern multi-service configuration.
Feb 25 2019, 12:55 PM · Files
epriestley added a subtask for T13256: Update storage engines in Files to a modern multi-service configuration: T4752: Daemons may not have permission to remove files from local disk storage engine.
Feb 25 2019, 12:55 PM · Files

Feb 23 2019

epriestley closed T9169: Downloading Attachment Extremely Slow as Wontfix.

We no longer offer support for this kind of problem (that technically has reproduction steps, but is sufficiently involved to reproduce that no one has time to follow them, e.g. build a new server from scratch with assorted specific software versions).

Feb 23 2019, 3:37 PM · Bug Report (Needs Information), Files
epriestley triaged T13256: Update storage engines in Files to a modern multi-service configuration as Low priority.
Feb 23 2019, 3:26 PM · Files
epriestley edited the content of Changelog.
Feb 23 2019, 2:19 PM
epriestley created 2019 Week 8 (Late February).
Feb 23 2019, 2:18 PM
epriestley closed T13254: "Login with Facebook" may fail CSP after redirect to "m.facebook.com" as Resolved by committing Restricted Diffusion Commit.
Feb 23 2019, 1:25 PM · Auth
epriestley added a comment to T13255: transaction.search should accept user PHIDs as constraints.

The phids constraints matches transactions with specific PHIDs (PHID-XACT-...). Usually, you'll have a list of transaction PHIDs when you're responding to a webhook callback, so the phids constraint is most useful for webhooks.

Feb 23 2019, 1:15 PM · Conduit, Transactions
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 23 2019, 12:59 AM · Plans
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 - 8 Bonus Content to 2019 Week 7 - 9 Bonus Content.
Feb 23 2019, 12:58 AM · Plans
epriestley added a revision to T13254: "Login with Facebook" may fail CSP after redirect to "m.facebook.com": Unknown Object (Differential Revision).
Feb 23 2019, 12:58 AM · Auth

Feb 22 2019

epriestley added a revision to T10853: Make `setCWD('/does/not/exist')` safer on ExecFuture: Unknown Object (Differential Revision).
Feb 22 2019, 11:40 PM · Infrastructure
epriestley added a revision to T13251: Upgrading: PhutilURI Query Parameter Changes: Unknown Object (Differential Revision).
Feb 22 2019, 10:55 PM · Installing & Upgrading, Guides, Infrastructure

Feb 21 2019

epriestley triaged T13254: "Login with Facebook" may fail CSP after redirect to "m.facebook.com" as Low priority.
Feb 21 2019, 5:22 PM · Auth
leoluk awarded T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes a Like token.
Feb 21 2019, 1:53 PM · Custom Fields, Maniphest

Feb 20 2019

epriestley closed T12746: Add support for PHUIPinboardItemView to timeline/transactions as Wontfix.

Probably a good idea, but not worth keeping a task around for.

Feb 20 2019, 11:33 PM · Maniphest, Macros, Transactions
epriestley closed T11824: Use Pinboard view in Maniphest Mocks tab as Wontfix.

This is probably a natural feature if we iterate here, but not worth keeping a task around for.

Feb 20 2019, 11:32 PM · Pholio, Maniphest
epriestley edited projects for T10571: Default quote action breaks text between lists, added: Remarkup; removed Maniphest, Bug Report.
Feb 20 2019, 11:31 PM · Remarkup, Wikimedia
epriestley closed T10567: Ability to know who can do what in Maniphest EditEngine as Wontfix.
Feb 20 2019, 11:30 PM · ApplicationEditor, Maniphest, Feature Request
epriestley edited projects for T7443: Include full link to Maniphest tasks in commit messages, added: Diffusion; removed Maniphest.
Feb 20 2019, 11:29 PM · Diffusion, Arcanist
epriestley moved T6896: Add group by 'author' to maniphest search results from Backlog to vNext on the Maniphest board.
Feb 20 2019, 11:29 PM · Maniphest
epriestley moved T5679: Search daemon fails when document title >255 chars from Backlog to vNext on the Maniphest board.
Feb 20 2019, 11:28 PM · Maniphest
epriestley closed T4548: Support "Mylyn" Eclipse plugin as Wontfix.

We have no customer interest in this and no current plans to pursue it.

Feb 20 2019, 11:27 PM · Feature Request, Maniphest
epriestley moved T4316: Allow a comment to be added on the Maniphest edit interface from vNext to Far Future on the Maniphest board.
Feb 20 2019, 11:25 PM · Maniphest
epriestley added a comment to T13253: Plans: Daemon Status Reporting.

I'm looking at these storage/backend changes:

Feb 20 2019, 6:05 PM · Plans, Daemons
epriestley added a revision to T13253: Plans: Daemon Status Reporting: Unknown Object (Differential Revision).
Feb 20 2019, 5:34 PM · Plans, Daemons
epriestley closed T8343: Copied code detection takes >30s on 48MB diff as Resolved.

Presuming resolved by D19748 since we don't have an actual reproduction case.

Feb 20 2019, 2:52 PM · Differential
epriestley closed T11714: Unified diffs don't allow selecting text in inline comments as Resolved.

D20196 removes this code.

Feb 20 2019, 2:50 PM · Differential, Bug Report
epriestley added a comment to T7878: strange "moved from" signal in [Phriction] diff.

I think it had some white-space removed from its end.

Feb 20 2019, 2:15 PM · Differential
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 20 2019, 1:15 PM · Differential, Plans
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: Unknown Object (Differential Revision).
Feb 20 2019, 1:10 PM · Differential, Plans
epriestley added a comment to T2495: Improve whitespace expansion of tab literals.

After D20194, expansion of tabs now uses the correct rule (expand tabs to the next tabstop) instead of the old rule (hard-coded replacement with a fixed number of spaces).

Feb 20 2019, 5:44 AM · Restricted Project, FreeBSD, Differential, Diffusion
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 20 2019, 5:04 AM · Differential, Plans
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Unknown Object (Differential Revision).
Feb 20 2019, 4:58 AM · Differential
epriestley closed T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery, a subtask of T13161: Plans: Improve Differential diff display behaviors, as Resolved.
Feb 20 2019, 4:48 AM · Differential, Plans
epriestley closed T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery as Resolved.

There are probably still a few remaining kinks to work out here, but I believe this is substantially resolved:

Feb 20 2019, 4:48 AM · Differential

Feb 19 2019

epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: Unknown Object (Differential Revision).
Feb 19 2019, 11:00 PM · Differential, Plans
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.
  • The "<<" and ">>" indicators are rendering in places where indentation has changed but the entire line is also different. This is not intended.
  • The ScopeEngine can raise an exception on diffs with partial context. We should probably just skip this feature if we're missing context.
  • The indent depth indicators are probably generally too bright / high-vis.
  • There's no color blind scheme for the indicators.
  • The indentation indicators in one-up mode aren't great (?)
Feb 19 2019, 10:42 PM · Differential, Plans
epriestley closed T6791: Side-by-side diff for source code is noisier than other tools as Resolved by committing Restricted Diffusion Commit.
Feb 19 2019, 9:12 PM · Diffusion, Differential
epriestley closed T3498: Allow ignore whitespace in Audit/Diffusion diffs as Resolved by committing Restricted Diffusion Commit.
Feb 19 2019, 9:09 PM · Diffusion
epriestley added a comment to T13158: View query results as annotatable "spreadsheets".

6v63r3z96jh21.gif (834×502 px, 131 KB)

Feb 19 2019, 7:34 PM · Design
epriestley closed T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue as Resolved by committing Restricted Diffusion Commit.
Feb 19 2019, 7:17 PM · Customer Impact, Daemons, Search, Diffusion

Feb 17 2019

epriestley added a revision to T2495: Improve whitespace expansion of tab literals: Unknown Object (Differential Revision).
Feb 17 2019, 10:15 PM · Restricted Project, FreeBSD, Diffusion, Differential
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Unknown Object (Differential Revision).
Feb 17 2019, 10:15 PM · Differential
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Unknown Object (Differential Revision).
Feb 17 2019, 5:18 PM · Differential
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Unknown Object (Differential Revision).
Feb 17 2019, 4:44 PM · Differential
epriestley added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

I'm probably not going to fix this since it's pretty minor and moderately complicated to fix, but this interaction is not ideal:

Feb 17 2019, 4:08 PM · Differential
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: Unknown Object (Differential Revision).
Feb 17 2019, 3:38 PM · Differential, Plans
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Unknown Object (Differential Revision).
Feb 17 2019, 3:38 PM · Differential
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Unknown Object (Differential Revision).
Feb 17 2019, 2:36 PM · Differential
epriestley added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

In Firefox, selecting a range which crosses an inline comment currently drops the line after the comment. Here, return arra does not copy:

Feb 17 2019, 1:47 PM · Differential
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Unknown Object (Differential Revision).
Feb 17 2019, 12:13 PM · Differential
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: Unknown Object (Differential Revision).
Feb 17 2019, 12:13 PM · Differential, Plans

Feb 16 2019

epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: Unknown Object (Differential Revision).
Feb 16 2019, 7:37 PM · Differential, Plans
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Unknown Object (Differential Revision).
Feb 16 2019, 7:37 PM · Differential
epriestley added a subtask for T13161: Plans: Improve Differential diff display behaviors: T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.
Feb 16 2019, 5:51 PM · Differential, Plans
epriestley added a parent task for T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: T13161: Plans: Improve Differential diff display behaviors.
Feb 16 2019, 5:51 PM · Differential
cspeckmim awarded T13161: Plans: Improve Differential diff display behaviors a Party Time token.
Feb 16 2019, 5:02 PM · Differential, Plans
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 16 2019, 4:42 PM · Differential, Plans
epriestley added a revision to T6791: Side-by-side diff for source code is noisier than other tools: Restricted Differential Revision.
Feb 16 2019, 4:31 PM · Diffusion, Differential
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: Restricted Differential Revision.
Feb 16 2019, 4:31 PM · Differential, Plans
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: Unknown Object (Differential Revision).
Feb 16 2019, 4:12 PM · Differential, Plans
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.

Note that T6791 has an example of a change where removing the whitespace options is going to cause a behavioral regression. Here's an example:

Feb 16 2019, 2:43 PM · Differential, Plans
epriestley closed T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations as Wontfix.

This report is generally unclear / hard to reproduce / unusual so I'm not sure how to move forward. It's likely mooted by D20181.

Feb 16 2019, 2:20 PM · Restricted Project, Bug Report (Needs Information), Differential
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.

See PHI701. This behavior is not ideal:

Feb 16 2019, 2:18 PM · Differential, Plans
epriestley added a revision to T3498: Allow ignore whitespace in Audit/Diffusion diffs: Restricted Differential Revision.
Feb 16 2019, 2:16 PM · Diffusion
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: Restricted Differential Revision.
Feb 16 2019, 2:16 PM · Differential, Plans