Page MenuHomePhabricator
Feed Advanced Search

Dec 13 2016

epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 13 2016, 11:29 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 13 2016, 11:10 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T7899: DifferentialDiff->description is "text255?" but should be "text" as Resolved by committing Restricted Diffusion Commit.
Dec 13 2016, 10:28 PM · Differential, Mercurial, Arcanist
epriestley added a comment to T12013: Enabling zlib.output_compression results in wrong Content-Length.

I think this is fixed now -- let us know if you're still seeing issues. Thanks for the very thorough report!

Dec 13 2016, 10:27 PM · Bug Report
epriestley closed T12013: Enabling zlib.output_compression results in wrong Content-Length as Resolved by committing Restricted Diffusion Commit.
Dec 13 2016, 10:25 PM · Bug Report
siepkes awarded T9456: Evaluate upstream support for third-party build systems a Mountain of Wealth token.
Dec 13 2016, 10:22 PM · Restricted Project, Harbormaster
epriestley added a comment to T12013: Enabling zlib.output_compression results in wrong Content-Length.

I wasn't able to reproduce any hangs or bad behavior from curl locally, but I think D17045 should cause us to select either compression or Content-Length, which is a reasonable thing to expect us to do.

Dec 13 2016, 10:10 PM · Bug Report
epriestley added a revision to T12013: Enabling zlib.output_compression results in wrong Content-Length: Unknown Object (Differential Revision).
Dec 13 2016, 10:07 PM · Bug Report
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 13 2016, 9:22 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to T12011: Support builds with Travis CI.

You could also ask Travis for a build.run sort of API. If you're a paying customer of theirs, it might be easier for them to prioritize this request than it is for us to prioritize Travis support. With such an API, there's a fairly straightforward path to Phabricator upstream support.

Dec 13 2016, 9:01 PM · Harbormaster, Feature Request
epriestley added a subtask for T9456: Evaluate upstream support for third-party build systems: T12011: Support builds with Travis CI.
Dec 13 2016, 8:47 PM · Restricted Project, Harbormaster
epriestley added a parent task for T12011: Support builds with Travis CI: T9456: Evaluate upstream support for third-party build systems.
Dec 13 2016, 8:47 PM · Harbormaster, Feature Request
epriestley renamed T12011: Support builds with Travis CI from There is no way to read diffproperty using Conduit to Support builds with Travis CI.
Dec 13 2016, 8:47 PM · Harbormaster, Feature Request
epriestley added a comment to T12011: Support builds with Travis CI.

FWIW, the API seems not intuitive for me: why does the user is able to set arbitrary properties via Conduit, if there is no way to get them back? Is exposing the API actually a hack, to achieve other goals?

Dec 13 2016, 8:46 PM · Harbormaster, Feature Request
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 13 2016, 8:38 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12012: Diffusion doesn't handle non-bare hosted git repos as Invalid.

Oh, I think the issue is this:

Dec 13 2016, 7:38 PM · Git, Diffusion, Bug Report
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

I also can't reproduce this:

Dec 13 2016, 7:33 PM · Git, Diffusion, Bug Report
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

Why do you consider this to be a bug, then?

Dec 13 2016, 7:23 PM · Git, Diffusion, Bug Report
epriestley added a comment to T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them.

Do you consider this ticket just "make arc patch restore all local commits", or something more?

Dec 13 2016, 7:21 PM · Restricted Project, Arcanist
epriestley renamed T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them from Allow arc diff --create" to create a diff/revision out of each local commit to When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them.
Dec 13 2016, 6:46 PM · Restricted Project, Arcanist
epriestley added a comment to T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them.

Oh, that's actually a different task, I don't currently plan to implement that. Let me me rename this to be more clear...

Dec 13 2016, 6:44 PM · Restricted Project, Arcanist
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

Do we tell you to do this in the documentation anywhere?

Dec 13 2016, 6:36 PM · Git, Diffusion, Bug Report
epriestley added a revision to T10967: Move Differential reviewers back to a dedicated database storage table: Unknown Object (Differential Revision).
Dec 13 2016, 6:17 PM · Restricted Project, Infrastructure, Differential
epriestley added a revision to T8475: Clean up remnants of old Differential hunk storage: Unknown Object (Differential Revision).
Dec 13 2016, 6:09 PM · Infrastructure, Restricted Project, Differential
epriestley added a revision to T8475: Clean up remnants of old Differential hunk storage: Unknown Object (Differential Revision).
Dec 13 2016, 6:06 PM · Infrastructure, Restricted Project, Differential
epriestley updated the task description for T8623: Upgrading: Differential Hunk Migration.
Dec 13 2016, 5:44 PM · Installing & Upgrading, Differential, Guides
epriestley closed T4045: Store diffs as binary, not UTF-8, a subtask of T1191: Comments are truncated at first non-base-plane character, as Resolved.
Dec 13 2016, 5:44 PM · Wikimedia, Support Impact, High Support Impact, Differential
epriestley closed T4045: Store diffs as binary, not UTF-8 as Resolved.

This is now better tracked in followups:

Dec 13 2016, 5:44 PM · Restricted Project, Support Impact, Differential
epriestley closed T4045: Store diffs as binary, not UTF-8, a subtask of T5229: Fixing up invalid encoding confuses archanists utf8-check, as Resolved.
Dec 13 2016, 5:44 PM · Bug Report, Arcanist
epriestley closed T4045: Store diffs as binary, not UTF-8, a subtask of T5179: Unearth Differential rendering technical debt, as Resolved.
Dec 13 2016, 5:44 PM · Differential
epriestley edited projects for T12011: Support builds with Travis CI, added: Feature Request (Needs Information); removed Bug Report.
Dec 13 2016, 5:37 PM · Harbormaster, Feature Request
epriestley added a comment to T12011: Support builds with Travis CI.

This isn't a bug. Diff properties are not intended to be an arbitrary key-value datastore for API consumers.

Dec 13 2016, 5:36 PM · Harbormaster, Feature Request
epriestley added a revision to T7899: DifferentialDiff->description is "text255?" but should be "text": Unknown Object (Differential Revision).
Dec 13 2016, 5:31 PM · Differential, Mercurial, Arcanist
epriestley added a comment to T7899: DifferentialDiff->description is "text255?" but should be "text".

This field is only populated when you update a revision, and always contains the first line of the update message, which is also posted as a comment.

Dec 13 2016, 5:27 PM · Differential, Mercurial, Arcanist
chad awarded T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist a Haypence token.
Dec 13 2016, 5:13 PM · Diffusion (v3), Arcanist, Differential
cspeckmim awarded T7899: DifferentialDiff->description is "text255?" but should be "text" a Dat Boi token.
Dec 13 2016, 5:08 PM · Differential, Mercurial, Arcanist
epriestley claimed T7899: DifferentialDiff->description is "text255?" but should be "text".
Dec 13 2016, 5:07 PM · Differential, Mercurial, Arcanist
epriestley added projects to T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist: Differential, Diffusion, Arcanist.
Dec 13 2016, 5:07 PM · Diffusion (v3), Arcanist, Differential
epriestley created T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist.
Dec 13 2016, 5:06 PM · Diffusion (v3), Arcanist, Differential
epriestley added a project to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches: Diffusion.
Dec 13 2016, 4:40 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley moved T11057: Allow installs to manage which cluster service new repositories allocate on from Backlog to Clusters on the Diffusion board.
Dec 13 2016, 4:40 PM · Diffusion, Clusters
epriestley moved T6722: Support "Create similar repository..." in Diffusion from Backlog to v3 on the Diffusion board.
Dec 13 2016, 4:38 PM · Diffusion (v3), Restricted Project
epriestley moved T6008: Editing files and contributing changes via web from Backlog to Far Future on the Diffusion board.
Dec 13 2016, 4:37 PM · Restricted Project, Wikimedia, Diffusion, Differential
epriestley moved T929: Allow two arbitrary revisions to be compared in Diffusion from Backlog to v3 on the Diffusion board.
Dec 13 2016, 4:36 PM · Diffusion (v3), Restricted Project
epriestley moved T10883: Allow repository cluster nodes to be read-only from Backlog to Clusters on the Diffusion board.
Dec 13 2016, 4:35 PM · Restricted Project, Diffusion, Clusters
epriestley moved T5000: Using Differential with plain Git, without requiring Arc from Future Work to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:32 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley moved T182: Commit into repository directly from differential from Future Work to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:32 PM · Haskell.org, Restricted Project, Differential
epriestley moved T731: Allow revisions to have alternate acceptance conditions from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:30 PM · Restricted Project, Restricted Project, Differential
epriestley moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:29 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley moved T4631: Allow Differential to raise warnings on the server side via Conduit from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:29 PM · Restricted Project, Differential, Arcanist
epriestley moved T8475: Clean up remnants of old Differential hunk storage from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:27 PM · Infrastructure, Restricted Project, Differential
epriestley moved T8623: Upgrading: Differential Hunk Migration from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:27 PM · Installing & Upgrading, Differential, Guides
epriestley closed T10000: Consider restoring Clowncopterize as Wontfix.

This hasn't moved forward in a year so I'm just going to close it. We've removed header text in the latest UI iteration, too, and I imagine the button will be replaced completely with universal send-on-enter before long.

Dec 13 2016, 4:25 PM · Differential, Feature Request
epriestley moved T10574: A pathway toward "All Reviewers Must Accept" from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:22 PM · FreeBSD, Restricted Project, Differential
epriestley moved T10967: Move Differential reviewers back to a dedicated database storage table from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:21 PM · Restricted Project, Infrastructure, Differential
epriestley moved T10968: File write failure during daemon operations caused daemons to populate a few too many diffs from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:21 PM · Files, Differential, Diffusion, Daemons
epriestley moved T11050: Allow resigning from a review you are not directly responsible for from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley moved T11114: Move Differential to EditEngine from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T4045: Store diffs as binary, not UTF-8 from v2 (UI/Mobile) to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Restricted Project, Support Impact, Differential
epriestley moved T11660: Diff creation fails when submitting too long file paths from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Differential, Bug Report
epriestley moved T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Backlog to Future Work on the Differential board.
Dec 13 2016, 4:13 PM · Diffusion (v3), Differential, Mail
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

Although it's still a little early to be sure, we appear to have fixed the policy issue with unit test failures (D17029). Not sure if that actually impacted this or not.

Dec 13 2016, 4:12 PM · Daemons, Differential, Bug Report
epriestley closed T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in as Resolved by committing Restricted Diffusion Commit.
Dec 13 2016, 3:34 PM · Files, Documentation, Bug Report
epriestley updated the task description for T12004: Scenario: Locations Application.
Dec 13 2016, 3:16 PM
epriestley created T12009: Locations Scenario: View Controller.
Dec 13 2016, 3:10 PM
epriestley created T12008: Locations Scenario: Improve New User Experience (NUX).
Dec 13 2016, 2:59 PM
epriestley created T12007: Locations Scenario: Destroying Locations.
Dec 13 2016, 2:54 PM
epriestley created T12006: Locations Scenario: Add API Support.
Dec 13 2016, 2:47 PM
epriestley created T12005: Locations Scenario: Fix a Typo.
Dec 13 2016, 2:36 PM
epriestley created T12004: Scenario: Locations Application.
Dec 13 2016, 2:27 PM
stevex awarded T5954: Modularize "Export to Excel" as a feature of ApplicationSearch a Like token.
Dec 13 2016, 1:42 PM · Custom Fields, ApplicationSearch
epriestley closed T7457: On dashboards, maybe only draw panels if all panels above them have already drawn as Wontfix.

My dashboard changed at some point and no one else seems to care, so let's wait for this to be more than an @epriestley-problem.

Dec 13 2016, 1:02 PM · Dashboards
epriestley renamed T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in from Upload Failure to Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.
Dec 13 2016, 12:59 PM · Files, Documentation, Bug Report
epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

D17037 should fix the documentation, it definitely wasn't very clear as written. That should land some time today and the docs should be updated in about 24 hours.

Dec 13 2016, 12:58 PM · Files, Documentation, Bug Report
epriestley added a revision to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in: Unknown Object (Differential Revision).
Dec 13 2016, 12:57 PM · Files, Documentation, Bug Report
epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

In the first row of that table, it appears that you have configured a storage.mysql-engine.max-size of 8 ("8 bytes"). Try using 8388608 ("8 megabytes") instead?

Dec 13 2016, 12:54 PM · Files, Documentation, Bug Report
epriestley closed T7354: Register mis-spelled domain names as Wontfix.

If you want to come up with a specific list of domains I'm happy to buy them, but there are many hundreds of domains which differ from phacility.com by only one keystroke and buying hundreds of domains isn't cheap in terms of the amount of work I have to do to do it.

Dec 13 2016, 12:53 PM · Phacility
epriestley added a comment to T12003: Explain to users how fulltext queries are parsed and executed.

I can find this task by searching for "あああああ" so the CJK stuff may not really be much of an issue anymore? Maybe just an issue with Chinese because the index doesn't know how to tokenize words?

Dec 13 2016, 12:38 PM · Search
epriestley added a parent task for T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: T12003: Explain to users how fulltext queries are parsed and executed.
Dec 13 2016, 12:36 PM · Search
epriestley added subtasks for T12003: Explain to users how fulltext queries are parsed and executed: T6892: Invalid search result when I input less than 2 Korean character., T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.
Dec 13 2016, 12:36 PM · Search
epriestley added a parent task for T6892: Invalid search result when I input less than 2 Korean character.: T12003: Explain to users how fulltext queries are parsed and executed.
Dec 13 2016, 12:36 PM · Elasticsearch
epriestley created T12003: Explain to users how fulltext queries are parsed and executed.
Dec 13 2016, 12:36 PM · Search
epriestley closed T6841: Maybe create an annotation for "this is strictly a template class" as Wontfix.

At least today, our error rate on this seems so low that it probably isn't worth implementing. We could take another look at it if we see more of it in the future (perhaps after we begin encouraging application development), but we haven't seen more of this that I can recall recently.

Dec 13 2016, 12:29 PM · Lint
epriestley renamed T6633: 'differential.creatediff' exception when repository paths contain SHIFT-JIS characters from 'differential.creatediff' exception to 'differential.creatediff' exception when repository paths contain SHIFT-JIS characters.
Dec 13 2016, 12:22 PM · Arcanist
epriestley closed T6611: Add history to Paste as Resolved.

Paste now shows "Old", "New" and "Diff", so you can copy/paste from "Old" to revert. Not perfect, but I think this arises relatively rarely. See T11881 for a followup.

Dec 13 2016, 12:21 PM · Restricted Project, Paste
epriestley closed T6592: Differential history mangles bullet numbering in quoted email forward as Resolved.

This is extremely old and it's not clear to me which bad cases remain -- I can't immediately find any by fiddling. If any do remain, they haven't turned up again in about two years. If you're still seeing issues, feel free to file a new task with a modern test case.

Dec 13 2016, 12:17 PM · Remarkup
epriestley closed T6443: Provide ApplicationSearch options for Dashboard as Resolved.

This picked up a few options through engine support and T11957 is adding some more. Particularly, default view is now "Authored" which I think resolves the original issue. I think the more-root problem is "Dashboards are kind of weird with all the panel copying", which is something we're aware of.

Dec 13 2016, 12:11 PM · Dashboards (v2)
epriestley closed T6389: Ship TShirt as Wontfix.

I am very sorry I am declaring t-shirt bankruptcy because I have learned it takes me over five hundred years to ship a t-shirt.

Dec 13 2016, 12:07 PM · Public & Media Relations
epriestley merged T6193: Allow Arcanist to allocate resources through Drydock into T11693: Make drydock command interfaces accessible via SSH workflows.
Dec 13 2016, 11:55 AM · Restricted Project, Drydock
epriestley merged task T6193: Allow Arcanist to allocate resources through Drydock into T11693: Make drydock command interfaces accessible via SSH workflows.
Dec 13 2016, 11:55 AM · Arcanist, Drydock
epriestley added a comment to T11957: Add MenuEngine to Home.

At some point after we get this working for Home, I want to replace the "Quick Create" menu with a similar customizable profile menu, resolving T5867.

Dec 13 2016, 11:48 AM · Profile Menu Item, Dashboards
epriestley added a subtask for T11957: Add MenuEngine to Home: T5867: Move Quick Create to MenuItemEngine.
Dec 13 2016, 11:47 AM · Profile Menu Item, Dashboards
epriestley added a parent task for T5867: Move Quick Create to MenuItemEngine: T11957: Add MenuEngine to Home.
Dec 13 2016, 11:47 AM · Design
epriestley added a project to T5657: Ability to rename flags: Contributor Onboarding.
Dec 13 2016, 11:41 AM · Contributor Onboarding, Restricted Project, Flags
epriestley renamed T6188: User should receive a nicer exception when selecting an invalid application policy like "Can Use Application: No One" from "Can Use Application" policy value "No One" useless? to User should receive a nicer exception when selecting an invalid application policy like "Can Use Application: No One".
Dec 13 2016, 11:40 AM · Policy
epriestley closed T6996: Write an `--output <file>` mode for `storage dump` which can gzip, a subtask of T7148: Allow users to export their data from Phacility, as Resolved.
Dec 13 2016, 11:38 AM · Phacility
epriestley closed T6996: Write an `--output <file>` mode for `storage dump` which can gzip as Resolved.

rCORE9d89c996844c4599afc1cec9454a71dd80a69c6c threw out the -o pipefail nonsense in CoreHostBackupWorkflow.

Dec 13 2016, 11:38 AM · Infrastructure, Phacility
epriestley closed T6996: Write an `--output <file>` mode for `storage dump` which can gzip, a subtask of T10758: Make `bin/storage dump` replica-aware, as Resolved.
Dec 13 2016, 11:38 AM · Restricted Project
epriestley added a comment to T11971: Build an Icon Typeahead.

(I renamed the "Up for Grabs" column to "Ready", and kicked this out since it doesn't have detailed technical instructions that a new contributor could follow like the other tasks in that column do.)

Dec 13 2016, 11:36 AM · PHUI
epriestley moved T11971: Build an Icon Typeahead from Ready to Backlog on the Contributor Onboarding board.
Dec 13 2016, 11:35 AM · PHUI