Page MenuHomePhabricator
Feed Advanced Search

Jul 5 2016

epriestley renamed T9640: Make Phabricator compatible with PHP7 from Ensure PHP7 compatiblity to Phabricator PHP 7 Compatibility.
Jul 5 2016, 12:49 AM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T9640: Make Phabricator compatible with PHP7.

T11270 describes a major issue with asynchronous signal handling in PHP 7 which I don't believe we have a reasonable workaround for.

Jul 5 2016, 12:43 AM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

Yes, that's synchronous signal handling.

Jul 5 2016, 12:42 AM · Daemons, Bug Report
epriestley added a subtask for T9640: Make Phabricator compatible with PHP7: T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.
Jul 5 2016, 12:39 AM · Prioritized, Restricted Project, Infrastructure
epriestley added a parent task for T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands: T9640: Make Phabricator compatible with PHP7.
Jul 5 2016, 12:39 AM · Daemons, Bug Report
epriestley renamed T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands from Daemons fail to stop and must be terminated to PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.
Jul 5 2016, 12:38 AM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

Yes, this reproduces on a local build of PHP 7.0.8. Here's what I did:

Jul 5 2016, 12:38 AM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I'm building PHP 7.0.8 locally. In the meantime, I found these possibly similar reports:

Jul 5 2016, 12:27 AM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

Here's a smaller, self-contained test case:

Jul 5 2016, 12:15 AM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I produced this test script to try to see about version issues via 3v4l.org, but you can't write files there. Requiring C as part of a different file is important, so I don't see a way to use that.

Jul 5 2016, 12:06 AM · Daemons, Bug Report

Jul 4 2016

epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I put the global signal handler in run(), unresponsive.

Jul 4 2016, 11:52 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I no-op'd the constructor and put the logic in run(), still unresponsive.

Jul 4 2016, 11:44 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I disabled the entire actual daemon behavior, still unresponsive.

Jul 4 2016, 11:40 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

Removing the SIGINT handler entirely made it responsive.

Jul 4 2016, 11:34 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I changed the SIGINT handler to exit immediately, still unresponsive to SIGINT:

Jul 4 2016, 11:32 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

This trivial script works correctly:

Jul 4 2016, 11:29 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

The PhutilNiceDaemon daemon also does not respond to ^C.

Jul 4 2016, 11:24 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

The debug daemon does not appear to respond to an external SIGTERM (via kill <pid> either).

Jul 4 2016, 11:21 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

With --trace, the daemon isn't doing any work, and also isn't hung (just normal queries to look at the queue).

Jul 4 2016, 11:20 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I ran bin/phd stop and saw similar behavior:

Jul 4 2016, 11:17 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

@Mnkras gave me access to the host.

Jul 4 2016, 11:03 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I can't reproduce that either:

Jul 4 2016, 10:49 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I can't reproduce this. Here's what I did:

Jul 4 2016, 10:43 PM · Daemons, Bug Report
epriestley added a comment to T11239: Add ability to flag user to not trigger notifications.

Just file a new task once you have the necessary information.

Jul 4 2016, 6:42 PM · Restricted Project, Wikimedia, Feature Request
epriestley closed T11243: User Guide links should open in a new tab as Resolved by committing Restricted Diffusion Commit.
Jul 4 2016, 5:59 PM · Documentation, Feature Request
epriestley closed T11232: MySQL connection may not respect timeout? as Resolved.

This didn't have a reliable reproduction case, but from limited spot-checking of production logs I don't see it happening any more.

Jul 4 2016, 5:50 PM · Phacility
epriestley closed T11239: Add ability to flag user to not trigger notifications as Invalid.

We need a root problem description to move forward here.

Jul 4 2016, 5:43 PM · Restricted Project, Wikimedia, Feature Request
epriestley added a revision to T11243: User Guide links should open in a new tab: Unknown Object (Differential Revision).
Jul 4 2016, 5:40 PM · Documentation, Feature Request
epriestley claimed T11243: User Guide links should open in a new tab.
Jul 4 2016, 5:40 PM · Documentation, Feature Request
epriestley closed T11251: Diff dependency should cause shared lines to be hidden as Resolved.

@avivey's answer is correct.

Jul 4 2016, 5:35 PM · Feature Request
epriestley added Q437: How do I debug an ldap issue? (Answer 414).
Jul 4 2016, 5:28 PM
epriestley added a comment to T11267: Commit graph broken for Mercurial repositories.

Thanks for the report! I think this should be fixed in HEAD of master. Let us know if that doesn't work or you run into anything else.

Jul 4 2016, 5:26 PM · Diffusion, Bug Report
epriestley closed T11267: Commit graph broken for Mercurial repositories as Resolved by committing Restricted Diffusion Commit.
Jul 4 2016, 5:24 PM · Diffusion, Bug Report
epriestley added a revision to T11267: Commit graph broken for Mercurial repositories: Unknown Object (Differential Revision).
Jul 4 2016, 5:23 PM · Diffusion, Bug Report
epriestley claimed T11267: Commit graph broken for Mercurial repositories.
Jul 4 2016, 5:15 PM · Diffusion, Bug Report
fanis awarded T11257: HTML in Diffusion not escaped in certain circumstances a Orange Medal token.
Jul 4 2016, 1:29 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley closed T11266: Help text lost, when editing Diffusion Repository branches as Invalid.

https://secure.phabricator.com/book/phabricator/article/diffusion_managing/#branches

Jul 4 2016, 9:23 AM · Bug Report
epriestley closed T11159: Cluster detection of "replication OK" is unreasonably optimistic as Resolved by committing Restricted Diffusion Commit.
Jul 4 2016, 1:14 AM · Prioritized, Clusters
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Jul 4 2016, 1:13 AM · Prioritized, Localization

Jul 3 2016

epriestley moved T11159: Cluster detection of "replication OK" is unreasonably optimistic from The Queue to Paused on the Prioritized board.
Jul 3 2016, 11:41 PM · Prioritized, Clusters
epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

Turns out that CustomFields sort of just work properly with EditEngine out of the box, so D16226 provides a technically-functional dashboard.panel.edit, which allows you to edit text panels like this, for example:

Jul 3 2016, 10:12 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley added a revision to T10855: Allow external systems to edit the content of dashboard panels so they can publish information: Unknown Object (Differential Revision).
Jul 3 2016, 9:47 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley removed a project from T8911: Calendar List view sorting happens after limits are applied: Dashboards.

I don't think there's anything about this specific to Dashboards.

Jul 3 2016, 9:20 PM · Calendar
epriestley closed T9199: Name of builtin "Projects" feed query does not make result obvious as Wontfix.

We haven't seen other confusion about this in context.

Jul 3 2016, 9:19 PM · Dashboards, Feed
epriestley moved T10612: Editing a panel causes it to duplicate in dashboard from Backlog to v2 on the Dashboards board.
Jul 3 2016, 9:17 PM · Dashboards (v2), Bug Report
epriestley moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Backlog to v2 on the Dashboards board.
Jul 3 2016, 9:17 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley closed T11265: Milestone series navigation doesn't work as Invalid.
Jul 3 2016, 9:16 PM · Projects, Bug Report
epriestley added a revision to T11159: Cluster detection of "replication OK" is unreasonably optimistic: Unknown Object (Differential Revision).
Jul 3 2016, 9:15 PM · Prioritized, Clusters
epriestley added a comment to T11264: Add access key for global search field.

In the future, we might reasonably want to put tabindex="1" on the first input on form pages, like the "Edit Task" page, so that you could press tab once to quickly begin editing. If we put tabindex="1" on global search, the cost of making this change in the future will be much higher.

Jul 3 2016, 8:57 PM · Accessibility, Feature Request
epriestley added a comment to T11265: Milestone series navigation doesn't work.

Phabricator has no such sidebar item. Where are you seeing this?

Jul 3 2016, 8:54 PM · Projects, Bug Report
epriestley added a comment to T11264: Add access key for global search field.

Can you substantiate "f" being "typically used"? Here's what I see in use in the wild from a quick survey of popular sites and software:

Jul 3 2016, 7:54 PM · Accessibility, Feature Request
epriestley added a comment to T11264: Add access key for global search field.

This feature has a tiny impact and a huge support cost.

Jul 3 2016, 7:00 PM · Accessibility, Feature Request
epriestley closed T11264: Add access key for global search field as Wontfix.

See discussion in D15984.

Jul 3 2016, 2:44 PM · Accessibility, Feature Request
epriestley added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

/ was removed, see D15976 and the changelog:

Jul 3 2016, 2:15 PM · Bug Report (Needs Information)
epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

We probably need to do almost all of this work before adding new panel types anyway, since building a new panel type on top of CustomFields would make moving everything from CustomFields to EditEngine harder.

Jul 3 2016, 9:11 AM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley added a comment to T9360: Unbeta Phame.
In T9360#183602, @chad wrote:

Is [HTTPS] simple? Not sure where to start? Nothing is jumping out at me here.

Jul 3 2016, 9:06 AM · Phame
epriestley edited subtasks for T9897: Unbeta Feedback on Phame, added: T6299: Remarkup links to objects in Phame break if a CNAME is set; removed: T4936: Phame is not accessible on a custom domain without `policy.allow-public`.
Jul 3 2016, 9:00 AM · Phame
epriestley removed a parent task for T4936: Phame is not accessible on a custom domain without `policy.allow-public`: T9897: Unbeta Feedback on Phame.
Jul 3 2016, 9:00 AM · Phame
epriestley added a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Jul 3 2016, 9:00 AM · Haskell.org, Remarkup, Phame
epriestley removed a subtask for T9897: Unbeta Feedback on Phame: T6299: Remarkup links to objects in Phame break if a CNAME is set.
Jul 3 2016, 9:00 AM · Phame
epriestley removed a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Jul 3 2016, 9:00 AM · Haskell.org, Remarkup, Phame
epriestley merged T11262: On slow connections, it's possible to submit the Create Task form on workboards multiple times into T11145: Dialog submit buttons don't disable on click.
Jul 3 2016, 8:37 AM · Restricted Project, PHUI, Bug Report
epriestley merged task T11262: On slow connections, it's possible to submit the Create Task form on workboards multiple times into T11145: Dialog submit buttons don't disable on click.
Jul 3 2016, 8:37 AM · Maniphest, Bug Report

Jul 2 2016

epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

The actual panel transactions that we need to update for this aren't too bad. The board transactions are a little more involved, but we can skip them.

Jul 2 2016, 7:36 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley moved T5267: Localize Phabricator from Backlog to The Queue on the Prioritized board.
Jul 2 2016, 7:24 PM · Prioritized, Localization
epriestley moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Preflight to The Queue on the Prioritized board.
Jul 2 2016, 7:24 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley removed a project from T11051: "Explain Why" isn't properly explaining why revisions were closed: Prioritized.

This could still be improved, but the immediate confusion we encountered appears fixed.

Jul 2 2016, 7:18 PM · Restricted Project, Differential, Bug Report
epriestley removed a project from T7916: Can't paste images from clipboard in Firefox / Safari: Prioritized.
Jul 2 2016, 7:17 PM · Restricted Project, Firefox, Safari, PHUI
epriestley moved T3875: Allow arc to perform cascading rebases, maybe during or after `arc land` from Backlog to Rugged Terrain on the Prioritized board.
Jul 2 2016, 7:15 PM · Prioritized, Restricted Project, Arcanist
epriestley moved T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI from Backlog to The Queue on the Prioritized board.
Jul 2 2016, 7:12 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

We can fix the highly-tractable web UI part, at least.

Jul 2 2016, 7:12 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley renamed T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI from arcanist incorrectly parses fields inside fields to Prevent users from generating an ambiguous commit message by editing revisions with the web UI.
Jul 2 2016, 7:12 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley moved T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks from The Queue to Paused on the Prioritized board.
Jul 2 2016, 7:11 PM · Prioritized, Wikimedia, Remarkup
epriestley removed a project from T9789: Make it easier to write custom transaction types: Prioritized.

(Just bookkeeping; there's no external priority on this.)

Jul 2 2016, 7:10 PM · Modernization, Transactions
epriestley moved T11114: Move Differential to EditEngine from Backlog to Rugged Terrain on the Prioritized board.
Jul 2 2016, 7:09 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from Preflight to Rugged Terrain on the Prioritized board.
Jul 2 2016, 7:09 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley moved T8909: Provide ability to hide all inline or done comments from Backlog to Rugged Terrain on the Prioritized board.

I'm moving this to "Rugged Terrain", as the best available pathway forward leaves us with dramatically higher implementation cost than the reasonable value of the feature. We can pursue this after tasks with better aligned costs and value are addressed.

Jul 2 2016, 7:09 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley removed a project from T4631: Allow Differential to raise warnings on the server side via Conduit: Prioritized.

Mooted from a prioritization standpoint by D16139.

Jul 2 2016, 7:01 PM · Restricted Project, Arcanist, Differential
epriestley moved T11159: Cluster detection of "replication OK" is unreasonably optimistic from Backlog to The Queue on the Prioritized board.
Jul 2 2016, 7:00 PM · Prioritized, Clusters
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

That sounds good to me, should give us more clarity around the dashboard stuff.

Jul 2 2016, 6:35 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

When you're editing a homepage dashboard, just having a spacer bar there for the applications menu might help make it more clear that 66/33 is better in a lot of cases than 50/50 -- currently, you can't see what stuff will really look like until you're already done and installed.

Jul 2 2016, 6:33 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

wow pretty sure I even picked numbers that add up to 100%

Jul 2 2016, 6:32 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

I definitely think we should skip the 3-column versions for now, I don't think we've seen any kind of need for them in practice. We could look at it again after Facts since I think some of these weirder things could make more sense on standalone dashboards, the app just isn't powerful enough yet for that to be paritcularly useful.

Jul 2 2016, 6:32 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Do you think 50/50 and 33/66 are always bad even for standalone (not-on-homepage) dashboards? e.g., if we had a "Phacility Metrics" dashboard in the future after Facts, a 50/50 of a "Users" column and "Revenue" column or whatever could never be a useful way to present the information?

Jul 2 2016, 6:22 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Haha, that's probably T10612.

Jul 2 2016, 6:16 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Why do you think installs (offhand: Babel, WMF) are picking 1/2 + 1/2 if they're strictly worse than 2/3 + 1/3?

Jul 2 2016, 6:05 PM · Dashboards
epriestley triaged T11260: Deactivate "Adjust timezone" when user setting is UTC as Wishlist priority.

You're the only user we're currently aware of who wants to use the software like this, so I don't plan to address this use case at this time.

Jul 2 2016, 5:03 PM · User Preferences
epriestley added a comment to T11260: Deactivate "Adjust timezone" when user setting is UTC.

But when I am looking at my calendar app, I want to see local times, for whatever timezone I am in.

Jul 2 2016, 4:50 PM · User Preferences
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

they won't not exist

Jul 2 2016, 4:41 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

"Ignored" in the sense of: no publishing, no herald rules, no audit triggers. Not, like, "they won't not exist".

Jul 2 2016, 4:41 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Only that any legitimate commits pushed until things catch up will also be ignored. The repository will automatically leave the mode once everything finishes.

Jul 2 2016, 4:40 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

There was a relatively recent change to make Phabricator discover commits which are only reachable from tags and refs. As it discovers these commits, it will treat them like new commits and publish feed stories about them. This is a one-time event, but a few installs have a lot of tag-reachable commits for whatever reason. You can find a bit more discussion in T11188, and details about the change in T9028 and T6878.

Jul 2 2016, 4:35 PM · Bug Report
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

This doesn't appear to even to be possible in Firefox. Here's a simple example:

Jul 2 2016, 4:31 PM · Restricted Project, Firefox, Safari, PHUI
epriestley closed T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27 as Resolved.

Oh, or Apache.

Jul 2 2016, 4:27 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Also likely fixed by restarting PHP-FPM, that method is defined here:

Jul 2 2016, 4:26 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Did you restart everything after upgrading? See Restarting Phabricator.

Jul 2 2016, 4:25 PM · Bug Report
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

From the Firefox bug and this linked one:

Jul 2 2016, 3:44 PM · Restricted Project, Firefox, Safari, PHUI
epriestley closed T9028: Phabricator handles commits which are published and later deleted poorly as Resolved.

This appears to be stable, and is now accounted for.

Jul 2 2016, 3:24 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley closed T11098: Feedback and Errata for Global Settings as Resolved.

This seem quiet and is now accounted for.

Jul 2 2016, 3:22 PM · Prioritized, Restricted Project, User Preferences
epriestley closed T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them as Resolved.

This appears functional and is now accounted for.

Jul 2 2016, 3:18 PM · Prioritized, Restricted Project, User Preferences