Page MenuHomePhabricator
Create Task
Maniphest T11259

UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27
Closed, ResolvedPublic
Actions

Description

>>> UNRECOVERABLE FATAL ERROR <<<

Call to undefined method PHUIHeaderView::setActionListID()

/opt/phabricator/src/view/phui/PHUITwoColumnView.php:117


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

Looking in to this now. This is the first failed upgrade we've encountered.

Versions:

phabricator 58375fa9e6db4a389fd6029ee1ad14ddb0dc9e90 (Sat, Jul 2)
arcanist f1c45a3323ae20eefe29c0a22c7923fe8b151bbf (Fri, Jul 1)
phutil 119e5b12ba068b6554918f3924a449cbaabe1d14 (Fri, Jul 1)

Related Objects

Event Timeline

featherless created this task.Jul 2 2016, 4:23 PM

Getting the following when I visit differential/:

Exception
Bad getter call: getStatusIcon
epriestley added a subscriber: epriestley.Jul 2 2016, 4:25 PM

Did you restart everything after upgrading? See Restarting Phabricator.

The method should be defined here:

https://secure.phabricator.com/diffusion/P/browse/master/src/view/phui/PHUIHeaderView.php;d7b4c50941fada3b5550ed8a795be2c479f4973b$94-97

epriestley added a comment.Jul 2 2016, 4:26 PM

Also likely fixed by restarting PHP-FPM, that method is defined here:

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/differential/storage/DifferentialRevision.php;d7b4c50941fada3b5550ed8a795be2c479f4973b$433-450

featherless added a comment.Jul 2 2016, 4:26 PM

Just rebooted apache once more and things are looking better.

epriestley closed this task as Resolved.Jul 2 2016, 4:27 PM
epriestley claimed this task.

Oh, or Apache.

These errors are pretty typical of things not being fully restarted, so I suspect you'll be in the clear now.

Let us know if you run into anything else.

featherless added a comment.EditedJul 2 2016, 4:28 PM

Thanks for quick response; hadn't seen this before so couldn't tell how serious the errors were.

Is it normal to see our feed re-circulating old diffs?

featherless added a comment.Jul 2 2016, 4:30 PM

Ah, I found the problem in our upgrade script. We run our upgrade in the following order:

  • Stop daemons
  • Stop apache
  • Run apt-get upgrade
  • Update phabricator
  • Reboot apache
  • Start daemons

Looks like apache had an update, so when apt-get performed the upgrade it rebooted the apache server.

epriestley added a comment.EditedJul 2 2016, 4:35 PM

Ah, interesting.

There was a relatively recent change to make Phabricator discover commits which are only reachable from tags and refs. As it discovers these commits, it will treat them like new commits and publish feed stories about them. This is a one-time event, but a few installs have a lot of tag-reachable commits for whatever reason. You can find a bit more discussion in T11188, and details about the change in T9028 and T6878.

If you have a lot of tag-only or ref-only commits, you can put affected repositories into "importing" mode until everything catches up:

phabricator/ $ ./bin/repository mark-imported --mark-not-imported rXYZ ...

That should silence them until the new imports finish.

featherless added a comment.EditedJul 2 2016, 4:39 PM

Ok; will let it do its thing then.

Are there adverse effects to putting a repository into "importing" mode?

epriestley added a comment.Jul 2 2016, 4:40 PM

Only that any legitimate commits pushed until things catch up will also be ignored. The repository will automatically leave the mode once everything finishes.

epriestley added a comment.Jul 2 2016, 4:41 PM

"Ignored" in the sense of: no publishing, no herald rules, no audit triggers. Not, like, "they won't not exist".

epriestley added a comment.Jul 2 2016, 4:41 PM

they won't not exist

Er, I mean won't not not exist.

featherless added a comment.Jul 2 2016, 4:41 PM

Got it. Thank you! I just started the reindexing operations recommended in this release so I may leave things be 'til that finishes.

Phabricator · Built by Phacility