Since / shorcut has been removed in D15976, then it would be great to add access key for global search field. Suggesting "f", which is most typically used. It will also improve the accessibility.
Description
Description
Related Objects
Related Objects
- Mentioned In
- rP1a303e7d2a60: Make "/" focus the search input again
D15984: Make "/" focus the search input again - Mentioned Here
- T4103: Implement "Role Profiles" to provide search, homepage and application defaults
T8286: Press quick keyboard shortcut to focus main search bar, or open search modal
T11231: / no longer available to focus on search input?
T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts
D15984: Make "/" focus the search input again
D15976: Remove "Search Preferences"
Event Timeline
Comment Actions
Those are all about preferences and JavaScript handling...
What I'm trying to request is only to add accesskey attribute, nothing else.
From current
<input type="text" name="query" id="UQ0_71" autocomplete="off" /> <!-- page source --> <input type="text" autocomplete="off" id="UQ0_71" name="query" data-autoid="autoid_10" class=" jx-typeahead-placeholder"> <!-- Firebug DOM copy -->
to desired
<input type="text" name="query" id="UQ0_71" autocomplete="off" accesskey="f" /> <!-- page source --> <input type="text" autocomplete="off" id="UQ0_71" name="query" data-autoid="autoid_10" class=" jx-typeahead-placeholder" accesskey="f" /> <!-- Firebug DOM copy -->
That shouldn't be that difficult?
Comment Actions
Can you substantiate "f" being "typically used"? Here's what I see in use in the wild from a quick survey of popular sites and software:
| Software | Access Key |
|---|---|
| Mediawiki | f |
| None | |
| None | |
| None | |
| USPS | None |
| Whitehouse.gov | None |
| Yahoo | None |
| Baidu | None |
| Amazon | None |
| None | |
| Bing | None |
| Apple | None |
| Microsoft | None |
| None | |
| None | |
| Mozilla | None |
Here's some code review and bug tracking software:
| Software | Access Key |
|---|---|
| GitHub | None |
| Bitbucket | None |
| Trac | None |
| Bugzilla | None |
| Trello | None |
Here are some standards and accessibility-focused sites:
| Site | Access Key |
|---|---|
| W3C (w3.org) | None |
| WebAIM | None |
| JAWS Screen Reader | None |
| ADA.gov | None |
| "UK Government Recommendations (2002)" | 4 |
| "UK Government Recommendations (2002)" Host Site | None |
| "Standard Access Keys 2014" | 4 |
| "Standard Access Keys 2014" Parent Site (a Mediawiki) | f |
Comment Actions
Good point, thanks for research. I was looking in some notes from research done several years ago, thus obviously no longer accurate.
However, it is still quite comfortable to navigate to the search input:
Github: data-hotkey="s" tabindex="1"
W3C: tabindex="3"
Google main page: autofocused
Yahoo: autofocus=""
If you don't want to make Phabricator more user friendly for users using keyboard by adding access key which won't hurt anything, how about tabindex="1", which is totally harmless? (autofocus isn't good in this particular case)
TBH, I seriously do not understand what's bad on it. If it would be breaking something or adding other maintenance work (such as preferences or so), I would understand, but adding single harmless attribute? Sure I can miss somethhing and I would be happy if you could explain why accesskey or tabindex would be bad for Phabricator. Thank you.
Comment Actions
In the future, we might reasonably want to put tabindex="1" on the first input on form pages, like the "Edit Task" page, so that you could press tab once to quickly begin editing. If we put tabindex="1" on global search, the cost of making this change in the future will be much higher.