Page MenuHomePhabricator
Feed Advanced Search

Feb 23 2016

epriestley added a comment to T10420: Code coverage reports from `arc unit` are sometimes inaccurate.

In the very, very general case, I think it's undesirable to favor "N" over "U" because the reports could be coming from two different engines, only one of which knows how to execute the lines.

Feb 23 2016, 12:08 PM · Arcanist, Bug Report
epriestley updated subscribers of T5793: Add support for personal workboards.
Feb 23 2016, 11:47 AM · User Delight, Wikimedia, Workboards
epriestley merged task T10421: Workboard for my assigned tasks across projects into T5793: Add support for personal workboards.
Feb 23 2016, 11:47 AM · Feature Request
epriestley added a comment to T10418: Running arc land in a repository running git with unstaged changes that conflict with master wipes out those changes..

I added you to Community if you want to do the honors. :)

Feb 23 2016, 1:59 AM · Arcanist, Bug Report
epriestley added a member for Community: sophie.
Feb 23 2016, 1:59 AM
epriestley added a comment to T10419: Sample herald rule results.

herald_test.png (986×1 px, 141 KB)

Feb 23 2016, 1:39 AM · Herald, Feature Request
epriestley added a comment to T10418: Running arc land in a repository running git with unstaged changes that conflict with master wipes out those changes..

I can't immediately reproduce this, here's what I get:

Feb 23 2016, 1:09 AM · Arcanist, Bug Report
• dmgander awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Feb 23 2016, 12:34 AM · Workboards (v3), Restricted Project

Feb 22 2016

epriestley added a revision to T10411: Modernize Almanac to support EditEngine: Unknown Object (Differential Revision).
Feb 22 2016, 10:51 PM · Almanac (v2)
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Feb 22 2016, 10:51 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a comment to T10416: 7b8d38cd causes hangs with SSH master connection.

Since only the first connection has an issue, you could also conceivably add a slightly-more-than-one-line patch to make arc land run some no-op remote operation (git remote show origin?) and then immediately kill the subprocess, creating and throwing away the bad connection so the followup doesn't hang.

Feb 22 2016, 8:56 PM · Arcanist, Bug Report
epriestley closed T10416: 7b8d38cd causes hangs with SSH master connection as Wontfix.

If you're open to patching one site, you can just comment out the feof($stderr) to retain the bulk of the change (i.e., still wait for stdout).

Feb 22 2016, 8:52 PM · Arcanist, Bug Report
epriestley added a comment to T10414: No natural sort on space dropdown.

I can sort of see arguments either way, although I think I'm inclined to names too.

Feb 22 2016, 8:49 PM · Bug Report
epriestley added a comment to T10412: Change Milestone sort options.

Change milestoneNumber in phabricator_project.project to reorder milestones.

Feb 22 2016, 8:43 PM · Feature Request
epriestley added a comment to T10414: No natural sort on space dropdown.

Is sorting by Space ID (instead of Space name) definitely your preferred sort?

Feb 22 2016, 8:42 PM · Bug Report
epriestley renamed T10413: Archived project tags are hidden everywhere, not just on Workboard cards from Relation between task and project lost after milestone is archived to Archived project tags are hidden everywhere, not just on Workboard cards.
Feb 22 2016, 8:41 PM · Projects (v3), Bug Report
epriestley claimed T10413: Archived project tags are hidden everywhere, not just on Workboard cards.
Feb 22 2016, 8:40 PM · Projects (v3), Bug Report
epriestley added a comment to T10413: Archived project tags are hidden everywhere, not just on Workboard cards.

This is unintentional, I only meant to hide archived projects on workboards. They're incorrectly behind hidden in all contexts.

Feb 22 2016, 8:40 PM · Projects (v3), Bug Report
epriestley renamed T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist from Differential dashboard: Making the list of reviews more useful. to Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist.
Feb 22 2016, 8:34 PM · Restricted Project, Differential
epriestley added a comment to T10415: Make it easier to manage large number of repositories with similar configuration via the web ui.

Sorry, I'm still not sure I quite understand the specific use cases for this feature that you anticipate.

Feb 22 2016, 8:28 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10416: 7b8d38cd causes hangs with SSH master connection.

The benefit of enabling ControlPersist is only very slightly faster SSH connections, right?

Feb 22 2016, 8:06 PM · Arcanist, Bug Report
epriestley closed T10410: Deleting Almanac properties does not work, a subtask of T10246: Deploy Drydock in the Phacility cluster, as Resolved.
Feb 22 2016, 7:28 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley closed T10410: Deleting Almanac properties does not work as Resolved by committing Restricted Diffusion Commit.
Feb 22 2016, 7:28 PM · Almanac (v2)
epriestley added a comment to T10415: Make it easier to manage large number of repositories with similar configuration via the web ui.

Do you legitimately have several distinct "profiles"? What differs between them?

Feb 22 2016, 7:27 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10349: Projects v3 Errata.

@20after4 It would be helpful to get a sense of what your ideal tree looks like -- would adding the immediate parent project always be sufficient to disambiguate things? Or would it produce 30 different projects named iPhone > Bugs because the full hierarchy is CrazyFlaps > iPhone > Bugs, FlappyFish > iPhone > Bugs, etc? Or do you have a mixture of hierarchy depths?

Feb 22 2016, 6:03 PM · Restricted Project, Projects (v3)
epriestley added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

If the parent is already a parent project of some other project, it has no direct members, so nothing will be copied. --keep-members parent should do what you want, provided you move "Members" first, before "Subproject A" or "Subproject B".

Feb 22 2016, 5:47 PM · Projects (v3)
epriestley added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

@nochum, can you explain what you're trying to do in more detail?

Feb 22 2016, 4:56 PM · Projects (v3)
epriestley added a revision to T10410: Deleting Almanac properties does not work: Unknown Object (Differential Revision).
Feb 22 2016, 4:18 PM · Almanac (v2)
epriestley closed T10395: Deploy SSH keys associated with a repository as Resolved.
Feb 22 2016, 3:20 PM · Feature Request (Needs Information), Diffusion
epriestley added a revision to T10411: Modernize Almanac to support EditEngine: Unknown Object (Differential Revision).
Feb 22 2016, 1:22 PM · Almanac (v2)
epriestley added a comment to T10246: Deploy Drydock in the Phacility cluster.

Quick summary here:

Feb 22 2016, 1:19 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a parent task for T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked: T10246: Deploy Drydock in the Phacility cluster.
Feb 22 2016, 1:13 PM · Almanac (v2), Security, Phacility
epriestley added subtasks for T10246: Deploy Drydock in the Phacility cluster: T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked, T9762: Removing devices from Almanac services, T10410: Deleting Almanac properties does not work.
Feb 22 2016, 1:13 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a parent task for T9762: Removing devices from Almanac services: T10246: Deploy Drydock in the Phacility cluster.
Feb 22 2016, 1:13 PM · Almanac (v2)
epriestley added a parent task for T10410: Deleting Almanac properties does not work: T10246: Deploy Drydock in the Phacility cluster.
Feb 22 2016, 1:12 PM · Almanac (v2)
epriestley created T10411: Modernize Almanac to support EditEngine.
Feb 22 2016, 1:12 PM · Almanac (v2)
epriestley created T10410: Deleting Almanac properties does not work.
Feb 22 2016, 1:06 PM · Almanac (v2)
epriestley added a comment to T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked.

I also think the current per-service and per-device granular locking might be better off as a cluster.locked global configuration which prevents creating or editing anything touching a cluster service, so I may pursue that.

Feb 22 2016, 1:04 PM · Almanac (v2), Security, Phacility
epriestley created T10409: Document-pro CSS rule is bleeding into Diffusion property lists.
Feb 22 2016, 12:56 PM · Diffusion
epriestley added a comment to T10406: Archived repositories aren't imported.

This just sounds a lot like "I ran rm -rf /var/repo/X/ and all the data for rX vanished" to me, which is completely expected and should be predictable.

Feb 22 2016, 12:52 PM · Bug Report, Diffusion
epriestley added a comment to T10406: Archived repositories aren't imported.

None of the repository replication code is even written, though. What behavior do you expect today?

Feb 22 2016, 12:47 PM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

When we migrate our repository hosting to Phabricator, I plan to setup multiple repository hosts for sufficient redundancy. In this case, I would expect the new hosts to clone the repositories from a read-only slave.

Feb 22 2016, 10:21 AM · Bug Report, Diffusion
epriestley closed T10407: Test123 as Spite.
Feb 22 2016, 10:21 AM
epriestley added a comment to T10406: Archived repositories aren't imported.

Suppose you have a hosted, active repository and do this:

Feb 22 2016, 10:20 AM · Bug Report, Diffusion
ivo awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Love token.
Feb 22 2016, 9:20 AM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
joshuaspence added a comment to T10406: Archived repositories aren't imported.

The steps to reproduce are quite simple:

Feb 22 2016, 6:33 AM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

If the repository is hosted elsewhere then Phabricator isn't the canonical source, and the other system would be responsible for data anyway.

Feb 22 2016, 6:06 AM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

The problem here is that things will mysteriously stop working. Let's say that I refer to rXabcdef in a comment and then later mark rX as archived and replace my repository tier. Anyone who later clicks on the rXabcdef reference will hit an error.

Feb 22 2016, 6:06 AM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

Even if that means data loss?

Feb 22 2016, 6:02 AM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

I disagree that this is the expected behavior, especially if this occurs on hosted repositories (which I can't confirm because I don't have any). If this occurs with hosted repositories, then archived repositories will be forever lost when replacing the repository hosting tier.

Feb 22 2016, 5:59 AM · Bug Report, Diffusion
joshuaspence created T10406: Archived repositories aren't imported.
Feb 22 2016, 5:38 AM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Does changing window to 31 actually fix it for you?

Feb 22 2016, 3:30 AM · Bug Report, Diffusion

Feb 21 2016

epriestley added a revision to T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked: Unknown Object (Differential Revision).
Feb 21 2016, 10:43 PM · Almanac (v2), Security, Phacility
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Feb 21 2016, 10:43 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a comment to Blog Post: Development Notes (2016 Week 8).

Workboards only. See T4213 for discussion of themes and skinning.

Feb 21 2016, 10:08 PM
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Feb 21 2016, 10:06 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a revision to T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked: Unknown Object (Differential Revision).
Feb 21 2016, 10:06 PM · Almanac (v2), Security, Phacility
epriestley closed T10264: git clone using http hangs after update as Resolved.

Thanks for verifying the fix!

Feb 21 2016, 9:16 PM · Bug Report, Diffusion
epriestley added a revision to T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked: Unknown Object (Differential Revision).
Feb 21 2016, 7:16 PM · Almanac (v2), Security, Phacility
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Feb 21 2016, 7:16 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a comment to T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked.

In the Phacility case, I can also just give these networks a "no one" edit policy, but still need to do the namespace locking.

Feb 21 2016, 7:04 PM · Almanac (v2), Security, Phacility
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Feb 21 2016, 7:02 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley closed T10205: Support browsing interface names in Almanac typehaead as Resolved by committing Restricted Diffusion Commit.
Feb 21 2016, 6:45 PM · Almanac (v2), Bug Report
epriestley added a revision to T10205: Support browsing interface names in Almanac typehaead: Unknown Object (Differential Revision).
Feb 21 2016, 11:25 AM · Almanac (v2), Bug Report
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Feb 21 2016, 11:25 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley moved T10246: Deploy Drydock in the Phacility cluster from Backlog to v2 on the Almanac board.
Feb 21 2016, 11:22 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a revision to T10205: Support browsing interface names in Almanac typehaead: Unknown Object (Differential Revision).
Feb 21 2016, 10:59 AM · Almanac (v2), Bug Report
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Feb 21 2016, 10:59 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added projects to T10246: Deploy Drydock in the Phacility cluster: Almanac, Harbormaster.
Feb 21 2016, 10:55 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
ProfFan awarded T7755: Improve reliability of real-time notification delivery a Like token.
Feb 21 2016, 9:31 AM · Conpherence
epriestley moved T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked from Backlog to v2 on the Almanac board.
Feb 21 2016, 1:05 AM · Almanac (v2), Security, Phacility
epriestley moved T9762: Removing devices from Almanac services from Backlog to v2 on the Almanac board.
Feb 21 2016, 1:05 AM · Almanac (v2)
epriestley moved T10205: Support browsing interface names in Almanac typehaead from Backlog to v2 on the Almanac board.
Feb 21 2016, 1:05 AM · Almanac (v2), Bug Report
epriestley created Almanac (v2).
Feb 21 2016, 1:05 AM
epriestley renamed T10205: Support browsing interface names in Almanac typehaead from "Add Binding" for an Almanac service does not auto-complete to Support browsing interface names in Almanac typehaead.
Feb 21 2016, 1:04 AM · Almanac (v2), Bug Report
epriestley added a comment to T10205: Support browsing interface names in Almanac typehaead.

From IRC, I think it sounded like this wasn't really a bug so much as a confusing UI (expecting to type one thing when the UI wants something different), exacerbated by the lack of "Browse" working. I'm just going to realign this to be "make browse work".

Feb 21 2016, 1:04 AM · Almanac (v2), Bug Report

Feb 20 2016

epriestley added a comment to T10264: git clone using http hangs after update.

I think this is now resolved for PHP 5.6 at HEAD of master.

Feb 20 2016, 10:58 PM · Bug Report, Diffusion
epriestley merged T10403: Unable to change default column in workboard into T5523: Make bulk moves easier on Workboards.
Feb 20 2016, 8:17 PM · Restricted Project, Workboards
epriestley merged task T10403: Unable to change default column in workboard into T5523: Make bulk moves easier on Workboards.
Feb 20 2016, 8:17 PM · Projects, Bug Report
epriestley added a comment to T10403: Unable to change default column in workboard.

I don't believe we've ever supported this.

Feb 20 2016, 8:14 PM · Projects, Bug Report
epriestley added a revision to T10264: git clone using http hangs after update: Unknown Object (Differential Revision).
Feb 20 2016, 7:55 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Never mind, that patch doesn't work.

Feb 20 2016, 7:44 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.
Edit: don't bother with this.
Feb 20 2016, 7:24 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Yeah, I'd like to avoid that "simple workaround" of 200 lines of spaghetti if I can, since I'd guess this task is going to go through 50 more rounds if I have to implement that.

Feb 20 2016, 4:52 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Alright, thanks. Both you and @ppggff have PHP 5.6, I'll see if I can reproduce with 5.6.

Feb 20 2016, 3:34 PM · Bug Report, Diffusion
epriestley moved T10240: Copy Comment from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:38 PM · Feature Request (Needs Information)
epriestley moved T10131: Wiki pages are not completely print friendly from Backlog to Future on the Feature Request board.
Feb 20 2016, 12:38 PM · Feature Request, Phriction
epriestley removed a project from T10324: Make Columns Draggable: Feature Request.
Feb 20 2016, 12:37 PM · Workboards (v3)
epriestley moved T10354: Remarkup block elements may not contain other block elements (like lists and tables inside tables) from Backlog to Far Future on the Feature Request board.
Feb 20 2016, 12:37 PM · Feature Request, Remarkup
epriestley moved T10365: Support passing generated annotation to ArcanistGeneratedLinter from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:37 PM · Feature Request (Needs Information), Lint
epriestley moved T10387: Create UI for visual (drag and drop) rearranging of task hierarchy from Backlog to Far Future on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request
epriestley moved T10392: Verify that VCS Password does not match LDAP Password from Backlog to Future on the Feature Request board.
Feb 20 2016, 12:36 PM · Auth, Feature Request
epriestley moved T10388: Additional remarkup assistance buttons for decriptions from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request (Needs Information), Design, Remarkup
epriestley moved T10395: Deploy SSH keys associated with a repository from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request (Needs Information), Diffusion
epriestley moved T10401: Set global Background Color for each Workboard from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request (Needs Information), Workboards
epriestley created Feature Request (Needs Information).
Feb 20 2016, 12:35 PM
epriestley added a comment to T10401: Set global Background Color for each Workboard.

Why do you want to set a global default background? What is the root problem you're currently encountering?

Feb 20 2016, 12:35 PM · Feature Request (Needs Information), Workboards
epriestley renamed T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it from notification websockerURI should use wss protocol when use nginx to Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.
Feb 20 2016, 12:33 PM · Setup
epriestley reopened T10264: git clone using http hangs after update as "Open".

@dpatou Do you have errors in your error log similar to the ones @ppggff describes?

Feb 20 2016, 12:32 PM · Bug Report, Diffusion
epriestley added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

So your client is sending an HTTPS request, but $request->isHTTPS() is false?

Feb 20 2016, 10:49 AM · Setup