Page MenuHomePhabricator
Feed Advanced Search

Oct 29 2015

epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

D14365 should fix that too, now. Landing in a sec...

Oct 29 2015, 12:13 AM · Restricted Project, Arcanist

Oct 28 2015

epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

Cool, that's an easy fix.

Oct 28 2015, 11:52 PM · Restricted Project, Arcanist
epriestley added a revision to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: Unknown Object (Differential Revision).
Oct 28 2015, 11:47 PM · Restricted Project, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

Ah, okay. If we put a no-op "--ff" in that command, does it overwrite the configuration option and work locally?

Oct 28 2015, 11:40 PM · Restricted Project, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

Let's look at your second one first since I think that's a little simpler. I can't immediately reproduce it. Here's what I did:

Oct 28 2015, 11:33 PM · Restricted Project, Arcanist
epriestley added a member for Blessed Committers: 20after4.
Oct 28 2015, 9:03 PM
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

I think that will fix things, let me know if you run into more cases.

Oct 28 2015, 9:02 PM · Arcanist
epriestley closed T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 9:01 PM · Arcanist
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

After D14361, the new behavior is so complicated that I don't think I can briefly explain it, but very roughly:

Oct 28 2015, 8:28 PM · Arcanist
joshuaspence added a comment to T182: Commit into repository directly from differential.

I can't remember which ticket, but I remember a similar discussion regarding arc patch (whether arc patch should patch onto HEAD or pull from the staging area).

Oct 28 2015, 7:45 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

This is just a big mess to resolve in the general case because we need to identify a path from whatever was landed to the remote, then cascade changes down along it, because there may be an arbitrary number of local branches between the target and the remote.

Oct 28 2015, 7:42 PM · Arcanist
epriestley added a comment to T182: Commit into repository directly from differential.

Yes, that's what this refers to:

Oct 28 2015, 7:39 PM · Haskell.org, Restricted Project, Differential
joshuaspence added a comment to T182: Commit into repository directly from differential.

Because this works from the staging repository, it will be possible to trick it right? I mean, I could do this to sneakily commit virus.exe to the repository:

Oct 28 2015, 7:38 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking: Unknown Object (Differential Revision).
Oct 28 2015, 7:37 PM · Arcanist
epriestley edited P1879 post140.remarkup.
Oct 28 2015, 6:57 PM
epriestley added a revision to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking: Unknown Object (Differential Revision).
Oct 28 2015, 6:38 PM · Arcanist
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

oh come on you're just making up new workflows at this point

Oct 28 2015, 6:02 PM · Arcanist
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 5:33 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

I'm planning to leave this open since it also contains a lot of discussion about Mercurial and none of the recent changes affect Mercurial (particularly, they do not resolve the branch/bookmark issues). Of relevance here:

Oct 28 2015, 5:23 PM · Restricted Project, Arcanist
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 5:18 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

(Let me know if I missed anything, and thanks for the report!)

Oct 28 2015, 5:11 PM · Arcanist
epriestley closed T9660: arc land does not delete landed branch when landing directly to remote as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 5:10 PM · Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

This does mean we can't distinguish between these cases:

Oct 28 2015, 5:10 PM · Arcanist
epriestley added a revision to T9660: arc land does not delete landed branch when landing directly to remote: Unknown Object (Differential Revision).
Oct 28 2015, 5:06 PM · Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

That does look like a bug, let me take a peek.

Oct 28 2015, 4:50 PM · Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

In your advanced workflow, you could sort of work around this by making sure your local branch always has a different name than the remote branch.

Oct 28 2015, 4:40 PM · Arcanist
epriestley closed T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 4:37 PM · Arcanist
epriestley closed T9658: arc land doesn't default --onto to a tracked branch if it is a remote as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 4:37 PM · Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

This behavior is intentional and I don't plan to change it.

Oct 28 2015, 4:33 PM · Arcanist
epriestley updated subscribers of T9132: Build an ApplicationEditor abstraction.
Oct 28 2015, 3:55 PM · Restricted Project, ApplicationEditor, Transactions
epriestley merged task T9659: Support custom field modification via "Weigh in" functionality in Maniphest into T9132: Build an ApplicationEditor abstraction.
Oct 28 2015, 3:55 PM · Maniphest, Custom Fields
epriestley added a comment to T9659: Support custom field modification via "Weigh in" functionality in Maniphest.

I'm going to merge this into T9132, as any pathway forward here runs through that.

Oct 28 2015, 3:54 PM · Maniphest, Custom Fields
epriestley added a revision to T9658: arc land doesn't default --onto to a tracked branch if it is a remote: Unknown Object (Differential Revision).
Oct 28 2015, 3:49 PM · Arcanist
epriestley added a comment to T9658: arc land doesn't default --onto to a tracked branch if it is a remote.

I think this is fixed by D14357, although I'm surprised by the original behavior. Here's what I get after D14357:

Oct 28 2015, 3:47 PM · Arcanist
epriestley added a comment to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.

D14357 fixes this. The new behavior is to recursively resolve upstreams until we:

Oct 28 2015, 3:40 PM · Arcanist
epriestley added a revision to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: Unknown Object (Differential Revision).
Oct 28 2015, 3:34 PM · Restricted Project, Arcanist
epriestley added a revision to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote: Restricted Differential Revision.
Oct 28 2015, 3:34 PM · Arcanist
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 2:11 PM · Installing & Upgrading, Arcanist
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 2:11 PM · Installing & Upgrading, Arcanist
epriestley created T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 2:10 PM · Installing & Upgrading, Arcanist
epriestley closed T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 2:05 PM · Arcanist
epriestley closed T8620: support landing from a detached head in git as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 2:05 PM · Arcanist
epriestley closed T9537: Support for landing without local tracking branch as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 2:05 PM · Arcanist
epriestley edited P1878 comment_snippet.sql.
Oct 28 2015, 1:57 PM
epriestley added a comment to T9652: Request for test case management application.

I think we will probably build such an application eventually, but I doubt we'll build it until 2017 at the earliest (i.e., it is at least a year away).

Oct 28 2015, 1:56 PM · Restricted Project, Unnamed Manual Test Case Application
epriestley added a comment to T3670: Add subprojects.

In general, see Planning / Paid Prioritization / Roadmap / Starmap.

Oct 28 2015, 1:48 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley added a comment to T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data.

In Git, after D14356, and ignoring any bugs, arc patch D123 && arc land should work (it should already have worked, just not preserved author metadata?).

Oct 28 2015, 1:16 PM · Arcanist
epriestley merged task T9653: Show a link to approval queue in unapproved user profile into T8029: make it possible to "approve" a user from the profile view.
Oct 28 2015, 12:30 PM · NUX
epriestley updated subscribers of T8029: make it possible to "approve" a user from the profile view.
Oct 28 2015, 12:30 PM · Auth, People
joshuaspence created T9655: Incorrect translation for differential revisions.
Oct 28 2015, 10:30 AM · Differential
epriestley added a comment to T9537: Support for landing without local tracking branch.

After D14356, we ignore the local branch (if it exists) until we've pushed.

Oct 28 2015, 2:32 AM · Arcanist
epriestley renamed T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote from Unable to 'arc land' a branch if the target local branch has a different name than the remote branch to In "arc land", recursively resolve tracking branches until we reach one in a remote.
Oct 28 2015, 2:30 AM · Arcanist
epriestley added a comment to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.

Oh, sorry, D14356 doesn't actually fix this.

Oct 28 2015, 2:30 AM · Arcanist
epriestley added a comment to T8620: support landing from a detached head in git.

This should work after D14356.

Oct 28 2015, 2:28 AM · Arcanist
epriestley added a comment to T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data.

After D14356, arc land will preserve authorship and author date data. Since arc patch also preserves them, the net effect should be preserved authors.

Oct 28 2015, 2:26 AM · Arcanist
epriestley added a revision to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: Unknown Object (Differential Revision).
Oct 28 2015, 2:14 AM · Restricted Project, Arcanist
epriestley added a revision to T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data: Unknown Object (Differential Revision).
Oct 28 2015, 2:14 AM · Arcanist
epriestley added a revision to T9537: Support for landing without local tracking branch: Unknown Object (Differential Revision).
Oct 28 2015, 2:13 AM · Arcanist
epriestley added a revision to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote: Unknown Object (Differential Revision).
Oct 28 2015, 2:13 AM · Arcanist
epriestley added a revision to T8620: support landing from a detached head in git: Unknown Object (Differential Revision).
Oct 28 2015, 2:13 AM · Arcanist
epriestley closed T6728: `arc land` should update log message as Invalid.

No clue how to repro, no reports in nearly a year.

Oct 28 2015, 2:04 AM · Arcanist
epriestley merged T9649: Show project tags on workboards into T4863: Allow Workboard Cards to be customized for display.
Oct 28 2015, 12:32 AM · Projects, Workboards, Wikimedia
epriestley merged task T9649: Show project tags on workboards into T4863: Allow Workboard Cards to be customized for display.
Oct 28 2015, 12:32 AM · Workboards

Oct 27 2015

joshuaspence created T9650: View task dependencies as a graph.
Oct 27 2015, 10:30 PM · Maniphest
joshuaspence updated the task description for T9649: Show project tags on workboards.
Oct 27 2015, 10:20 PM · Workboards
joshuaspence created T9649: Show project tags on workboards.
Oct 27 2015, 10:19 PM · Workboards
epriestley claimed T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Oct 27 2015, 10:17 PM · Restricted Project, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

About an hour.

Oct 27 2015, 10:15 PM · Restricted Project, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

Yes: move it into the "Contract Fix" column on the Dropbox workboard.

Oct 27 2015, 10:09 PM · Restricted Project, Arcanist
joshuaspence added a comment to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.

For now, I just asked him to change the policy to a custom policy consisting of users X, Y, Z.

Oct 27 2015, 10:01 PM · Policy, Differential
joshuaspence added a comment to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.

Can you see the repository? (PHID-REPO-rgnn364lembo2emt5622)?

Oct 27 2015, 10:01 PM · Policy, Differential
epriestley closed T9252: Unprototype Drydock (v1) as Resolved.

I'm going to close this out as I think we're generally in good shape here and we're now hosting builds and doing server-side lands in the upstream, and don't anticipate much more Drydock-specific work in this iteration.

Oct 27 2015, 9:54 PM · Prioritized, Drydock
epriestley closed T9252: Unprototype Drydock (v1), a subtask of T182: Commit into repository directly from differential, as Resolved.
Oct 27 2015, 9:54 PM · Haskell.org, Restricted Project, Differential
epriestley closed T9252: Unprototype Drydock (v1), a subtask of T9123: Build Phabricator in Harbormaster (v2), as Resolved.
Oct 27 2015, 9:54 PM · Prioritized, Harbormaster
epriestley added a comment to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.

Can you see the repository? (PHID-REPO-rgnn364lembo2emt5622)?

Oct 27 2015, 9:47 PM · Policy, Differential
joshuaspence added a comment to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.
mysql> SELECT * FROM phabricator_differential.edge WHERE src IN ('PHID-DREV-bdeb6h6c4yj32nqfnz7y', 'PHID-DIFF-czvpmjpj23wtl2th2h6a');
+--------------------------------+------+--------------------------------+-------------+-----+--------+
| src                            | type | dst                            | dateCreated | seq | dataID |
+--------------------------------+------+--------------------------------+-------------+-----+--------+
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   12 | PHID-TASK-shfyd2sba6htlrzybqp5 |  1445973949 |   0 |   NULL |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   21 | PHID-USER-abzwhc667osh5mwd4gk7 |  1445981511 |   2 |   NULL |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   21 | PHID-USER-inwz7rtaiuxgmjduhmmq |  1445981511 |   1 |   NULL |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   21 | PHID-USER-mw6ockgrrgytq3d3yywa |  1445981511 |   0 |   NULL |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   35 | PHID-USER-abzwhc667osh5mwd4gk7 |  1445973949 |   2 | 104425 |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   35 | PHID-USER-inwz7rtaiuxgmjduhmmq |  1445973949 |   1 | 104424 |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   35 | PHID-USER-mw6ockgrrgytq3d3yywa |  1445973949 |   0 | 104423 |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   51 | PHID-TASK-shfyd2sba6htlrzybqp5 |  1445974513 |   0 |   NULL |
+--------------------------------+------+--------------------------------+-------------+-----+--------+
Oct 27 2015, 9:43 PM · Policy, Differential
joshuaspence added a comment to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.
mysql> SELECT id, phid, status, authorPHID, lastReviewerPHID, dateCreated, dateModified, attached, viewPolicy, editPolicy, repositoryPHID FROM phabricator_differential.differential_revision WHERE id = 27030;
+-------+--------------------------------+--------+--------------------------------+------------------+-------------+--------------+----------+-------------------------------+-------------------------------+--------------------------------+
| id    | phid                           | status | authorPHID                     | lastReviewerPHID | dateCreated | dateModified | attached | viewPolicy                    | editPolicy                    | repositoryPHID                 |
+-------+--------------------------------+--------+--------------------------------+------------------+-------------+--------------+----------+-------------------------------+-------------------------------+--------------------------------+
| 27030 | PHID-DREV-bdeb6h6c4yj32nqfnz7y | 0      | PHID-USER-hfenohlvucsbthy2su73 | NULL             |  1445973949 |   1445982060 | []       | obj.subscriptions.subscribers | obj.subscriptions.subscribers | PHID-REPO-rgnn364lembo2emt5622 |
+-------+--------------------------------+--------+--------------------------------+------------------+-------------+--------------+----------+-------------------------------+-------------------------------+--------------------------------+
1 row in set (0.00 sec)
Oct 27 2015, 9:42 PM · Policy, Differential
joshuaspence updated the task description for T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.
Oct 27 2015, 9:35 PM · Policy, Differential
joshuaspence added a project to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context: Differential.
Oct 27 2015, 9:34 PM · Policy, Differential
joshuaspence added a comment to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.

OK, I have asked the author to add me as a subscriber... but I still can't load the page.

Oct 27 2015, 9:34 PM · Policy, Differential
joshuaspence added a comment to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.

I received an email regarding the revision:

Oct 27 2015, 9:34 PM · Policy, Differential
joshuaspence created T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.
Oct 27 2015, 9:33 PM · Policy, Differential
epriestley added a comment to T182: Commit into repository directly from differential.

This is in reasonably functional shape for ambitious users. There's some documentation now:

Oct 27 2015, 9:08 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9643: XHPast Parse error when extracting i18n.

Probably not, but it seems vaguely nice that i18n extract doesn't need to know anything about the directory structure, and that we can put pht() in externals/ as a local patch if we need to clarify some error or something.

Oct 27 2015, 9:07 PM · XHPAST
joshuaspence added a comment to T9643: XHPast Parse error when extracting i18n.

Is there any real news to extract translations from externals/?

Oct 27 2015, 9:04 PM · XHPAST
joshuaspence updated Q198: Is there a way to change the config without `./bin/config`? from Is there a way to change the config without ./bin/config? to Is there a way to change the config without `./bin/config`?.
Oct 27 2015, 8:36 PM · Config
joshuaspence added a project to Q198: Is there a way to change the config without `./bin/config`?: Config.
Oct 27 2015, 8:34 PM · Config
epriestley added a comment to T9377: Image lightbox perceived slow due to always creating new urls.

@Krinkle: I can't come up with a reasonable way to fix the height=300 comment preview case unless we render the element entirely on the client or relax the WMF constraints. I think the WMF constraints are excessively paranoid, but it's moot since you're the only person complaining about this and you're on the WMF install, so adding a "[X] Use less paranoid caching that doesn't flicker all the time." option wouldn't fix the problem for you.

Oct 27 2015, 8:21 PM · Files, Wikimedia
joshuaspence added a comment to T9377: Image lightbox perceived slow due to always creating new urls.

Ah OK... I can't rememberif I had set a height when I observed this behavior.

Oct 27 2015, 8:04 PM · Files, Wikimedia
epriestley added a comment to T9377: Image lightbox perceived slow due to always creating new urls.
  • With height=300, yeah, it's going to be a flickery mess.
    • Without height=300, it's a flickery mess in Safari only, in the last few weeks, as far as I can tell.
Oct 27 2015, 8:01 PM · Files, Wikimedia
joshuaspence added a comment to T9377: Image lightbox perceived slow due to always creating new urls.

I'm fairly sure that I've observed that behavior in Chrome.

Oct 27 2015, 7:59 PM · Files, Wikimedia
epriestley added a comment to T9377: Image lightbox perceived slow due to always creating new urls.

I'm pretty sure the preview case is recent (last couple weeks) and I don't think we changed anything, but I haven't hunted down what actually did change. My theory was that it was a change in Safari behavior, since I don't see this behavior in Chrome and I first observed it after applying an OSX update. Are you using Safari in OSX?

Oct 27 2015, 7:56 PM · Files, Wikimedia
joshuaspence added a comment to T9642: Unable to download images on Android.

Yeah, I'm on Android 6 and it seems to happen consistently. Yes, as far as I know Chrome on Android hands off downloads to the "Downloads" application. Steps to reproduce are basically:

Oct 27 2015, 7:55 PM · Android, Files
epriestley edited projects for T9646: Duplicates commits after doing git reset, added: Diffusion; removed Public & Media Relations.
Oct 27 2015, 7:29 PM · Diffusion
epriestley closed T9646: Duplicates commits after doing git reset as Wontfix.

Some discussion in, e.g, T9028, but we don't plan to ever actually delete these commits. They may have comments, audit status, meaningful relationships to other objects, builds, build artifacts, etc.

Oct 27 2015, 7:29 PM · Diffusion
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 27 2015, 5:25 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 27 2015, 5:08 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Oct 27 2015, 5:08 PM · Prioritized, Drydock
epriestley triaged T9643: XHPast Parse error when extracting i18n as Wishlist priority.
Oct 27 2015, 4:47 PM · XHPAST
epriestley added a comment to T9643: XHPast Parse error when extracting i18n.

This is because externals/stripe-php/lib/Stripe/ApiRequestor.php has this on line 357:

Oct 27 2015, 4:47 PM · XHPAST