Page MenuHomePhabricator

make it possible to "approve" a user from the profile view
Closed, ResolvedPublic

Description

When users are created, but need approval, right now the only flow via which they can be approved is to look at the approval queue. There should be an "Approve User" link on the right hand side where "make administrator" or "disable user" is.

Event Timeline

eadler raised the priority of this task from to Needs Triage.
eadler updated the task description. (Show Details)
eadler added projects: People, Auth.
eadler added a subscriber: eadler.

I don't personally want to add additional action links unless absolutely needed, it devalues the links that already exist there and if we can find another way to link to admin actions, I'd prefer to do that.

It's significantly more helpful for us if you could describe your problem, your workflow, etc, and allow us to determine the best course of action to resolving this. It may be the same idea you have, or it may be completely different. Without knowing the specifics of your problem, we might not correctly solve or we may even have a better way to solve it.

https://secure.phabricator.com/book/phabcontrib/article/feature_requests/#describe-problems

So there are two workflows which are annnoying, and one general UI issue.

  1. I might get a link to a user out of band and be asked to approve this specific user
  2. I might click on a user to see more details (to make sure it isn't spam, etc.) from the approval queue, but then I need to go back to approve the user.

Finally, the general UI issue is that the approve/reject buttons are non-obvious and in a grey color. It took me a little bit to notice they exist. The most prominent thing to do inside the approval queue is click on the username link.

The key is that in all these cases I end up on the user detail page, away from the approval queue. I'd like to be able to approve users from that page instead of having to go back to the queue, find the right user again, and then hit approve.

I'd rather, UI-wise, have a big banner at the top of the user, with a button to just approve them. It seems like if a user in unapproved, that's the quickest solution, and it's then easier to find than picking out a link in the action menu.

I'd probably also add a link to the new user in the admin approval email. Right now we don't give you much information in those emails, so seems nice to improve those as well.

A big banner is totally fine by me. I just proposed an action menu item since it seems simpler.

I have not seen the admin approval email since we disabled email sending on the test instance, but having a direct link to approve users would be very helpful as well.

Are these tasks for a real instance or a test instance? That is, are these theoretical issues or "omg i hate doing this every day" issues against a production install?

This particular issue is something I'm running into on the test install, before enabling it in production.

If I enabled admin approval (and general registration) in production I know it would turn into a "omg i hate doing this every day" problem so I'm trying head it off before that occurs.

Other tasks are directly from production.

fwiw, as expected, this is an issue on prod

eadler moved this task from Backlog to Nits on the FreeBSD board.