When using phabricator and arc on our team we usually end up updating the title and summary sections of the diff a couple times in the web UI. This is not reflected in the landed commit when using arc land. It would be nice if arc land updated the commit message with all the most up to date information from phabricator. Right now it seems like it only appends the users who approved.
Description
Description
Event Timeline
Comment Actions
From my experience, the commit message is updated. I'm not sure why this wouldn't be happening for you.
Comment Actions
I just observed an isolated occurrence of this. On the same setup, and on the same day, it's worked correctly every time except once.
Here's the shell output from when it happened, with some junk removed:
$ arc land Landing current branch 'my-feature'. You have untracked files in this working copy. Working copy: d:\users\me\... Untracked files in working copy: ... Since you don't have '.gitignore' rules for these files and have not listed them in '.git/info/exclude', you may have forgotten to 'git add' them to your commit. Do you want to amend these files to the commit? [y/N] n Switched to branch master. Updating branch... The following commit(s) will be landed: d49b5af OLD DIFF TITLE Switched to branch my-feature. Identifying and merging... Landing revision 'D172: OLD DIFF TITLE'... Merging my-feature into master Already up-to-date. You have untracked files in this working copy. Working copy: d:\users\me\... Untracked files in working copy: ... Since you don't have '.gitignore' rules for these files and have not listed them in '.git/info/exclude', you may have forgotten to 'git add' them to your commit. Do you want to amend these files to the commit? [y/N] n Pushing change... Counting objects: 22, done. Delta compression using up to 8 threads. Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 1.06 KiB | 0 bytes/s, done. Total 7 (delta 6), reused 0 (delta 0) To ssh://git@phabricator.our-server.com/project-path/... 661e69a..3559eb4 master -> master Cleaning up feature branch... (Use `git checkout -b "my-feature" "d49b5af77c0392ffe5ca1d07ec77159804cccb39"` if you want it back.) Done.
The environment was git bash.
We modified the title of the diff via the differential web UI, and then landed it shortly after that. Were expecting "NEW DIFF TITLE", instead it landed with "OLD DIFF TITLE".
Comment Actions
Here's what the transaction history looked like on the corresponding diff:
xyz retitled this revision from "OLD DIFF TITLE" to "NEW DIFF TITLE". Via Web · Fri, Jan 2, 4:29 PM Closed by commit rS3559eb473890: OLD DIFF TITLE (authored by xyz). · Explain Why Via Daemons · Fri, Jan 2, 4:37 PM This revision was automatically updated to reflect the committed changes.