Page MenuHomePhabricator
Feed Advanced Search

Nov 3 2015

epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Restricted Differential Revision.
Nov 3 2015, 2:41 PM · Restricted Project, ApplicationEditor, Transactions
epriestley closed T9700: Change maniphest tasks depending on project memberships. as Invalid.

https://secure.phabricator.com/book/phabcontrib/article/feature_requests/

Nov 3 2015, 2:36 PM · Herald
epriestley added a comment to T9698: Allow bots to have email addresses assigned to them.

Does committing as botusername <anything@anything> definitely not work?

Nov 3 2015, 10:52 AM · Drydock, People, Diffusion
joshuaspence added projects to T9698: Allow bots to have email addresses assigned to them: People, Drydock.
Nov 3 2015, 8:11 AM · Drydock, People, Diffusion
epriestley added a comment to T4768: Phabricator silently overwrites concurrent changes (no conflict detection).

D14390 introduces "ApplicationEditor", which includes more race-resistant controls for editing things like projects and subscribers. In effect, this should merge edits of these fields correctly in all cases where there are no conflicts. Here's an example:

Nov 3 2015, 4:08 AM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley added a revision to T4768: Phabricator silently overwrites concurrent changes (no conflict detection): Restricted Differential Revision.
Nov 3 2015, 3:59 AM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Restricted Differential Revision.
Nov 3 2015, 3:59 AM · Restricted Project, ApplicationEditor, Transactions
epriestley closed T9695: Have the ability to have an interstitial page for outbound Phurl links. as Wontfix.

I think this is exceedingly mild/theoretical.

Nov 3 2015, 3:54 AM · Phurl
epriestley added a project to T4768: Phabricator silently overwrites concurrent changes (no conflict detection): ApplicationEditor.
Nov 3 2015, 3:39 AM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley added a comment to T9695: Have the ability to have an interstitial page for outbound Phurl links..

Can you give me a specific scenario where this would be useful?

Nov 3 2015, 3:32 AM · Phurl
epriestley closed T9696: /paste/ fails to load as Resolved.

Upgrade to fe7d8c2.

Nov 3 2015, 12:55 AM · Paste, Restricted Project

Nov 2 2015

epriestley added a comment to T9693: Better breadcrumb navigation.

This same problem exists elsewhere throughout the app.

Nov 2 2015, 10:37 PM
epriestley added members for Community: avivey, lpriestley, hach-que.
Nov 2 2015, 10:01 PM
epriestley changed the edit policy for Phurl.
Nov 2 2015, 10:00 PM
epriestley added a comment to T5307: UX for taking actions with search results.

@chad, do you have any general ideas on what this might look like offhand? It would be good to get a rough first iteration of a direction while I'm tackling ApplicationEditor since all the "generic batch editor" stuff will happen at some point in that process.

Nov 2 2015, 9:23 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley added a project to T5307: UX for taking actions with search results: ApplicationEditor.
Nov 2 2015, 9:12 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley added a comment to T9690: Remove calls to methods deprecated by newPage().

Let me get a little further with ApplicationEditor and throw a couple of reference diffs up here before anyone goes crazy with this, since I might still need to change some APIs.

Nov 2 2015, 9:11 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley added a comment to T9689: unit test failure when auth.email-domains is configured.

To reproduce:

Nov 2 2015, 8:55 PM
epriestley assigned T9689: unit test failure when auth.email-domains is configured to lpriestley.
Nov 2 2015, 8:53 PM
epriestley added a revision to T9690: Remove calls to methods deprecated by newPage(): Unknown Object (Differential Revision).
Nov 2 2015, 8:52 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley created T9690: Remove calls to methods deprecated by newPage().
Nov 2 2015, 8:32 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley added a revision to T5752: Navigation menus should work correctly on mobile by default: Unknown Object (Differential Revision).
Nov 2 2015, 8:20 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
joshuaspence closed T9625: Fill in missing applications and icons on PHID types as Resolved by committing Restricted Diffusion Commit.
Nov 2 2015, 7:47 PM · Applications
epriestley added a comment to T5752: Navigation menus should work correctly on mobile by default.

Actually I guess (2) already got pretty much fixed in D11340.

Nov 2 2015, 6:14 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley added a comment to T5752: Navigation menus should work correctly on mobile by default.

There are broadly two issues here:

Nov 2 2015, 6:12 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley claimed T5752: Navigation menus should work correctly on mobile by default.
Nov 2 2015, 6:10 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley added a comment to T9132: Build an ApplicationEditor abstraction.

I'm hoping to get this underway in the short term. Before ApplicationEditor actually gets written, we have a longstanding mess in how navigation menus and actions work with the existing ApplicationSearch stuff, roughly captured in T5752.

Nov 2 2015, 6:09 PM · Restricted Project, ApplicationEditor, Transactions
epriestley moved T5752: Navigation menus should work correctly on mobile by default from Backlog to v1 on the ApplicationEditor board.
Nov 2 2015, 6:06 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley moved T9132: Build an ApplicationEditor abstraction from Backlog to v1 on the ApplicationEditor board.
Nov 2 2015, 6:06 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a project to T5752: Navigation menus should work correctly on mobile by default: ApplicationEditor.
Nov 2 2015, 6:05 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley added a project to T9132: Build an ApplicationEditor abstraction: ApplicationEditor.
Nov 2 2015, 6:04 PM · Restricted Project, ApplicationEditor, Transactions
epriestley set the image for ApplicationEditor to F936803: profile.
Nov 2 2015, 6:03 PM
epriestley set the color for ApplicationEditor to Blue.
Nov 2 2015, 6:03 PM
epriestley created ApplicationEditor.
Nov 2 2015, 6:03 PM
epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

Thanks for testing the patch, should be in HEAD now. Let us know if you run into anything else.

Nov 2 2015, 4:22 PM · Elasticsearch
epriestley closed T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0 as Resolved by committing Restricted Diffusion Commit.
Nov 2 2015, 4:21 PM · Elasticsearch
epriestley added a comment to T9688: Option to show Real Name instead of username.

Oh, sorry, T2950 was itself merged into T3167. Upshot is that we don't plan to change this in the upstream. See also T8227. I think there's a patch on one of those tasks to hack this in locally, but it will be messy/incomplete.

Nov 2 2015, 4:14 PM
epriestley merged task T9688: Option to show Real Name instead of username into T2950: Possibility to display the RealName instead of the UserName.
Nov 2 2015, 4:12 PM
epriestley updated subscribers of T2950: Possibility to display the RealName instead of the UserName.
Nov 2 2015, 4:12 PM · Differential
epriestley added a comment to T9684: AphrontSchemaQueryException #1054: Unknown column 'task.spacePHID' in 'where clause'.

Can you walk me through what commands you used to do your dump/restore? I can't reproduce this problem, and we routinely dump and restore instances in the Phacility cluster.

Nov 2 2015, 1:56 PM · Aphront
epriestley closed T9685: test as Spite.
Nov 2 2015, 1:55 PM · Space Test Users
epriestley added a revision to T9625: Fill in missing applications and icons on PHID types: Unknown Object (Differential Revision).
Nov 2 2015, 1:03 PM · Applications
joshuaspence closed T9289: Unable to build XHPAST as Resolved by committing Restricted Diffusion Commit.
Nov 2 2015, 8:52 AM · XHPAST
Mnkras awarded T9683: Support `@throws` annotation a Piece of Eight token.
Nov 2 2015, 2:14 AM · Diviner
joshuaspence created T9683: Support `@throws` annotation.
Nov 2 2015, 1:57 AM · Diviner

Nov 1 2015

• mholden awarded T5891: Add button to notification panel to concatenate notifications on the same objects a Love token.
Nov 1 2015, 9:43 PM · Notifications
joshuaspence added a revision to T9289: Unable to build XHPAST: Unknown Object (Differential Revision).
Nov 1 2015, 8:59 PM · XHPAST
joshuaspence added a revision to T9655: Incorrect translation for differential revisions: Unknown Object (Differential Revision).
Nov 1 2015, 8:34 PM · Differential
joshuaspence added a comment to T9677: Difficulty debugging sudo permissions.
GIT_CURL_VERBOSE=1 git clone http://phabricator.local/diffusion/TEST/test.git
Cloning into 'test'...
* Couldn't find host phabricator.local in the .netrc file; using defaults
* Hostname was NOT found in DNS cache
*   Trying 10.0.0.100...
* Connected to phabricator.local (10.0.0.100) port 80 (#0)
> GET /diffusion/TEST/test.git/info/refs?service=git-upload-pack HTTP/1.1
User-Agent: git/2.5.0
Host: phabricator.local
Accept: */*
Accept-Encoding: gzip
Accept-Language: en-US, en;q=0.9, *;q=0.8
Pragma: no-cache
Nov 1 2015, 8:33 PM · Diffusion
joshuaspence renamed T9677: Difficulty debugging sudo permissions from Difficultly debugging sudo permissions to Difficulty debugging sudo permissions.
Nov 1 2015, 8:28 PM · Diffusion
joshuaspence created T9682: Phriction emails are not formatted.
Nov 1 2015, 8:23 PM · Phriction
joshuaspence edited the content of 2015 Week 44 (Very Late October).
Nov 1 2015, 8:19 PM
tycho.tatitscheff awarded T5891: Add button to notification panel to concatenate notifications on the same objects a Love token.
Nov 1 2015, 5:58 PM · Notifications
epriestley edited the content of Changelog.
Nov 1 2015, 1:31 PM
epriestley created 2015 Week 44 (Very Late October).
Nov 1 2015, 1:29 PM
epriestley closed T9676: Triangle workflows (pushing to a merge manager) as Wontfix.

The upstream pathway for this lies beyond T182.

Nov 1 2015, 12:12 PM · Restricted Project

Oct 31 2015

joshuaspence created T9678: "Argument 1 passed to AphrontView::setUser() must be an instance of PhabricatorUser, null given" on cloning a repository.
Oct 31 2015, 5:28 AM · Diffusion
joshuaspence created T9677: Difficulty debugging sudo permissions.
Oct 31 2015, 5:21 AM · Diffusion
joshuaspence added a project to Q203: How do I embed YouTube videos?: Remarkup.
Oct 31 2015, 12:45 AM · Remarkup
joshuaspence added a comment to Q203: How do I embed YouTube videos?.

PEBKAC... I forgot to save my changes to local.json.

Oct 31 2015, 12:45 AM · Remarkup
joshuaspence closed Q203: How do I embed YouTube videos? as invalid.
Oct 31 2015, 12:43 AM · Remarkup
joshuaspence updated the question details for Q203: How do I embed YouTube videos?.
Oct 31 2015, 12:41 AM · Remarkup
joshuaspence updated Q203: How do I embed YouTube videos? from to How do I embed YouTube videos?.
Oct 31 2015, 12:40 AM · Remarkup

Oct 30 2015

joshuaspence edited P1881 local.json.
Oct 30 2015, 11:44 PM
epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

Oh, I think I misremembered and it does foreground by default. You can use --background to improve performance, and monitor from /daemon/.

Oct 30 2015, 5:03 PM · Elasticsearch
epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

Note that index --all queues stuff into the background, so you may need to wait a while before it finishes. You can use --foreground (slower) or monitor progress from /daemon/ in the web UI.

Oct 30 2015, 5:03 PM · Elasticsearch
epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

D14370 likely fixes this, although I don't have ElasticSearch 2.0 locally and haven't tested it. I'd guess this will give you a clean bill of health:

Oct 30 2015, 5:02 PM · Elasticsearch
epriestley added a revision to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0: Unknown Object (Differential Revision).
Oct 30 2015, 5:00 PM · Elasticsearch
epriestley added a comment to T9665: my remote git repository Initializing Working Copy a long time.

Can you show me the output of this command?

Oct 30 2015, 4:57 PM · Diffusion
epriestley added a comment to T182: Commit into repository directly from differential.

I think the discussion is in T8090.

Oct 30 2015, 4:55 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9672: Make it possible to modify or disable differential's "next step" property.

I think that should clear the way for you, let me know if you hit issues.

Oct 30 2015, 4:23 PM · Custom Fields, Differential
epriestley closed T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository as Resolved by committing Restricted Diffusion Commit.
Oct 30 2015, 4:02 PM · Harbormaster, Drydock
epriestley closed T9672: Make it possible to modify or disable differential's "next step" property as Resolved by committing Restricted Diffusion Commit.
Oct 30 2015, 4:00 PM · Custom Fields, Differential
epriestley closed T9674: "Authorized By" links to a 404 as Resolved by committing Restricted Diffusion Commit.
Oct 30 2015, 3:54 PM · Drydock, Harbormaster
epriestley added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

D14368 should fix the issue where you're required to set a dummy "Also Clone" repository.

Oct 30 2015, 3:02 PM · Harbormaster, Drydock
epriestley added a revision to T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository: Unknown Object (Differential Revision).
Oct 30 2015, 3:01 PM · Harbormaster, Drydock
epriestley triaged T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository as Normal priority.
Oct 30 2015, 2:53 PM · Harbormaster, Drydock
epriestley added a revision to T9672: Make it possible to modify or disable differential's "next step" property: Unknown Object (Differential Revision).
Oct 30 2015, 2:47 PM · Custom Fields, Differential
epriestley claimed T9672: Make it possible to modify or disable differential's "next step" property.
Oct 30 2015, 2:47 PM · Custom Fields, Differential
epriestley added a revision to T9674: "Authorized By" links to a 404: Unknown Object (Differential Revision).
Oct 30 2015, 2:35 PM · Drydock, Harbormaster
epriestley claimed T9674: "Authorized By" links to a 404.
Oct 30 2015, 2:32 PM · Drydock, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Yeah -- that make sense, I'm just want to be mindful of how much complexity we're adding to the upstream in order to subvert barriers that have no technical reason to exist.

Oct 30 2015, 2:02 PM · Restricted Project, Harbormaster
epriestley added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

"Lease Host" is not currently expected to work at all. It hasn't been updated for any of the changes, including authorizations. "Lease Working Copy" (under "Drydock") should.

Oct 30 2015, 1:51 PM · Harbormaster, Drydock
exp10r3r awarded T7924: Unprototype Calendar (v1) a Mountain of Wealth token.
Oct 30 2015, 1:22 PM · Restricted Project, Prioritized, Calendar
joshuaspence added a project to T5998: What permissions and access is required for a user created just to run the phabricator daemons?: Daemons.
Oct 30 2015, 10:12 AM · Daemons
joshuaspence updated the task description for T9671: Harbormaster builds and Drydock leases are stuck.
Oct 30 2015, 9:55 AM · Harbormaster, Drydock
joshuaspence added a comment to T9674: "Authorized By" links to a 404.

(Yes, I know that Drydock is a prototype... But I figured it's better to file an issue that will be closed as invalid than to not file one at all?)

Oct 30 2015, 9:54 AM · Drydock, Harbormaster
joshuaspence created T9674: "Authorized By" links to a 404.
Oct 30 2015, 6:55 AM · Drydock, Harbormaster
joshuaspence created T9673: Argument 1 passed to DrydockLease::setAllowedBlueprintPHIDs() must be of the type array, null given.
Oct 30 2015, 6:24 AM

Oct 29 2015

epriestley added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

Drydock is a prototype and all of the Harbormaster build steps which interact with it are prototypes. Much of this code has been substantially rewritten in the last two weeks. See:

Oct 29 2015, 9:10 PM · Harbormaster, Drydock
epriestley edited the content of Planning.
Oct 29 2015, 7:19 PM
epriestley edited the content of Planning.
Oct 29 2015, 7:16 PM
epriestley edited the content of Planning.
Oct 29 2015, 7:08 PM
epriestley added a comment to T9657: Upgrading: arc land flow has been rewritten in git.

If you do this:

Oct 29 2015, 6:56 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9657: Upgrading: arc land flow has been rewritten in git.

Can you show me this?

Oct 29 2015, 6:40 PM · Installing & Upgrading, Arcanist
tycho.tatitscheff awarded T9657: Upgrading: arc land flow has been rewritten in git a Evil Spooky Haunted Tree token.
Oct 29 2015, 5:42 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

FWIW this would be useful in repositories where users can push branches (and maybe only to certain regex-matching branch names) and not tags.

Oct 29 2015, 4:57 PM · Restricted Project, Harbormaster
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 29 2015, 4:31 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

There was one more followup in T3855 to fix a couple of bugs, but if you updated this morning you probably picked that up.

Oct 29 2015, 4:28 PM · Arcanist
joshuaspence created T9664: Inherit documentation for built-in classes.
Oct 29 2015, 3:09 AM · Diviner