Oh, sorry -- after looking at it a little more, you certainly have that patch. I'll take a look at this, thanks.

Do you have rARCe5946ed?

In T9254#133768, @epriestley wrote:

It seems sort-of-nice-to-have to have the raw version, maybe.

Not sure if it would be desirable but perhaps Arcanist would override libphutil's --xprofile and wrap around it to provide the suggested functionality? This is probably too magical. arc --upload-xprofile seems reasonable.

I think --xprofile is provided by libphutil but it doesn't know about Phabricator. It seems sort-of-nice-to-have to have the raw version, maybe. Not sure how easy it is to add --upload-xprofile to arc.

I don't remember the last edge -> object conversion we did, I don't think we've done one for a while.

Thanks, good explanation.

Edges have a data field, but you can't put keys on any of the data since it's just stored as a JSON blob. For example, it would be possible to store an awarderPHID in the data, but then as soon as you want to show a view of "all badges given by epriestley to other users" you can't query by it (since you'd have to load every edge, then deserialize all their JSON data, then look through it).

Feel free to ignore me if you don't have the time to explain, but what's the difference between an edge and an object. More specifically, why do we want badges to be objects rather than edges?

This task made for a good read.

Yeah I would appreciate a shortcut to downloading files at times. Often I will attach some sort of binary file to a task, and when I want to download it I would see benefit in doing this directly from the task without clicking through to the file.

Since we're pushing everything to staging, I expect that to be covered here.

Pretty sure this is the same as T6076; I'm going to merge that here.

I think a setup warning is reasonable, particularly given that this looks like at least partially a PHP upstream configuration issue (not just one user running some weird custom-built PHP extension they wrote or whatever).

See also T9223, which sort of leads toward an arc build + .arcbuild or some equivalent too.

What does Badge Awarded mean?

Interesting idea, I haven't really considered Arcanist integrations for compiled languages.

Yeah OK. I think this falls into T5568 then, which should cover pas song flags to the underlying tools.

What are build properties exactly? Is this just passing command line flags to the underlying binary?

I'm happy to take a crack at this, but I'm not sure what the desired behavior is... Silently drop notifications to users that don't have the correct permissions? Filter the list of users to notify before triggering notifications?

I'd actually like this functionality in other places such as Maniphest. That is, I'd like a stronger notification if I am mentioned on an object that I am subscribed to rather than just a plain comment which doesn't contain a mention.

Nuance currently allows an Item to be in multiple Queues, but I think we don't need to allow this and can simplify things a bit by putting items in exactly one queue at all times.

Closing for lack of feedback.

Yeah, likely just a didRejectResult() issue.

Some stuff like T7580 might be nice to have, but I don't think we have any real blockers here.

le IRC gem

Is this going to include the ability to build (i.e. lint and test) diffs as well, or is that part of v3?