Page MenuHomePhabricator
Create Task
Maniphest T9036

Add support for build properties in XUnitTestEngine
Closed, DuplicatePublic
Actions

Description

XUnitTestEngine does not let one include build properties. This makes some scenarios impossible.

It would be great to have a unit.csharp.xunit.properties.

Related Objects

Event Timeline

igorgatis created this task.Aug 1 2015, 12:28 AM
igorgatis raised the priority of this task from to Needs Triage.
igorgatis updated the task description. (Show Details)
igorgatis added a subscriber: igorgatis.
chad added a project: Arcanist.Aug 3 2015, 4:50 PM
joshuaspence added a subscriber: joshuaspence.Aug 23 2015, 10:11 PM

What are build properties exactly? Is this just passing command line flags to the underlying binary?

hach-que added a subscriber: hach-que.Aug 24 2015, 2:51 AM

Yeah, it involves passing /p:Key=Value to MSBuild. It'll be extremely difficult to get right because of Windows escaping rules though.

hach-que added a comment.Aug 24 2015, 2:53 AM

The other thing is that /p:SkipTestsOnBuild=True is already passed in, so the build scripts can already detect if they're being run as part of arc unit anyway. You could just configure your MSBuild scripts to have something like this to solve the problem:

<PropertyGroup Condition="$(SkipTestsOnBuild) == 'True'">
  <Key>Value</Key>
</PropertyGroup>
hach-que mentioned this in T5568: Support `.arcunit`, similar to `.arclint`.Aug 24 2015, 3:07 AM
joshuaspence added a comment.Aug 24 2015, 4:13 AM

Yeah OK. I think this falls into T5568 then, which should cover pas song flags to the underlying tools.

joshuaspence closed this task as a duplicate of T5568: Support `.arcunit`, similar to `.arclint`.Aug 24 2015, 4:14 AM
Phabricator · Built by Phacility