Page MenuHomePhabricator
Feed Advanced Search

Mar 18 2019

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Unknown Object (Differential Revision).
Mar 18 2019, 6:19 PM · Diffusion

Mar 17 2019

leoluk awarded T8924: Add push notification support a Like token.
Mar 17 2019, 9:39 AM · Notifications

Mar 16 2019

epriestley edited the content of Changelog.
Mar 16 2019, 9:20 PM
epriestley created 2019 Week 11 (Mid March).
Mar 16 2019, 8:55 PM
epriestley placed T7607: Invoicing emails probably need some work up for grabs.
Mar 16 2019, 8:41 PM · Phortune, Phacility
epriestley placed T11456: Don't lose user in NUX flow because of Timezone issues up for grabs.
Mar 16 2019, 8:41 PM · Design, Phacility, NUX
epriestley placed T11132: New Phabricator NUX up for grabs.
Mar 16 2019, 8:41 PM · Design, Phacility, NUX
epriestley placed T9515: Build a "quorum" mechanism and associated UI up for grabs.
Mar 16 2019, 8:41 PM · Restricted Project, Notifications, Phacility, Auth
epriestley closed T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer as Resolved by committing Restricted Diffusion Commit.
Mar 16 2019, 7:36 PM · Mail
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 16 2019, 7:34 PM · Plans

Mar 15 2019

epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Mar 15 2019, 8:55 PM · Phacility
leoluk awarded T182: Commit into repository directly from differential a Like token.
Mar 15 2019, 6:01 PM · Haskell.org, Restricted Project, Differential
leoluk awarded T11091: Make `arc patch` try the local working copy and staging areas a Like token.
Mar 15 2019, 6:00 PM · Haskell.org, Arcanist
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: Unknown Object (Differential Revision).
Mar 15 2019, 5:10 PM · Workboards (v3), Restricted Project
fanis removed a watcher for Plans: fanis.
Mar 15 2019, 11:19 AM

Mar 14 2019

epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: Unknown Object (Differential Revision).
Mar 14 2019, 5:24 PM · Workboards (v3), Restricted Project
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: Unknown Object (Differential Revision).
Mar 14 2019, 3:23 PM · Workboards (v3), Restricted Project
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I also vaguely think some mailer API historically rejected mail with a "Message-ID" header with an actual error ("You can't set this header, we're going to set it for you.") rather than just ignoring/replacing it (maybe SendGrid?), but I might be misremembering or that behavior may have changed. We could still always set the header and drop it in the Adapter nowadays, this whole thing is just a nest of hornets and kicking it has pretty limited upside.

Mar 14 2019, 3:10 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I was imagining keeping the Message-ID, while having the first email also include the same value for In-Reply-To — I completely agree that removing the Message-ID would not work out. If the first email always included both fields, thus referencing itself as a reply to itself, I suppose there could be MUAs that would go into infinite loops. So, maybe too risky.

Mar 14 2019, 3:07 PM · Mail
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I can imagine that cases like this may exist:

Mar 14 2019, 2:58 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

The only effect I can imagine of always setting the In-Reply-To would be to encourage threading where it's not currently happening, so removing the behavior and deleting all these little methods would be very attractive to me if it were my project. :)

Mar 14 2019, 2:46 PM · Mail
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

There's probably some argument here for removing this behavior and assuming we can never generate a "Message-ID", but I'm hesitant to make changes like that since client threading is largely unknowable black magic which we can not test, and the current approach seems to generally produce acceptable results without an overwhelming amount of collateral complexity.

Mar 14 2019, 2:20 PM · Mail
epriestley added a revision to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer: Unknown Object (Differential Revision).
Mar 14 2019, 1:53 PM · Mail
epriestley renamed T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer from Restore In-Reply-To field to first email about a Differential revision to Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.
Mar 14 2019, 1:03 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

It worked!

Mar 14 2019, 12:24 PM · Mail
kislinsk added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Very happy to see that you guys are working on this, thank you. 👍

Mar 14 2019, 8:32 AM · Workboards (v3), Restricted Project

Mar 13 2019

epriestley closed T10745: Emails are sent out about restricted changes as Wontfix.

This is an unconstructive mess that I don't specifically plan to act on. T13069 and other work may eventually resolve this case indirectly.

Mar 13 2019, 6:27 PM · Restricted Project, Bug Report
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

report back on whether it mitigates

Mar 13 2019, 6:16 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I merely wanted to have both possible resolutions on the table, one of which was to give the first message the ID later used In-Reply-To.

Mar 13 2019, 5:03 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

How old were things before the upgrade? (Roughly: less or more than about a year old?)

Mar 13 2019, 5:02 PM · Mail
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

This previous behavior violated standards — the In-Reply-To identifier is supposed to be the Message-ID of a previously delivered email — but at least it wove a consistent fiction for mail clients.

Mar 13 2019, 4:46 PM · Mail
epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

Have you possibly changed mailers from "SES" to "SES via SMTP" or something like that? The logic here is basically:

Mar 13 2019, 4:36 PM · Mail
brhodes created T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.
Mar 13 2019, 4:19 PM · Mail
20after4 awarded T10578: Provide 'Sort by Points' option in workboards a Love token.
Mar 13 2019, 4:05 PM · Workboards (v3), Feature Request
20after4 awarded T10333: Add groups to workboard columns a Love token.
Mar 13 2019, 4:05 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel.

See also https://phabricator.wikimedia.org/T113556 downstream.

Mar 13 2019, 11:54 AM · Dashboards
epriestley renamed T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel from Make it easier to update an ApplicationSearch saved query to Make it easier to update the ApplicationSearch saved query used by a dashboard panel.
Mar 13 2019, 11:51 AM · Dashboards
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 13 2019, 11:19 AM · Plans
epriestley added a comment to T5422: Does Phabricator integrate with JIRA?.

See PHI1125. Recent versions of JIRA (JIRA 8?) still work with approximately the same instructions, but you have to fill out a modal dialog with about 7 required fields first, and none of the fields have real values. That is, the configuration instructions for recent JIRA are:

Mar 13 2019, 11:16 AM · Guides, Doorkeeper
epriestley closed T10333: Add groups to workboard columns, a subtask of T8135: drag & drop on a workboard sorted by priority behavior is surprising, as Resolved.
Mar 13 2019, 11:12 AM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10333: Add groups to workboard columns as Resolved.

I'm going to consider this resolved at this point. The one thing I haven't built is the "task/point count" from the mocks (on the right-hand side of the header, counting points in each group), but I think this is probably only of much use under "Group by Owner", and maybe not even then. I'm open to building this in a future iteration and it's not likely to be very much work, I'd just like to see feedback that we're generally headed in the right direction first and that the element would have real-world use cases.

Mar 13 2019, 11:11 AM · Restricted Project, Restricted Project, Workboards (v3)

Mar 12 2019

epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: Unknown Object (Differential Revision).
Mar 12 2019, 9:20 PM · Workboards (v3), Plans, Projects
epriestley closed T10578: Provide 'Sort by Points' option in workboards as Resolved by committing Restricted Diffusion Commit.
Mar 12 2019, 8:54 PM · Workboards (v3), Feature Request
epriestley closed T10722: Communicate drag policies clearly in the workboard/list UIs as Resolved by committing Restricted Diffusion Commit.
Mar 12 2019, 8:43 PM · Workboards (v3), Bug Report
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: Unknown Object (Differential Revision).
Mar 12 2019, 6:15 PM · Workboards (v3), Restricted Project
mbinder awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Party Time token.
Mar 12 2019, 5:35 PM · Workboards (v3), Restricted Project
epriestley triaged T13264: Maybe stack multiple breadcrumb sequences? as Wishlist priority.
Mar 12 2019, 4:57 PM · Design
epriestley added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Currently, you can put a task in a column in these ways:

Mar 12 2019, 1:37 PM · Workboards (v3), Restricted Project
epriestley added a member for Community: mves.
Mar 12 2019, 12:44 PM
epriestley closed T10944: Subproject is not archived when parent project gets archived as Wontfix.

Currently, expected behavior.

Mar 12 2019, 3:20 AM · Projects, Bug Report
epriestley closed T11974: Projects should allow setting of any icon as Resolved.

More or less resolved previously in D14918.

Mar 12 2019, 3:17 AM · Projects
epriestley closed T11974: Projects should allow setting of any icon, a subtask of T11971: Build an Icon Typeahead, as Resolved.
Mar 12 2019, 3:17 AM · PHUI
epriestley closed T10611: No option to specify a Space when editing a Project's visibility policy as Resolved.

D19549 added Spaces support to projects.

Mar 12 2019, 3:16 AM · Projects, Restricted Project, Feature Request, Spaces
epriestley closed T10266: Firefox body scroll fails when dragging tasks as Wontfix.

Mooted by D20263, which removes the rarely-used drag functionality from global lists.

Mar 12 2019, 3:14 AM · Firefox, Projects
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 12 2019, 3:13 AM · Restricted Project, Restricted Project, Workboards (v3)

Mar 11 2019

epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 9:23 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley claimed T10578: Provide 'Sort by Points' option in workboards.
Mar 11 2019, 4:53 PM · Workboards (v3), Feature Request
epriestley added a revision to T10578: Provide 'Sort by Points' option in workboards: Unknown Object (Differential Revision).
Mar 11 2019, 4:48 PM · Workboards (v3), Feature Request
epriestley added a revision to T10578: Provide 'Sort by Points' option in workboards: Unknown Object (Differential Revision).
Mar 11 2019, 4:06 PM · Workboards (v3), Feature Request
epriestley added a comment to T10578: Provide 'Sort by Points' option in workboards.

We could lock this order into "drag to column" interactions only once those are built (i.e., not support "drag to position" -- basically, when you drop a card, we fling it into the correct position, even if that position is at the bottom of the column far off the screen). This will be somewhat confusing but maybe the least-bad of the options.

Mar 11 2019, 2:27 PM · Workboards (v3), Feature Request
epriestley closed T6502: Policy to define who can move cards in a workboard, a subtask of T5474: Support workboard column triggers which activate when a task is dropped into a column, as Wontfix.
Mar 11 2019, 2:19 PM · Workboards (v3), Restricted Project
epriestley closed T6502: Policy to define who can move cards in a workboard as Wontfix.

To summarize the state of the world here:

Mar 11 2019, 2:18 PM · Projects, Wikimedia, Policy, Workboards
epriestley closed T6502: Policy to define who can move cards in a workboard, a subtask of T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)", as Wontfix.
Mar 11 2019, 2:18 PM · Projects, Wikimedia, Workboards
epriestley moved T10578: Provide 'Sort by Points' option in workboards from Backlog to v3 on the Workboards board.
Mar 11 2019, 1:31 PM · Workboards (v3), Feature Request
epriestley moved T12175: Simultaneous task moving on workboards results in error from Backlog to v3 on the Workboards board.
Mar 11 2019, 1:31 PM · Workboards (v3), Bug Report
epriestley updated the task description for T13074: Plans: Workboard triggers, groups, and subproject columns.
Mar 11 2019, 1:30 PM · Workboards (v3), Plans, Projects
epriestley added a revision to T10722: Communicate drag policies clearly in the workboard/list UIs: Unknown Object (Differential Revision).
Mar 11 2019, 6:01 AM · Workboards (v3), Bug Report
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: Unknown Object (Differential Revision).
Mar 11 2019, 5:34 AM · Workboards (v3), Plans, Projects
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 5:26 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley claimed T10333: Add groups to workboard columns.
Mar 11 2019, 5:24 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 5:12 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 5:01 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 4:56 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 12:32 AM · Restricted Project, Restricted Project, Workboards (v3)

Mar 10 2019

epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 10 2019, 4:22 PM · Restricted Project, Restricted Project, Workboards (v3)

Mar 9 2019

epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 8:34 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:16 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:15 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:12 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 6:58 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 6:50 PM · Plans
epriestley added a project to T13263: Plans: 2019 Week 11-15 Bonus Content: Plans.
Mar 9 2019, 6:43 PM · Plans
epriestley triaged T13263: Plans: 2019 Week 11-15 Bonus Content as Normal priority.
Mar 9 2019, 6:43 PM · Plans
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 - 9 Bonus Content to 2019 Week 7 - 10 Bonus Content.
Mar 9 2019, 6:42 PM · Plans
epriestley added a comment to T10333: Add groups to workboard columns.

This now exists for priorities. I'd like to get at least one more grouping (likely: assignee) built before calling this resolved since "Priority" has some magic interaction with "subpriority". I'm moving toward getting rid of "subpriority" in D20263, but I'm not yet completely sure that it'll stick.

Mar 9 2019, 6:38 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley closed T8135: drag & drop on a workboard sorted by priority behavior is surprising as Resolved.

Drag-and-drop between columns on a priority-sorted board no longer changes priority. See T13074 for continuing adjacent work.

Mar 9 2019, 6:37 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column", a subtask of T8135: drag & drop on a workboard sorted by priority behavior is surprising, as Resolved.
Mar 9 2019, 6:36 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column" as Resolved.

Some adjacent work in T13074 may build on this, and we might do "drag + shift" at some point, but this is substantially resolved.

Mar 9 2019, 6:35 PM · Workboards (v3)
20after4 added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

I wholeheartedly agree that all that proxy field mess needs to go away. With that gone the only moderately confusing part remaining would be the way in which custom fields interact with herald, email and notifications.

Mar 9 2019, 12:48 PM · Custom Fields, Maniphest

Mar 8 2019

epriestley edited the content of Changelog.
Mar 8 2019, 3:10 PM
epriestley created 2019 Week 9 (Very Late February).
Mar 8 2019, 3:09 PM
epriestley created 2019 Week 10 (Early March).
Mar 8 2019, 3:08 PM

Mar 7 2019

epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), a subtask of T13088: Plans: Harbormaster UI usability and interconnectedness, as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: Unknown Object (Differential Revision).
Mar 7 2019, 7:41 PM · Workboards (v3), Plans, Projects
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

An adjacent issue is that the current behavior of overheated queries is to return a partial result set and set a flag. The goal of this behavior is to let us show some results if we find some results, but it may be surprising if the caller doesn't handle overheated queries, since they may look like a queries which simply failed to match anything.

Mar 7 2019, 6:43 PM · Diffusion
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

The hypothetical steps above do, in fact, reproduce this:

Mar 7 2019, 6:17 PM · Diffusion
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Mar 7 2019, 2:22 PM · Plans, Harbormaster
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: Unknown Object (Differential Revision).
Mar 7 2019, 1:02 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: Unknown Object (Differential Revision).
Mar 7 2019, 4:52 AM · Plans