I'd be fine removing the range select on mobile.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 23 2017
I understand why the behavior has changed, and I'm not particularly opposed to keeping it as-is. I can easily reach over the line number - it's just that it initially appeared as a regression so I had to note it here.
This is an intentional change to address T1026 (allowing inline ranges to be added via touchscreen devices). Previously, it wasn't possible to comment on a range of lines on, e.g., an iPhone/iPad.
Hi Epriestley,
On mobile I very quickly get an inline comment box when scrolling which then takes focus so scrolling is aborted.
May 22 2017
Please use Conpherence or Ponder if you have questions about Phabricator administration and options.
Arcanist hides part of the stderr to prevent console spam. But what problem does this fix exactly? How is it a problem that 5GB of output are printed to stderr? The way I see it, if the tool called by arc prints a lot of info to stderr, it should be assumed it is printed for a good reason, be it 1KB or 5PB.
Ahh, makes sense now :)
Synthetic comments (made by lint) are currently shown in the sidebar annotation with a pencil ( ) icon.
I don't think that's a very desirable behavior.
The same as what you do with any tool which produces 5GB of output: wonder what happened, then try again and redirect the output to a file and deal with it. Currently the user has to run manually the steps printed when using --trace, and then they will get to that 5GB output anyway.
How can I reproduce the issue you're encountering?
I have upgraded the version still having the same issue. Current version is given below.
The problem is a outdated version of phabricator/externals/mimemailparser/MimeMailParser.class.php.
What behavior would you expect arc to have if git commit ... produces 5GB of output (hypothetically, from a hook which prints 2.5GB of header and footer context and puts the important part in the middle)?
What if you try recreating the output generated by the hg commands shown from the --trace -- does the output look off in any way?
Did that, you can see the result at P2054. At least to me, nothing looks fishy...
Okay, Thank you.
(You are also almost 8 months out of date; we only support recent versions of Phabricator.)
Click on logout then tried to login using google authentication and getting the error.
Sorry for not providing the version information. I have included the version details below.
You could pay reviewers with Mana ;)
Please follow all the instructions when submitting a bug report. In particular, we need:
I am unable to login to my Phabricator after clicking logout. Getting the below error.
In T12739#224605, @avivey wrote:Why is this Nuance and not Doorkeeper?
For those looking for ways to manually move projects until this is implemented: T10350: Scripts to migrate old "points" fields and move projects beneath other projects
In T12739#224607, @chad wrote:GH Issues flow into Nuance and a human can decide whether to open it up as a Maniphest Task, similar to email. The end user can fully communicate an issue back to Phabricator without ever leaving their preferred source (email, Github, Twitter). Developers can stay in Phabricator and manage priorities, projects, workboards.
GH Issues flow into Nuance and a human can decide whether to open it up as a Maniphest Task, similar to email. The end user can fully communicate an issue back to Phabricator without ever leaving their preferred source (email, Github, Twitter). Developers can stay in Phabricator and manage priorities, projects, workboards.
Why is this Nuance and not Doorkeeper?
FWIW I partially implemented this in Wikimedia's fork, and I did so in a reusable way. I'd like to eventually upstream it but I'm not sure that my approach is desired upstream. I'll give it another shot though.
not upstream-able.
May 21 2017
There's a typo in the headline, but I can't it :(
I'm going to close this; there are two possible followups -- each of which is better focused on a more specific set of problems -- but I'm not merging it into either one since I think there's a lot of general ambiguity about problems and use cases here. If you're interested in this, feel free to follow either or both.
This was basically just a work log for an earlier iteration on Nuance focused on bi-directional bridging with GitHub. We're pursuing Nuance again now, but not with the same focus, so I'm going to close this and reorganize things. Some similar task will likely fall out at the end, but with a better focus on where we're actually headed.
Jira's Confluence provides inline comments; same model could be used by Phriction. But that's not as important. Should at least have support for end-of-doc (footer) style commenting.
May 20 2017
- The persistent header should now select more intuitive changesets.
- The scrollbar annotation is now disabled for trackpad "aesthetic" scrollbars (like the 0-width scrollbar on OSX if you don't have a mouse connected to your laptop). If we retain the element, I plan to enable it eventually, it just requires us to move content around and generally make a larger change.
- The scrollbar annotation is now disabled unless phabricator.show-prototypes is enabled.
- The scrollbar annotation should generally work better and be more useful now.
- I've deployed these changes to this host.
For reference, even though this isn't right. I figured I'd put my notes here for someone else to find and help me out:
location / {
client_max_body_size 32M;
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header X-Frame-Options DENY;
proxy_set_header X-XSS-Protection "1; mode=block";
proxy_set_header Referrer-Policy no-referrer-when-downgrade;@jefferai how did you overwrite the headers? I'm encountering this exact same issue.
This is pretty awesome improvement! Small feedback, the new scrollbar area is a bit hard to use on Safari with Apple's disappearing/reappearing scrollbars. They end up overlapping and it can make the Phabricator scrollbar area harder to use/click on etc. Would be nice if the scrollbar area shifted left while scrolling or if it were on the left side of the screen or some other magical solution.
I'll tweak the logic, I agree that, e.g., "index.js" should be displayed in your first screenshot (and probably whatever's above it if you scrolled up just a little bit more).
That'll be 6 beers pls.