Page MenuHomePhabricator

InvalidArgumentException when viewing a room you haven't joined from Safari
Closed, ResolvedPublic

Description

When using Safari 10.1 on Mac OS 10.12, viewing a Conpherence room without joining results in a Unhandled Exception popup at some point (it's inconsistent how long) after loading the chat.

Reproduction Steps:

  1. While signed in, navigate to a room you are not a current member of, using Safari.

Expected Result:

  • Be able to view the thread normally, without interruption.

Actual Result:

  • A popup appears with the below text.

The message from the exception is:

Argument 2 passed to ConpherenceUpdateController::getSoundForParticipant() must be an instance of ConpherenceParticipant, null given, called in /core/lib/phabricator/src/applications/conpherence/controller/ConpherenceUpdateController.php on line 372 and defined

This is when using this install of Phabricator (secure.phabricator.com). It does not happen on my own instance, which for the sake of completeness is running
phabricator 0e8f72a0d992ee5b27f807b65e4ce83ef2ec5078 (Wed, May 17)
arcanist 3c4735795a2963c5ddff6dceaf60122d01ca3dc0 (Wed, May 3)
phutil a900d7b63e954e221efe140f0f33d3d701524aae (Sun, Apr 23)

Event Timeline

chaseh created this task.May 19 2017, 11:28 PM
chad added a subscriber: chad.May 19 2017, 11:46 PM

It's inconsistent because you need to be watching a room and someone has to post a message (in order to trigger a sound). Thanks for the report!