Page MenuHomePhabricator
Feed Advanced Search

Jul 1 2017

epriestley created 2017 Week 26 (Very Late June).
Jul 1 2017, 12:15 AM

Jun 30 2017

avivey added a comment to T12856: Evaluate various "infrastructure-as-code" products.

costanzapopcorn

Jun 30 2017, 11:35 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Also we aren't the only ones to be surprised by the AWS NAT junk:

Jun 30 2017, 10:55 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

It looks like Terraform probably can add a listener without destroying the LB (since it's a separate resource type? But the "changing the size of a volume destroys the instance" case suggests maybe it doesn't work like this, if that's how that works), but if you want to enable access logging on your LBs hope you didn't need 'em for anything important? I could probably just install it and figure this out / nuke production forever.

Jun 30 2017, 10:19 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

If PHP just injects that information into the templates during generation, we might not need to feed anything back into Almanac.

Jun 30 2017, 9:02 PM · Ops, Phacility
amckinley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Maybe we should just use CloudFormation ¯\_(ツ)_/¯

Jun 30 2017, 8:30 PM · Ops, Phacility
amckinley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

First, a disclaimer that I'm not by any means wedded to terraform. From playing with the other tools, terraform looked like the clearest pathway towards my goal of "minimizing AWS UI clicks", so I decided to see what the terraform config for a private cluster would look like and play with the tool. See example terraform configs here: P2063 P2064. I agree with the general thrust of your comment, which I interpret as "this all sounds terrifying and we probably shouldn't do it", but I wanted to at least get a feeling for the tool and build a proof of concept.

Jun 30 2017, 7:58 PM · Ops, Phacility
epriestley closed T12887: Can't add members to "parent project" when all subprojects are archived as Invalid.

Yes, this is expected. The process of converting a project to become a parent project can not be undone:

Jun 30 2017, 7:31 PM · Bug Report
chad added a comment to T12887: Can't add members to "parent project" when all subprojects are archived.

This behavior sounds correct to me.

Jun 30 2017, 7:27 PM · Bug Report
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Terraform also seems to have terraform taint (mark a resource for destruction) but no, e.g., terraform freeze (mark a resource for preservation). This is sort of philosophically bewildering to me. Is the modern approach to ops just like "data isn't important"? Is everyone just really, really careful when they type commands into their fully-automatic resource destruction rifles loaded with high-explosive foot-seeking shells?

Jun 30 2017, 7:27 PM · Ops, Phacility
xp500 created T12887: Can't add members to "parent project" when all subprojects are archived.
Jun 30 2017, 7:23 PM · Bug Report
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

How does the weekly deployment to all clusters work?

Jun 30 2017, 6:39 PM · Ops, Phacility
amckinley edited P2064 example_customer.tf.
Jun 30 2017, 6:33 PM
amckinley updated the title for P2064 example_customer.tf from uber.tf to example_customer.tf.
Jun 30 2017, 6:29 PM
jcox added a comment to T12880: Expose the ability to add some JS to every page.

Haha to be clear we're using an open-source self-hosted tracking solution, I was just throwing GA out there as an example. But I do understand your point vis-a-vis data security.

Jun 30 2017, 5:37 PM · Feature Request
epriestley added a comment to T12880: Expose the ability to add some JS to every page.

I guess everyone uses GMail nowadays anyway (as mandated by international galactic law) so my paranoia is probably mostly moot because they can undetectably read all email communication anyway.

Jun 30 2017, 5:14 PM · Feature Request
mplough added a comment to T12883: Harbormaster build completion information displays build start time.

Glad I could help! Thanks for getting the fix in so quickly!

Jun 30 2017, 4:05 PM · Bug Report
amckinley created P2064 example_customer.tf.
Jun 30 2017, 3:53 PM
amckinley created P2063 shared.tf.
Jun 30 2017, 3:53 PM
epriestley closed T12880: Expose the ability to add some JS to every page as Wontfix.

I think you probably won't be able to answer most of those questions with Google Analytics. For example, bots will never hit client-side analytics, so any question about bots probably can't be served by GA. Likewise, GA can't see Conduit/API activity.

Jun 30 2017, 2:45 PM · Feature Request
epriestley added a comment to T12879: Put crontabs in VCS and deploy them during provisioning.

(Both adjust and doc/symbol documentation affect an entire service tier rather than particular servers, too -- we only need to generate docs or make schema adjustments once, no matter how many hosts are in the secure or admin tiers.)

Jun 30 2017, 2:25 PM · Phacility, Ops
epriestley added a comment to T12879: Put crontabs in VCS and deploy them during provisioning.

My recollection is a little fuzzy, but I think admin may have once had a hacky crontab for backups that I replaced with a normal backup trigger at some point when the infrastructure matured a little.

Jun 30 2017, 2:23 PM · Phacility, Ops
jcox added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 30 2017, 2:17 PM · Feature Request
epriestley awarded Bug Meister to recipient: ephemeris.
Jun 30 2017, 2:13 PM
epriestley awarded Bug Meister to recipient: mplough.
Jun 30 2017, 2:13 PM
epriestley added a comment to T12883: Harbormaster build completion information displays build start time.

I believe your analysis and proposed change are correct. D18177 brings that change upstream. It is now available in master, and should promote to stable later today (within about 12 hours).

Jun 30 2017, 2:13 PM · Bug Report
epriestley closed T12883: Harbormaster build completion information displays build start time as Resolved by committing Restricted Diffusion Commit.
Jun 30 2017, 2:11 PM · Bug Report
epriestley added a comment to T12884: Diffusion claims that remote repos' clone URIs are disabled.

This should now be fixed in HEAD of master and promote to stable later today (within about 12 hours). This change hasn't been deployed to secure.phabricator.com yet but will be deployed no later that tomorrow morning (about 24 hours from now), at which point the example link you provided should start working.

Jun 30 2017, 2:11 PM · Diffusion, Bug Report
epriestley closed T12884: Diffusion claims that remote repos' clone URIs are disabled as Resolved by committing Restricted Diffusion Commit.
Jun 30 2017, 2:09 PM · Diffusion, Bug Report
epriestley added a comment to T12885: Warning For Past Events.

I think it's probably reasonable for us to warn about RSVP'ing to an event which has already ended. I'd guess this is usually a mistake, and in cases where it isn't some kind of weird off-label workflow is taking place and the warning is probably fine.

Jun 30 2017, 2:09 PM · Calendar, Feature Request
epriestley added a revision to T12883: Harbormaster build completion information displays build start time: Unknown Object (Differential Revision).
Jun 30 2017, 2:03 PM · Bug Report
epriestley claimed T12884: Diffusion claims that remote repos' clone URIs are disabled.
Jun 30 2017, 2:01 PM · Diffusion, Bug Report
epriestley added a revision to T12884: Diffusion claims that remote repos' clone URIs are disabled: Unknown Object (Differential Revision).
Jun 30 2017, 2:01 PM · Diffusion, Bug Report
wordpress awarded Q462: Is there a way to use Differential via Eclipse? a Like token.
Jun 30 2017, 9:25 AM
chad renamed T12886: Cannot upload file from Firefox (Android) from Cannot upload file from Firefox mobile to Cannot upload file from Firefox (Android).
Jun 30 2017, 6:49 AM · Android, Firefox, Bug Report
chad added a comment to T12886: Cannot upload file from Firefox (Android).

Firefox iOS seems fine

Jun 30 2017, 6:49 AM · Android, Firefox, Bug Report
shuLhan added a comment to T12886: Cannot upload file from Firefox (Android).

Testing upload from Android with Chrome:

Tangkapan layar_20170630-113846.png (1×1 px, 131 KB)

Jun 30 2017, 6:17 AM · Android, Firefox, Bug Report
chad renamed T12886: Cannot upload file from Firefox (Android) from Cannot upload file from mobile to Cannot upload file from Firefox mobile.
Jun 30 2017, 6:09 AM · Android, Firefox, Bug Report
chad added a comment to T12886: Cannot upload file from Firefox (Android).

I don't believe we've ever supported Firefox on mobile. Do you have the ability to use a different browser? Or are all browsers on Android non-operative here.

Jun 30 2017, 6:03 AM · Android, Firefox, Bug Report
shuLhan created T12886: Cannot upload file from Firefox (Android).
Jun 30 2017, 4:45 AM · Android, Firefox, Bug Report

Jun 29 2017

eugeneegbe created P2062 [RECENT] Diff of Wikispeech lexicon project changes to check for value in $currentUtterrance.
Jun 29 2017, 11:58 PM · Wikimedia
CodeMouse92 created T12885: Warning For Past Events.
Jun 29 2017, 11:11 PM · Calendar, Feature Request
ephemeris updated the task description for T12884: Diffusion claims that remote repos' clone URIs are disabled.
Jun 29 2017, 9:43 PM · Diffusion, Bug Report
ephemeris created T12884: Diffusion claims that remote repos' clone URIs are disabled.
Jun 29 2017, 9:42 PM · Diffusion, Bug Report
amckinley added a comment to T12847: A Pathway Towards Private Clusters.

And here's the official AWS docs for connecting VPCs using OpenSWAN: https://aws.amazon.com/articles/5472675506466066

Jun 29 2017, 8:26 PM · Plans, Ops, Phacility
amckinley added a comment to T12847: A Pathway Towards Private Clusters.

So it occurs to me that we could have one "shared" public subnet that contains: 1 shared Internet Gateway, 1 shared NAT Gateway, and then per-install VPN nodes. We should be able to setup routing tables for the private subnets that point to that install's VPN node. Since routing is enforced at the network layer (routing tables on actual EC2 nodes are bogus), that would enforce traffic separation. In theory, installs could saturate the IGW or NAT gateway, but I'm pretty sure those resources should autoscale since they're managed by EC2. A NAT gateway with no traffic going through it is $32/month, and as far as I can tell, an Internet Gateway is free, but eventually we'd be saving some money.

Jun 29 2017, 7:55 PM · Plans, Ops, Phacility
amckinley added a comment to T12847: A Pathway Towards Private Clusters.

Another AWS gotcha learned the hard way: nodes in a "private" subnet can still be part of an "internet-facing" ELB, but the trick is that you have to attach the ELB to the "public" subnet that contains the IGW and the NAT Gateway, and the nodes in the "private" subnet need a route to the NAT Gateway.

Jun 29 2017, 6:11 PM · Plans, Ops, Phacility
epriestley added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 29 2017, 4:07 PM · Feature Request
mplough created T12883: Harbormaster build completion information displays build start time.
Jun 29 2017, 2:31 PM · Bug Report
vostok4 added a comment to T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected.

@PhoneixS thank you for the fix. It fixed a very annoying problem here with Windows-1252 encoding in a file name!

Jun 29 2017, 1:34 PM
vostok4 awarded T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected a Love token.
Jun 29 2017, 1:34 PM
chad closed T12882: testing form configurations as Invalid.
Jun 29 2017, 7:18 AM · Feature Request
chad closed T12881: testing form configurations as Invalid.

Please don't test this server. We will disable your account.

Jun 29 2017, 7:18 AM · Bug Report
exp10r3r created T12882: testing form configurations.
Jun 29 2017, 7:13 AM · Feature Request
exp10r3r created T12881: testing form configurations.
Jun 29 2017, 7:12 AM · Bug Report
avivey closed T11539: Phabricator Mercurial Repo “too many files open” error as Resolved.

Probably resolved.

Jun 29 2017, 4:32 AM · Bug Report
avivey added a comment to T12876: Improve initial arc land experience when destination repo is empty.

in T6722#197239 I had the same problem with "land revision from Web UI" :)

Jun 29 2017, 4:26 AM · Arcanist
Krinkle awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jun 29 2017, 2:59 AM · Prioritized, Restricted Project, Infrastructure

Jun 28 2017

amckinley added a comment to T12847: A Pathway Towards Private Clusters.

Note that we can not send SSH traffic over an ALB -- they only speak HTTP/HTTPS. However, we can send it over v1.5 VPC ELB, apparently (v1 classic ELBs do not let you listen on 22).

Jun 28 2017, 11:45 PM · Plans, Ops, Phacility
amckinley created E1560: Jury Duty.
Jun 28 2017, 10:17 PM · Phacility
amckinley added a comment to T12879: Put crontabs in VCS and deploy them during provisioning.

On secure, I could only find a crontab for the ubuntu user, which is as follows:

0 6 * * * /core/bin/host backup
0 7 * * * /core/bin/host prune --force
0 8 * * * /core/conf/util/generate-documentation
0 9 * * * /core/conf/util/generate-symbols
Jun 28 2017, 9:40 PM · Phacility, Ops
amckinley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Having played with a few more of these tools and thinking about the problem, I'm starting to lean towards "use Terraform or CloudFormation for orchestrating AWS infrastructure, and leave the provisioning stuff in rCORE as-is". The basic flow for provisioning private instances could be:

Jun 28 2017, 9:37 PM · Ops, Phacility
girtsf added a comment to T4719: config option to make 'arc land --hold' default behavior.

I too wish that there was some confirmation mode for arc land (and maybe arc diff too?).

Jun 28 2017, 8:48 PM · Arcanist
jcox added a comment to T12880: Expose the ability to add some JS to every page.

image.png (553×414 px, 298 KB)

Jun 28 2017, 7:55 PM · Feature Request
chad added a comment to T12880: Expose the ability to add some JS to every page.

tumblr_inline_op017kGTqT1teupc5_540.gif (345×498 px, 2 MB)

Jun 28 2017, 7:50 PM · Feature Request
jcox created T12880: Expose the ability to add some JS to every page.
Jun 28 2017, 7:42 PM · Feature Request
epriestley added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

The "consulting firms" use case is explicitly disavowed by, e.g., the Spaces documentation, here:

Jun 28 2017, 7:00 PM · People, Security
amckinley created T12879: Put crontabs in VCS and deploy them during provisioning.
Jun 28 2017, 6:54 PM · Phacility, Ops
avivey added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

I can't think of any solution to this short of full policy + complex policy rules such as "users that share project/space/payment account/instance with this user", which is complex (and probably slow to compute, or requires lots of extra stuff to maintain).

Jun 28 2017, 6:40 PM · People, Security
epriestley archived Releeph.
Jun 28 2017, 5:13 PM
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:13 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:13 PM · Releeph
epriestley closed T4679: releeph.queryrequests Conduit call doesn't expose enough information as Wontfix.
Jun 28 2017, 5:13 PM · Facebook, Releeph
epriestley closed T4700: Give Releeph more human-readable URIs? as Wontfix.
Jun 28 2017, 5:13 PM · Facebook, Releeph
epriestley closed T4696: Implement an incrementing counter for Releeph templates as Wontfix.
Jun 28 2017, 5:13 PM · Releeph
epriestley closed T4691: Releeph Migration/Update Issues as Wontfix.
Jun 28 2017, 5:12 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:12 PM · Releeph
epriestley closed T2717: Fix the giant query in ReleephRequestTypeaheadController, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2752: Releeph shouldn't let you request the same code twice, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2718: Fix the ad-hoc branch contain query in `DifferentialReleephRequestFieldSpecification`, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2718: Fix the ad-hoc branch contain query in `DifferentialReleephRequestFieldSpecification` as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2717: Fix the giant query in ReleephRequestTypeaheadController as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2752: Releeph shouldn't let you request the same code twice as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley removed a project from T9530: Release Server / Workflow app / Future of Releeph : Releeph.
Jun 28 2017, 5:06 PM · Restricted Project, Harbormaster
epriestley closed T2714: Move Releeph to Beta as Wontfix.

See T9530.

Jun 28 2017, 5:02 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:02 PM · Releeph
epriestley closed T7650: Support Impressum for public policy legal compliance as Invalid.

As is sometimes the case with legal issues, I think this request is based on a misunderstanding of the law. The German "Telemedia Act" establishing this requirement ("Telemediengesetz") does not seem to require the link to appear on every page.

Jun 28 2017, 4:56 PM
epriestley renamed T3967: Build a 2-up preview mode into the fullscreen Remarkup editor from Build a preview mode into the fullscreen Remarkup editor to Build a 2-up preview mode into the fullscreen Remarkup editor.
Jun 28 2017, 4:21 PM · Remarkup
epriestley placed T3967: Build a 2-up preview mode into the fullscreen Remarkup editor up for grabs.
  • Remarkup areas got inline previews in D14855.
  • EditEngine got some extensions to restore similar on-page previews to Maniphest.
Jun 28 2017, 4:21 PM · Remarkup