Page MenuHomePhabricator
Feed Advanced Search

Jan 7 2017

0 changed E1211: All day test to repeat until Nov 17 2016.
Jan 7 2017, 3:23 AM
0 set E1211: All day test to repeat weekly.
Jan 7 2017, 3:21 AM
chad added a comment to T7899: DifferentialDiff->description is "text255?" but should be "text".

I don't think we mention every commit in the changelog?

Jan 7 2017, 2:37 AM · Differential, Mercurial, Arcanist
cspeckmim added a comment to T7899: DifferentialDiff->description is "text255?" but should be "text".

I may have missed it but it doesn't look like this was mentioned in any changelog in December/January - or is this not yet in stable?

Jan 7 2017, 2:33 AM · Differential, Mercurial, Arcanist
epriestley closed T12077: Host secure004.phacility.net has been eaten by plague rats as Resolved.

I think we're back in action and I have learned a series of valuable life lessons.

Jan 7 2017, 2:09 AM · Ops, Phacility
epriestley added a comment to T12077: Host secure004.phacility.net has been eaten by plague rats.

(This host is the replica database for the "Files" application partition, so even if I had to completely burn it to the ground nothing would be lost.)

Jan 7 2017, 1:55 AM · Ops, Phacility
chad awarded T12077: Host secure004.phacility.net has been eaten by plague rats a The World Burns token.
Jan 7 2017, 1:50 AM · Ops, Phacility
epriestley added a comment to T12077: Host secure004.phacility.net has been eaten by plague rats.

I foolishly ran apt-get dist-upgrade because I am bad at computer and the motd said I should.

Jan 7 2017, 1:47 AM · Ops, Phacility
epriestley created T12077: Host secure004.phacility.net has been eaten by plague rats.
Jan 7 2017, 1:41 AM · Ops, Phacility
chad edited the content of 2017 Week 1 (Early January).
Jan 7 2017, 1:22 AM
epriestley edited the content of Changelog.
Jan 7 2017, 1:06 AM
epriestley created 2017 Week 1 (Early January).
Jan 7 2017, 1:01 AM

Jan 6 2017

epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Jan 6 2017, 9:31 PM · Restricted Project, Calendar
epriestley closed T11945: Unable to edit calendar events created by someone else, even after `bin/policy unlock` as Resolved.

I wasn't able to reproduce this earlier so I'm not sure how to move forward, but feel free to follow up if you have more information.

Jan 6 2017, 9:25 PM · Bug Report (Needs Information), Policy, Calendar
epriestley added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

One thought here is that updating variables_order is fine on the server, but I really don't want to force arc users to muck with php.ini. Some possible "solutions":

Jan 6 2017, 7:49 PM · Infrastructure
epriestley merged T10254: Assign projects to spaces into T11580: Tasks created from workboards frequently have to be edited to add properties common to all tasks on the workboard.
Jan 6 2017, 7:38 PM · Workboards, EditEngine, Projects, Feature Request
epriestley merged task T10254: Assign projects to spaces into T11580: Tasks created from workboards frequently have to be edited to add properties common to all tasks on the workboard.
Jan 6 2017, 7:38 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley added a comment to T10254: Assign projects to spaces.

I'm going to merge this into T11580 because I think that describes what remains here.

Jan 6 2017, 7:38 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley added a comment to T12074: conduit API extensions for subprojects and milestones..

I briefly dug these up:

Jan 6 2017, 7:34 PM · Feature Request
epriestley merged T10436: Enhance the API (project.query) to find parent- and/or subprojects into T12074: conduit API extensions for subprojects and milestones..
Jan 6 2017, 7:30 PM · Feature Request
epriestley merged task T10436: Enhance the API (project.query) to find parent- and/or subprojects into T12074: conduit API extensions for subprojects and milestones..
Jan 6 2017, 7:30 PM · Restricted Project, Projects, Feature Request
epriestley merged T10569: Subproject tasks in parent project backlog into T11036: Put subproject columns on workboards.
Jan 6 2017, 7:28 PM · Workboards (v3), Projects (v3)
epriestley merged task T10569: Subproject tasks in parent project backlog into T11036: Put subproject columns on workboards.
Jan 6 2017, 7:28 PM · Workboards, Projects, Feature Request
epriestley added a comment to T10569: Subproject tasks in parent project backlog.

I'm going to merge this into T11036, which specifically describes subproject columns.

Jan 6 2017, 7:28 PM · Workboards, Projects, Feature Request
epriestley moved T11022: Implement a `current-milestone-of(project)` tokenizer function from Backlog to Far Future on the Projects board.
Jan 6 2017, 7:25 PM · Projects, Feature Request
epriestley triaged T11022: Implement a `current-milestone-of(project)` tokenizer function as Low priority.

One concern I have with this is that the largest sequential milestone may not be the "current" milestone. If you're currently in Sprint 4, someone may reasonably create Sprint 5 before Sprint 4 concludes.

Jan 6 2017, 7:25 PM · Projects, Feature Request
epriestley renamed T11022: Implement a `current-milestone-of(project)` tokenizer function from Query for latest milestone to Implement a `current-milestone-of(project)` tokenizer function.
Jan 6 2017, 7:16 PM · Projects, Feature Request
epriestley closed T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page as Resolved.

Per above, this is working as intended. I'm open to implementing "Copy Columns from <Previous Milestone>" if anyone actually wants that, but it seems like I may have just made it up. Feel free to file a new task if you'd like to see it.

Jan 6 2017, 7:15 PM · Projects, Feature Request
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

Yep, that looks good to me.

Jan 6 2017, 7:11 PM · Design
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

Just for my own understanding:

Jan 6 2017, 7:11 PM · Design
epriestley added a comment to T12074: conduit API extensions for subprojects and milestones..

For (2), the specific problem is that there's no way to look up the milestone PHID, right? If you have the PHID I believe maniphest.search lets you find tasks tagged with a particular milestone:

Jan 6 2017, 7:10 PM · Feature Request
chad added a revision to T5867: Move Quick Create to MenuItemEngine: Unknown Object (Differential Revision).
Jan 6 2017, 7:07 PM · Design
chad removed a parent task for T5867: Move Quick Create to MenuItemEngine: T11957: Add MenuEngine to Home.
Jan 6 2017, 5:05 PM · Design
chad removed a subtask for T11957: Add MenuEngine to Home: T5867: Move Quick Create to MenuItemEngine.
Jan 6 2017, 5:05 PM · Profile Menu Item, Dashboards
chad removed a subtask for T5867: Move Quick Create to MenuItemEngine: T6049: Implement Phurl, a URL shortener/bookmarking application.
Jan 6 2017, 5:05 PM · Design
chad removed a parent task for T6049: Implement Phurl, a URL shortener/bookmarking application: T5867: Move Quick Create to MenuItemEngine.
Jan 6 2017, 5:05 PM · Phurl
chad claimed T5867: Move Quick Create to MenuItemEngine.
Jan 6 2017, 4:59 PM · Design
chad merged task T12030: Make Quick Create Menu configurable via MenuItem into T5867: Move Quick Create to MenuItemEngine.
Jan 6 2017, 4:58 PM · Profile Menu Item
chad merged T12030: Make Quick Create Menu configurable via MenuItem into T5867: Move Quick Create to MenuItemEngine.
Jan 6 2017, 4:58 PM · Design
chad claimed T12030: Make Quick Create Menu configurable via MenuItem.
Jan 6 2017, 4:56 PM · Profile Menu Item
chad closed T12075: NASLOV as Invalid.
Jan 6 2017, 4:22 PM
chad closed T12076: NASLOV as Invalid.
Jan 6 2017, 4:22 PM
jcarrillo7 added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

@avivey my local repo does not have the metadata file but some of the commits do have the git-svn-id in the commit message. I think once we make enough commits on this repo this problem should probably go away but this particular repo doesn't receive commits very often. I would rather not fork arc.

Jan 6 2017, 8:42 AM · Restricted Project, Arcanist
avivey added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

@jcarrillo7: Does your local repo has a .git/svn/.metadata file? We're short on actual data for this use-case.
Alternatively, can you fork arcanist for your install?

Jan 6 2017, 8:39 AM · Restricted Project, Arcanist
• s935l4h added a watcher for Maniphest: • s935l4h.
Jan 6 2017, 6:58 AM
0 added a comment to T11816: Calendar: Feedback and Suggestions.

When I try to make E1211 recurring (see screenshot below), I get

Jan 6 2017, 5:28 AM · Restricted Project, Calendar
cos created T12074: conduit API extensions for subprojects and milestones..
Jan 6 2017, 5:01 AM · Feature Request
chad added a comment to T12072: Tighten "Needs Review" category.

See also T4144#175505

Jan 6 2017, 4:17 AM · Feature Request (Needs Information)
chad edited projects for T12072: Tighten "Needs Review" category, added: Feature Request (Needs Information); removed Feature Request.
Jan 6 2017, 3:29 AM · Feature Request (Needs Information)
chad added a comment to T12072: Tighten "Needs Review" category.

Please read and follow the guidelines in Contributing Feature Requests, this should have been at the top of the Feature Request form (see below). Unfortunately we're not able to take requests that don't state a root problem.

Jan 6 2017, 3:28 AM · Feature Request (Needs Information)
csilvers closed T12073: Phabricator does not change status to accepted if you comment when you accept as Resolved.

n/m, I see this was fixed today with https://secure.phabricator.com/rP1f2306999bb599bcedc0c4bfff2f2b3aade58630

Jan 6 2017, 12:50 AM · Differential, Bug Report
epriestley added a comment to T12073: Phabricator does not change status to accepted if you comment when you accept.

I think this should be fixed by D17146, which landed a few hours ago. Presumably you're running some ancient stone-age version of Phabricator that's 6 or more hours old?

Jan 6 2017, 12:46 AM · Differential, Bug Report
csilvers added a comment to T12073: Phabricator does not change status to accepted if you comment when you accept.

download.png (4×1 px, 844 KB)

Jan 6 2017, 12:45 AM · Differential, Bug Report
csilvers added a comment to T12073: Phabricator does not change status to accepted if you comment when you accept.

Jan 6 2017, 12:44 AM · Differential, Bug Report
csilvers created T12073: Phabricator does not change status to accepted if you comment when you accept.
Jan 6 2017, 12:40 AM · Differential, Bug Report
zachary added a comment to T12072: Tighten "Needs Review" category.

P.S. I love the new categories, they're my favorite improvement in the last year!

Jan 6 2017, 12:32 AM · Feature Request (Needs Information)
zachary created T12072: Tighten "Needs Review" category.
Jan 6 2017, 12:31 AM · Feature Request (Needs Information)
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

I think I got all of these, but yell if you catch any more.

Jan 6 2017, 12:27 AM · PHUI, Bug Report
epriestley closed T10687: jx-tooltip does whatever it feels like as Resolved by committing Restricted Diffusion Commit.
Jan 6 2017, 12:03 AM · PHUI, Bug Report
epriestley closed T12064: Tooltip for "Preview" in comment box overflows horizontally as Resolved by committing Restricted Diffusion Commit.
Jan 6 2017, 12:03 AM · Bug Report

Jan 5 2017

jcarrillo7 added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

We keep hitting the same thing where a conduit reports an svn commit for "sourceControlBaseRevision" on a repo that is git (was originally svn and was transferred to git).

Jan 5 2017, 11:28 PM · Restricted Project, Arcanist
jcarrillo7 awarded T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang a Heartbreak token.
Jan 5 2017, 11:27 PM · Restricted Project, Arcanist
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

This should do it:

Jan 5 2017, 11:10 PM · Daemons, Bug Report
ftdysa added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Yep, here is the default value on all the installs of PHP I've done from source:

Jan 5 2017, 11:02 PM · Daemons, Bug Report
csilvers added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Am glad to get ahead of it. What's the exact incantation we need to put into our php.ini?

Jan 5 2017, 11:01 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

(After T12071 we will almost certainly require "E", so you could get ahead of that now.)

Jan 5 2017, 10:54 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Actually, it looks like PHP defaults to "EGPCS" but ships with config files that use "GPCS" (??? why would you do this ???), so this is probably not something that got changed or configured intentionally or accidentally.

Jan 5 2017, 10:53 PM · Daemons, Bug Report
epriestley closed T12070: phd no longer recognizes PHABRICATOR_ENV? as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 10:48 PM · Daemons, Bug Report
epriestley closed T12070: phd no longer recognizes PHABRICATOR_ENV?, a subtask of T12071: Require "E" be defined in variables_order so $_ENV is correctly populated, as Resolved.
Jan 5 2017, 10:48 PM · Infrastructure
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Perfect, thanks! That's what I expected, so D17148 should resolve this. Alternatively, setting that value to "EGPCS" (without upgrading, just restarting the daemons) should also resolve this.

Jan 5 2017, 10:48 PM · Daemons, Bug Report
csilvers added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.
ubuntu@phabricator:~$ php -i | grep variables_order
variables_order => GPCS => GPCS
Jan 5 2017, 10:46 PM · Daemons, Bug Report
epriestley added a comment to T12069: `arc diff --reviewers` inserts reviewers twice..

I believe this is now fixed at HEAD of master. You should be able to pick up the change with arc upgrade now (if you run master) or in about 36 hours (if you run stable).

Jan 5 2017, 10:36 PM · Arcanist, Bug Report
epriestley closed T12069: `arc diff --reviewers` inserts reviewers twice. as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 10:35 PM · Arcanist, Bug Report
epriestley added a project to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated: Infrastructure.
Jan 5 2017, 10:35 PM · Infrastructure
epriestley added a revision to T12070: phd no longer recognizes PHABRICATOR_ENV?: Unknown Object (Differential Revision).
Jan 5 2017, 10:33 PM · Daemons, Bug Report
epriestley added a revision to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated: Unknown Object (Differential Revision).
Jan 5 2017, 10:33 PM · Infrastructure
epriestley added a parent task for T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0: T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.
Jan 5 2017, 10:30 PM · Bug Report
epriestley added a subtask for T12071: Require "E" be defined in variables_order so $_ENV is correctly populated: T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0.
Jan 5 2017, 10:30 PM · Infrastructure
epriestley added a subtask for T12071: Require "E" be defined in variables_order so $_ENV is correctly populated: T12070: phd no longer recognizes PHABRICATOR_ENV?.
Jan 5 2017, 10:27 PM · Infrastructure
epriestley added a parent task for T12070: phd no longer recognizes PHABRICATOR_ENV?: T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.
Jan 5 2017, 10:27 PM · Daemons, Bug Report
epriestley created T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.
Jan 5 2017, 10:27 PM · Infrastructure
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

While I'm chasing this down, can you show me the output of this command?

Jan 5 2017, 10:26 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

This is an unintended side effect of D17100 but resolution isn't straightforward.

Jan 5 2017, 10:14 PM · Daemons, Bug Report
csilvers created T12070: phd no longer recognizes PHABRICATOR_ENV?.
Jan 5 2017, 10:02 PM · Daemons, Bug Report
epriestley added a revision to T12069: `arc diff --reviewers` inserts reviewers twice.: Unknown Object (Differential Revision).
Jan 5 2017, 10:01 PM · Arcanist, Bug Report
epriestley added a comment to T12069: `arc diff --reviewers` inserts reviewers twice..

This is D17122 interacting with some extremely high-quality code in arc.

Jan 5 2017, 9:56 PM · Arcanist, Bug Report
tsy awarded T12060: Colorblind accessibility for red/green highlighting in e-mails a Love token.
Jan 5 2017, 9:50 PM · Accessibility, Design, Feature Request, Restricted Project
csilvers created T12069: `arc diff --reviewers` inserts reviewers twice..
Jan 5 2017, 9:50 PM · Arcanist, Bug Report
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 5 2017, 7:17 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12068: Inbound Emails View Mail Body shows the wrong command as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 4:59 PM · Bug Report
epriestley closed T12067: Inbound Email Reply-to not set correctly as Invalid.

This is far afield from an actionable bug report.

Jan 5 2017, 4:58 PM · Bug Report
epriestley added a revision to T10687: jx-tooltip does whatever it feels like: Unknown Object (Differential Revision).
Jan 5 2017, 4:53 PM · PHUI, Bug Report
epriestley added a revision to T12064: Tooltip for "Preview" in comment box overflows horizontally: Unknown Object (Differential Revision).
Jan 5 2017, 4:53 PM · Bug Report
pouyana added a comment to T12067: Inbound Email Reply-to not set correctly.

Yeah, There is no postfix, but my distro (SUSE Linux Enterprise) sendmail is a postfix variant. I have to match your sendmail config to my postfix. The last part was done with the help of canonical which is wrong way to do it probably. If it is too much work to debug this just drop it. It seems to be a very special case of configuration, server variant.

Jan 5 2017, 4:42 PM · Bug Report
lyngvi added a comment to T7477: Handle inbound email with phabricator address in the CC.

Patch attached which addresses this - filter and object selection done on a new getToOrCCAddresses call. This patch is based off stable branch commit 58375fa9e6db4a389fd6029ee1ad14ddb0dc9e90.

Jan 5 2017, 4:30 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T12067: Inbound Email Reply-to not set correctly.

Using postfix instead of sendmail

Jan 5 2017, 4:21 PM · Bug Report
pouyana updated the task description for T12067: Inbound Email Reply-to not set correctly.
Jan 5 2017, 3:58 PM · Bug Report
pouyana added a comment to T12067: Inbound Email Reply-to not set correctly.

Sorry for the typos :D, Step by Step Guide:
Follow this: https://secure.phabricator.com/book/phabricator/article/configuring_inbound_email/#local-mta-installing-mai (Local MTA Section)

Jan 5 2017, 3:58 PM · Bug Report
pouyana renamed T12067: Inbound Email Reply-to not set correctly from Inbound Email Replay-to not set correctly to Inbound Email Reply-to not set correctly.
Jan 5 2017, 3:54 PM · Bug Report
epriestley added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

We could possibly remove it entirely since I think it isn't useful for 99% of users, but D17144 just fixes the command.

Jan 5 2017, 3:40 PM · Bug Report