Funny, never knew we put that text in that drop down.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 5 2017
Sorry, Step By Step Guide:
That one is somewhat interesting because the user created a safe-looking object, then edited the objectionable content into it. I had hoped we might see a few years of uneasy peace before things escalated so far.
Please read Contributing Bug Reports carefully, specifically we require a complete, easy to follow and under.stand, set of steps to reproduce the problem.
Please read Contributing Bug Reports carefully, specifically we require a complete, easy to follow and under.stand, set of steps to reproduce the problem. I also don't understand what you're saying the bug in Phabricator is.
- Paste the patch into a $FILE
- cd $PHABRICATOR_SRC
- patch -p1 < $FILE
Endless war continues with E1323 😉
On my laptop it triggers either to the right of the preview icon or to the bottom, on my desktop, it does top, and gets jittery.
I think this really is the same as T10687, but the jittery bad degenerate behavior is only when a scrollbar gets added, so probably laptop + mouse works to repro but not laptop + touchpad?
Thanks for the excellent bug report with high-quality reproduction steps. Your clear, thorough reproduction steps made fixing this issue extremely easy!
Cry in vain this step is optional.
Specifically, this was already improved by D15726 in April 2016.
This doesn't appear to be a valid Feature Request or Bug Report. See Support Resources for how to get support using Phabricator.
Actually, this is a haunt mode bug, I'll update the description with a full set of reproducible steps.
Jan 4 2017
The revision editor and diff editor should no longer be racing to edit the diff. The two revision editors may be racing now, but that race is significantly easier to resolve if it crops up.
This should work again now. The behavior probably needs refinement -- I don't remember exactly where we left it and I think there was some disagreement about who should or shouldn't receive build failure notifications before D10911 accidentally disabled this, but I think T9892 and other Harbormaster tasks discuss most of that.
Chrome upstream has patched this, now:
From elsewhere:
They said it's a definite improvement. Nice!
Thanks for the quick response! I'll send that last image over to our user, and see if it's an improvement for them as well.
I'm not actually sure which will end up being easier, I think they have like 95% of the same problems. Quick Create probably is a bit easier, though.
I really want a small remarkup block sometimes.
Haha, maybe it's like when Blizzard uses a simulator to build a colorblind mode they screw it up, therefor the simulator must not work?
He said simulators don't work well... but I'm like (how would you know................)
Ah, cool. I'm 100% onboard with it if an actual affected user has confirmed that the change is good, I'm just really uneasy about accessibility changes that don't actually involve the affected users.
I'm working with a color blind designer in another chat channel, they're looking over my work. We don't think it's needed.
Do you specifically not want to add a red-green colorblind mode to the existing "Accessibility" settings?
I think I'd learn, if that's the way I always saw red/green.
If a change only had one of those colors (e.g., just one added section, or just one removed section) I think I'd have no clue if it was removed-red or added-red.
I'm for whichever is easiest, since the other will fall in line quickly after.
I think I can get by just tweaking the red/green current diff colors.
You were thinking about doing this one first, then Home later, right?
That's easy to add, but I'd worry it will result in much worse readability for all users for diffs with a lot of small corrections. If there are just 1-2 big edits the extra "+" and "-" probably aren't a big deal, but choppier edits will get a lot of extra annotation.
100% accurate mockup of this feature
Yeah I'm wondering if a quick patch for this is just add + and - to the prose diffs.
I'm hesitant about using math to solve this because I think Blizzard did that in Overwatch (apparently? or something?) and ended up with modes that were worse for colorblind users than users with normal vision:
I wonder we could solve this with math since most colors are stored as hex (we'd have to move diff colors to hex, but that's not a huge deal).
@epriestley I feel like we had this conversation on how to implement this somewhere... (on a diff)? Not sure where these extend from, just move it into Personal/Global settings?
What version of Phabricator are you running? See Providing Version Information for help.
Cool, glad things are back in working order. Thanks for following up.
This can be closed as invalid (or resolved I guess). Looks like we performed an install and some upgrades at an awkward time when some storage upgrade changes were occurring. We've run several stable branch updates on the install since and it's been fine.
Slack has some nice color blind themes, which I use as my normal theme.
I believe this reproduces by following the steps in T11537#192019, but deleting all timestamp information completely.
This is working as intended.
Thanks for the extended tip
I just tried it on GitHub an see that you're right. I guess this finally shifts this task into the feature request area, for which I would like to present the root cause: What I actually tried to achieve, when searching for for "PhabricatorProfilePanel", was to figure out in which commit this symbol got removed from Phabricator, so as to know how to change my extension's code (T10308#205605) to make it work with current Phabricator.
What color scheme would the user prefer?
Okay, after some tests, looks like the user has deuteranopia. Consistent with what you have there.
Of the four, this is the only type that's difficult:
Uh, I'll see if they can take an online test to narrow it down further.
They don't know what type they have more specifically than red-green, unfortunately.
There are 4 types of red-green color blindness, and they all work differently.

