Page MenuHomePhabricator
Feed Advanced Search

Jun 15 2021

artms added a comment to D21673: Saturate day of month in datepicker.

Wondering if you saw:

Effective June 1, 2021: Phabricator is no longer actively maintained.
Jun 15 2021, 7:34 PM

Mar 16 2021

artms added inline comments to D21622: Avoid possible HarbormasterBuildCommand leaks during job restarts.
Mar 16 2021, 11:51 AM
artms updated the summary of D21622: Avoid possible HarbormasterBuildCommand leaks during job restarts.
Mar 16 2021, 11:49 AM
artms requested review of D21622: Avoid possible HarbormasterBuildCommand leaks during job restarts.
Mar 16 2021, 11:49 AM

Jan 28 2021

artms added a comment to T13596: "INSERT INTO ... SELECT" queries require more database locks than "SELECT" queries.

Repeatable read is required if statement based replication is used - if row replication is used - repeatable read is no longer a requirement for replication consistency...

Jan 28 2021, 9:38 AM · Infrastructure, Projects

Jan 13 2021

artms added inline comments to D14148: Allow Drydock leases to expire after a time limit.
Jan 13 2021, 1:34 PM

Nov 6 2020

artms requested review of D21492: Fix php code example for conduit calls.
Nov 6 2020, 7:49 PM
artms added a comment to D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.

On my personal resource limited RasberryPI alike server (4x1.2ghz ARM A53, 2GB ram, php 7.4.12) running Phabricator - this changes saves ~15ms of runtime (180ms vs 167ms after) when running:

./bin/herald test --object T19 --type HeraldManiphestTaskAdapter
Nov 6 2020, 7:38 PM
artms updated the diff for D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.

Rebase

Nov 6 2020, 7:33 PM
artms requested review of D21049: Add Email command to mute notifications for object.
Nov 6 2020, 7:11 PM
artms abandoned D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.

This change is probably no longer relevant with recent large refactoring of arcanist

Nov 6 2020, 7:10 PM
artms requested review of D21048: Do not count hidden changesets as changed changesets during diff comparison.
Nov 6 2020, 7:07 PM
artms updated subscribers of D21491: Handle case when Differential Revision diff is an empty commit.
Nov 6 2020, 7:03 PM
artms requested review of D21491: Handle case when Differential Revision diff is an empty commit.
Nov 6 2020, 7:01 PM
artms requested review of D21490: Empty commit change.
Nov 6 2020, 6:51 PM

Oct 22 2020

artms added a comment to D21287: Fix an issue where inline comments with only edit suggestions are considered empty.

@epriestley - empty inline comment with suggestion renders rather peculiar transaction which is somewhat confusing and odd... Any plans on tackling it? Like See context greyed out...

image.png (155×1 px, 21 KB)

Oct 22 2020, 9:02 AM

Aug 20 2020

artms requested review of D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Aug 20 2020, 5:58 AM
artms planned changes to D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Aug 20 2020, 5:58 AM

Aug 5 2020

artms added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.

I'm not aware of any current customer use cases for this behavior. I'm open to restoring it if customers are actually using it, but would like to make sure the API is fully supporting whatever the need is.

Aug 5 2020, 6:55 PM
artms added a comment to D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.

What is now programmatical way to "submit" unsubmitted inline comments? Some users are using it to post comments from bots, now if we use differential.createinline api method all bot comments are visible as unsubmitted and looks like there is no way to set it in stone...

Aug 5 2020, 11:39 AM

Apr 7 2020

artms closed T13506: Task to test breaking remarkup as Invalid.
Apr 7 2020, 10:46 AM
artms triaged T13506: Task to test breaking remarkup as Wishlist priority.
Apr 7 2020, 10:45 AM

Apr 3 2020

artms edited 2 auditor(s) for rARC4d55067fd87f: Make the "result" property on Future private, removed 1: artms; added 1: epriestley.
Apr 3 2020, 1:53 PM
artms raised a concern with rARC4d55067fd87f: Make the "result" property on Future private.

This is breaking commit breaks drydock: PHP Fatal error: Cannot override final method Future::getResult() in /core/data/drydock/workingcopy-75/repo/phabricator/src/applications/harbormaster/future/HarbormasterExecFuture.php on line 50

Apr 3 2020, 1:40 PM

Apr 2 2020

artms added inline comments to D21034: Make the "result" property on Future private.
Apr 2 2020, 2:54 PM
artms added inline comments to D21034: Make the "result" property on Future private.
Apr 2 2020, 2:54 PM

Mar 9 2020

artms updated the diff for D21040: According to Jira Project keys must start with an uppercase letter, followed by one or more uppercase alphanumeric characters.
  • Fix pattern
Mar 9 2020, 2:37 PM
artms requested review of D21040: According to Jira Project keys must start with an uppercase letter, followed by one or more uppercase alphanumeric characters.
Mar 9 2020, 1:26 PM

Feb 10 2020

artms added inline comments to D20973: Fix diffusion.branchquery returning dictionary instead of array when branches are filtered out.
Feb 10 2020, 1:26 PM
artms requested review of D20973: Fix diffusion.branchquery returning dictionary instead of array when branches are filtered out.
Feb 10 2020, 1:25 PM
artms updated the test plan for D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Feb 10 2020, 9:30 AM
artms requested review of D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Feb 10 2020, 9:29 AM

Jan 14 2020

artms added a comment to T5422: Does Phabricator integrate with JIRA?.

In jira 8.6.1 settings are now in:

  • AdministrationApplicationsApplication links
Jan 14 2020, 3:31 PM · Guides, Doorkeeper

Dec 17 2019

artms created T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/.
Dec 17 2019, 8:02 AM

Dec 13 2019

artms created T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.
Dec 13 2019, 10:44 AM · Herald

Dec 10 2019

artms committed rP4cd333b33fb1: Use same method to get object URI as used in DifferentialTransactionEditor and… (authored by artms).
Use same method to get object URI as used in DifferentialTransactionEditor and…
Dec 10 2019, 3:37 PM
artms closed D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Dec 10 2019, 3:37 PM

Dec 9 2019

artms requested review of D20936: Pass context object to PhabricatorMetaMTAMailBody as this is done in parent class.
Dec 9 2019, 11:32 AM
artms updated the test plan for D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Dec 9 2019, 11:31 AM
artms requested review of D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Dec 9 2019, 11:28 AM

Nov 28 2019

artms created T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.
Nov 28 2019, 10:57 AM · Differential

Nov 7 2019

artms abandoned D20891: Jupyter notebook.
Nov 7 2019, 1:50 PM
artms requested review of D20891: Jupyter notebook.
Nov 7 2019, 1:49 PM

Oct 31 2019

artms added a comment to D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

Reproduction script for some working checked out repository on master and repository permanentRefs is master:

head -c 20 /dev/random | base64 > giberish
git add -A
git commit -m 'Add giberish'
HEAD=$(git rev-list --reverse HEAD~..HEAD)
title=$(git log -n1 --pretty=format:%s HEAD)
title_q=$(printf '%s' "$title" | jq --raw-input --slurp .)
rawdiff=$(git diff-tree --root --cc --no-commit-id HEAD|jq --raw-input --slurp .)
diffid=$(echo "{\"diff\":${rawdiff}}" | arc call-conduit differential.createrawdiff | jq -e -r .response.id )
revid=$(echo "{\"diffid\": $diffid, \"fields\":{\"title\": $title_q}}" | arc call-conduit differential.createrevision | jq -r .response.revisionid)
git push origin HEAD:refs/heads/non-permanent-refs/D$revid
arc diff -m 'Message' --update $revid --head $HEAD "${HEAD}^"
sleep 60
# make sure pushed branch is parsed and then push changes, need to make sure metadata Differential Revision is not added so we cannot use `arc land` here
git push origin master
Oct 31 2019, 8:58 PM
artms added a comment to D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

I will try to provide a script to reproduce flow one of our tools does while creating this regresion some time later today/tonight.

Oct 31 2019, 4:38 PM
artms added a comment to D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

Oh, sorry, I think I misunderstood what you're describing in your test plan -- you're saying that you're currently observing the revision not closing, and believe this fixes it. I'll see if I can reproduce this.

Oct 31 2019, 4:32 PM
artms added inline comments to D20428: When a commit appears as an ancestor of a permanent ref for the first time, run all import steps.
Oct 31 2019, 3:05 PM
artms requested review of D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.
Oct 31 2019, 3:04 PM

Oct 30 2019

artms committed rPbcf15abcd33c: Return empty data if fact dimension is missing, not yet available (authored by artms).
Return empty data if fact dimension is missing, not yet available
Oct 30 2019, 2:34 PM
artms closed D20861: Return empty data if fact dimension is missing, not yet available.
Oct 30 2019, 2:34 PM

Oct 22 2019

artms added a task to D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality: T13416: Transaction logs may overheat explosively.
Oct 22 2019, 7:43 AM
artms added a revision to T13416: Transaction logs may overheat explosively: D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.
Oct 22 2019, 7:43 AM · Feed

Oct 21 2019

artms requested review of D20861: Return empty data if fact dimension is missing, not yet available.
Oct 21 2019, 1:38 PM

Oct 18 2019

artms added a comment to T13427: Task to reproduce lack of transaction object validation.

Thanks!

Oct 18 2019, 6:35 AM · artms

Oct 17 2019

epriestley closed T13427: Task to reproduce lack of transaction object validation as Resolved.

This now renders properly; see T13429 for followup.

Oct 17 2019, 5:03 PM · artms

Oct 14 2019

artms added a project to T13427: Task to reproduce lack of transaction object validation: artms.
Oct 14 2019, 11:46 AM · artms
artms created T13427: Task to reproduce lack of transaction object validation.
Oct 14 2019, 11:45 AM · artms

Oct 10 2019

artms requested review of D20856: Allow partial response of transaction history if it is overheating.
Oct 10 2019, 1:48 PM

Oct 9 2019

artms requested review of D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.
Oct 9 2019, 8:01 AM

Oct 2 2019

artms committed rP960c447aab7f: Support more than 9 portals (authored by artms).
Support more than 9 portals
Oct 2 2019, 7:36 PM
artms closed D20852: Support more than 9 portals.
Oct 2 2019, 7:36 PM
artms requested review of D20852: Support more than 9 portals.
Oct 2 2019, 7:32 PM

Sep 23 2019

artms renamed T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error from Conduit log paging is broken to Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error.
Sep 23 2019, 12:26 PM · Conduit
artms created T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error.
Sep 23 2019, 12:26 PM · Conduit

Jul 23 2019

artms committed rPcd449254256d: Allow users with no CAN_EDIT permissions to silence projects if they want to (authored by artms).
Allow users with no CAN_EDIT permissions to silence projects if they want to
Jul 23 2019, 10:14 AM
artms closed D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Jul 23 2019, 10:14 AM

Jul 22 2019

artms requested review of D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Jul 22 2019, 11:09 AM

Feb 6 2019

artms renamed T13246: Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"` from Phriction search has issues with paging and crashes with `PhrictionDocumentQuery" failed to return a value from getPagingValueMap() for column "rank"` to Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"`.
Feb 6 2019, 10:14 AM
artms added a comment to T13246: Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"`.

Forgot to mention that ordering set is relevance and also same issue happens if you search in maniphest, eg.: https://secure.phabricator.com/maniphest/query/Gk8I9e13KiTw/?after=12975

Feb 6 2019, 10:13 AM
artms updated the task description for T13246: Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"`.
Feb 6 2019, 9:58 AM
artms created T13246: Phabricator search has issues with paging when `relevance` ordering is chosen and crashes with `failed to return a value from getPagingValueMap() for column "rank"`.
Feb 6 2019, 9:58 AM

Sep 19 2018

artms added a comment to D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.

Uh, sorry, didn't mean to step on toes, take your time :) Just wanted to share/upstream our findings which improve overall performance for large phab installations

Sep 19 2018, 5:22 PM

Sep 18 2018

artms added a comment to D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.

Anything? This improves herald rule performance...

Sep 18 2018, 7:55 AM
artms abandoned D9642: Add phriction.new conduit endpoint.
Sep 18 2018, 7:55 AM

Sep 12 2018

Pawka awarded D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check a Yellow Medal token.
Sep 12 2018, 12:45 PM
artms updated the test plan for D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.
Sep 12 2018, 11:20 AM
artms added inline comments to D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.
Sep 12 2018, 11:19 AM
artms requested review of D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.
Sep 12 2018, 11:16 AM

Aug 3 2018

artms awarded D19559: Deprecate Conduit method "diffusion.getrecentcommitsbypath" a Like token.
Aug 3 2018, 6:40 AM

Aug 2 2018

artms committed rP356b2781bcad: Gracefully fail request if non existing callsign is passed to… (authored by artms).
Gracefully fail request if non existing callsign is passed to…
Aug 2 2018, 4:49 PM
artms closed D19558: Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing.
Aug 2 2018, 4:49 PM
artms added a comment to D19558: Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing.

Uh, we had couple of cases and this caused extra 500s in logs...

Aug 2 2018, 4:48 PM
artms requested review of D19558: Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing.
Aug 2 2018, 2:46 PM
artms committed rP4c09e88c9582: Add parsing for ssh options (-o) which are passed when using GIT v2 wire… (authored by artms).
Add parsing for ssh options (-o) which are passed when using GIT v2 wire…
Aug 2 2018, 1:43 PM
artms closed D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
Aug 2 2018, 1:43 PM

Aug 1 2018

artms updated the diff for D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
  • Throw error if unknown ssh option is passed
Aug 1 2018, 11:45 AM

Jul 30 2018

artms added inline comments to D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
Jul 30 2018, 9:33 AM
artms updated the diff for D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
  • Allow only SendEnv=GIT_PROTOCOL ssh option
Jul 30 2018, 9:31 AM
artms planned changes to D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
Jul 30 2018, 8:02 AM

Jul 27 2018

artms updated the diff for D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).

Old arcanist

Jul 27 2018, 7:55 AM
artms requested review of D19542: Add parsing for ssh options (-o) which are passed when using GIT v2 wire protocol by git command (SSH transport).
Jul 27 2018, 7:51 AM

Jan 20 2015

artms added a comment to D11296: Lets really skip item and not spin in loop....

Guys any progress with it... It is really hitting pull workers hard which spin in loop doing nothing but spaming logs about repository not pullable anymore...

Jan 20 2015, 7:59 AM

Jan 9 2015

artms requested review of D9642: Add phriction.new conduit endpoint.
Jan 9 2015, 11:48 AM
artms planned changes to D9642: Add phriction.new conduit endpoint.
Jan 9 2015, 11:47 AM
artms added inline comments to D11296: Lets really skip item and not spin in loop....
Jan 9 2015, 11:45 AM
artms retitled D11296: Lets really skip item and not spin in loop... from to Lets really skip item and not spin in loop....
Jan 9 2015, 11:40 AM

Jun 27 2014

artms added a comment to D9642: Add phriction.new conduit endpoint.

Any progress?

Jun 27 2014, 9:55 AM

Jun 20 2014

artms added a comment to D9642: Add phriction.new conduit endpoint.

Thanks @chad for a tip!

Jun 20 2014, 6:11 PM
artms updated the diff for D9642: Add phriction.new conduit endpoint.

Fixing lint issues

Jun 20 2014, 6:10 PM
artms added inline comments to D9642: Add phriction.new conduit endpoint.
Jun 20 2014, 3:41 PM