Paths

Table of Contentst

Differential D19558

Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing
ClosedPublic
Actions

Authored by artms on Aug 2 2018, 2:45 PM.

Details

Reviewers

Pawka
epriestley

Group Reviewers

Blessed Reviewers

Commits

rP356b2781bcad: Gracefully fail request if non existing callsign is passed to…

Summary

diffusion.getrecentcommitsbypath fails with 500 error when non existing callsign is passed:

>>> UNRECOVERABLE FATAL ERROR <<<

Call to a member function getCommit() on null

Expected Behavior:
Return more graceful error notifying caller that such callsign/repository does not exist

Reproduction steps:
Open conduit: https://secure.phabricator.com/conduit/method/diffusion.getrecentcommitsbypath/
Enter:
callsign: "obviouslynotexisting"
path: "/random"
Click call method

Test Plan

after applying patch - call no longer fails with 500s

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

artms created this revision.Aug 2 2018, 2:45 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 2 2018, 2:45 PM

artms edited the summary of this revision. (Show Details)Aug 2 2018, 2:46 PM

Harbormaster completed remote builds in B20559: Diff 46760.Aug 2 2018, 2:46 PM

artms requested review of this revision.Aug 2 2018, 2:46 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 2 2018, 2:46 PM

This doesn't have any callers and should probably be frozen/deprecated, but this change won't hurt anything.

This revision is now accepted and ready to land.Aug 2 2018, 2:50 PM

Uh, we had couple of cases and this caused extra 500s in logs...

Closed by commit rP356b2781bcad: Gracefully fail request if non existing callsign is passed to… (authored by artms). · Explain WhyAug 2 2018, 4:49 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19559: Deprecate Conduit method "diffusion.getrecentcommitsbypath".Aug 2 2018, 11:39 PM

epriestley mentioned this in rP3574a55a95bd: Deprecate Conduit method "diffusion.getrecentcommitsbypath".Aug 3 2018, 4:49 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionGetRecentCommitsByPathConduitAPIMethod.php

10 lines

Diff 46761

View Options

src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php

Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashingClosedPublicActions