Page MenuHomePhabricator
Differential D19559

Deprecate Conduit method "diffusion.getrecentcommitsbypath"
ClosedPublic
Actions

Authored by epriestley on Aug 2 2018, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 3:49 PM
Unknown Object (File)
Tue, Apr 30, 4:48 PM
Unknown Object (File)
Sat, Apr 27, 3:53 AM
Unknown Object (File)
Sat, Apr 20, 4:05 AM
Unknown Object (File)
Thu, Apr 18, 10:40 AM
Unknown Object (File)
Mar 25 2024, 6:50 PM
Unknown Object (File)
Feb 21 2024, 7:44 PM
Unknown Object (File)
Feb 3 2024, 7:12 PM
View All 86 Files
Subscribers
artms
Tokens
"Like" token, awarded by artms.

Details

Reviewers
amckinley
Commits
rP3574a55a95bd: Deprecate Conduit method "diffusion.getrecentcommitsbypath"
Summary

See D19558. This method has no callers and just wraps diffusion.historyquery, since D5960 (2013).

This was introduced in D315 (which didn't make it out of FB, I think) inside Facebook for unclear purposes in 2011.

Test Plan

Grepped for callers, found none.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 2 2018, 11:39 PM
Harbormaster completed remote builds in B20561: Diff 46762.Aug 2 2018, 11:40 PM
epriestley requested review of this revision.Aug 2 2018, 11:40 PM
amckinley accepted this revision.Aug 2 2018, 11:58 PM
This revision is now accepted and ready to land.Aug 2 2018, 11:58 PM
artms awarded a token.Aug 3 2018, 6:40 AM
epriestley added a comment.Aug 3 2018, 4:45 PM

(You probably have years until this disappears from the upstream since it's already implemented in terms of diffusion.historyquery and we don't generally remove methods without some specific reason, but if you have opportunities to migrate toward diffusion.historyquery it couldn't hurt.)

Closed by commit rP3574a55a95bd: Deprecate Conduit method "diffusion.getrecentcommitsbypath" (authored by epriestley). · Explain WhyAug 3 2018, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
8 lines

Diff 46763

View Options

src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility