Make the "result" property on Future private
4d55067fd87f
Actions

Description

Make the "result" property on Future private

Summary: Depends on D21033. Ref T11968. This is just an incremental step in modernizing Future and making it more robust. Currently, subclasses are expected to write directly to $this->result, but this isn't consistent with how modern classes generally work.

Test Plan: Ran unit tests, created this revision.

Maniphest Tasks: T11968

Differential Revision: https://secure.phabricator.com/D21034

Details

Provenance

epriestley	Authored on Feb 26 2020, 7:48 PM
epriestley	Pushed on Mar 29 2020, 5:18 PM

Differential Revision

D21034: Make the "result" property on Future private

Parents

rARCe20dce875cf2: Resolve all futures inside FutureIterator

Branches

Unknown

Tags

Unknown

Tasks

T11968: Decide the fate of FutureGraph

Build Status

Buildable 23959
Build 32970: Run Core Tests

Event Timeline

epriestley committed rARC4d55067fd87f: Make the "result" property on Future private (authored by epriestley).Mar 29 2020, 5:18 PM

epriestley added a task: T11968: Decide the fate of FutureGraph.

epriestley added an edge: D21034: Make the "result" property on Future private.

Harbormaster completed building B23959: rARC4d55067fd87f: Make the "result" property on Future private.Mar 29 2020, 5:18 PM

This is breaking commit breaks drydock: PHP Fatal error: Cannot override final method Future::getResult() in /core/data/drydock/workingcopy-75/repo/phabricator/src/applications/harbormaster/future/HarbormasterExecFuture.php on line 50

This commit now has outstanding concerns.Apr 3 2020, 1:40 PM

artms edited auditors, removed: artms; added: epriestley.Apr 3 2020, 1:53 PM

This commit now requires audit.Apr 3 2020, 1:53 PM

epriestley removed an auditor: epriestley.Apr 3 2020, 2:03 PM

This commit no longer requires audit.Apr 3 2020, 2:03 PM