Page MenuHomePhabricator
Feed Advanced Search

Jul 5 2019

amckinley closed T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()" as Resolved by committing rP3c4322252513: Fix paging fatal with flagged objects.
Jul 5 2019, 9:25 PM · Flags

Jul 4 2019

amckinley added a comment to T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".

Thanks for the report. Fixed in D20642, which may or may not land today because of the holiday.

Jul 4 2019, 11:02 PM · Flags
amckinley added a revision to T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()": D20642: Fix paging fatal with flagged objects.
Jul 4 2019, 11:01 PM · Flags
amckinley claimed T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".
Jul 4 2019, 10:40 PM · Flags
aklapper created T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".
Jul 4 2019, 2:49 PM · Flags

May 3 2019

epriestley closed T7703: Policy checks may execute incompletely for non-viewers as Resolved.

Although I'm not entirely confident that 100% of objects which should implement ExtendedPolicyInterface actually do today, I think we've gotten pretty much all of them. This approach also seems stable.

May 3 2019, 4:53 AM · Policy, Herald, Flags

Jan 26 2018

epriestley moved T9149: Flagging commits via Herald no longer generates flag note from Backlog to Future on the Herald board.
Jan 26 2018, 5:51 PM · Restricted Project, Flags, Herald

Nov 23 2017

sshannin added a comment to T7703: Policy checks may execute incompletely for non-viewers.

I'm unable to close this, but I believe this to be resolved (or at least my specific repro of flags via herald no longer applies I believe).

Nov 23 2017, 3:37 AM · Policy, Herald, Flags

Jul 3 2017

epriestley placed T9084: Use a typeaheads for querying Object Types in Flags up for grabs.
Jul 3 2017, 2:13 PM · Contributor Onboarding, Flags

Mar 21 2017

chad closed T5307: UX for taking actions with search results, a subtask of T5529: Clear Flags on Accept, as Resolved.
Mar 21 2017, 2:13 AM · Flags

Jan 9 2017

chad added a comment to T5867: Move Quick Create to MenuItemEngine.

Started building and insanely easier as an application. "Favorites" unless you have a better suggestion. Seems more flexible.

Jan 9 2017, 4:25 AM · Design

Jan 6 2017

epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

Yep, that looks good to me.

Jan 6 2017, 7:11 PM · Design
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

Just for my own understanding:

Jan 6 2017, 7:11 PM · Design
chad added a revision to T5867: Move Quick Create to MenuItemEngine: D17149: Add CustomPHID to PhabricatorProfileMenuEngineConfiguration.
Jan 6 2017, 7:07 PM · Design
chad removed a parent task for T5867: Move Quick Create to MenuItemEngine: T11957: Add MenuEngine to Home.
Jan 6 2017, 5:05 PM · Design
chad removed a subtask for T5867: Move Quick Create to MenuItemEngine: T6049: Implement Phurl, a URL shortener/bookmarking application.
Jan 6 2017, 5:05 PM · Design
chad claimed T5867: Move Quick Create to MenuItemEngine.
Jan 6 2017, 4:59 PM · Design
chad merged T12030: Make Quick Create Menu configurable via MenuItem into T5867: Move Quick Create to MenuItemEngine.
Jan 6 2017, 4:58 PM · Design

Jan 4 2017

epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

I'm not actually sure which will end up being easier, I think they have like 95% of the same problems. Quick Create probably is a bit easier, though.

Jan 4 2017, 7:07 PM · Design
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

I'm for whichever is easiest, since the other will fall in line quickly after.

Jan 4 2017, 6:40 PM · Design
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

You were thinking about doing this one first, then Home later, right?

Jan 4 2017, 6:19 PM · Design
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

@epriestley I feel like we had this conversation on how to implement this somewhere... (on a diff)? Not sure where these extend from, just move it into Personal/Global settings?

Jan 4 2017, 5:21 PM · Design
chad raised the priority of T5867: Move Quick Create to MenuItemEngine from Wishlist to High.
Jan 4 2017, 5:20 PM · Design
chad renamed T5867: Move Quick Create to MenuItemEngine from Add Flags/Phurl dropdown to global header? to Move Quick Create to MenuItemEngine.
Jan 4 2017, 5:16 PM · Design

Dec 13 2016

epriestley added a parent task for T5867: Move Quick Create to MenuItemEngine: T11957: Add MenuEngine to Home.
Dec 13 2016, 11:47 AM · Design
epriestley added a project to T5657: Ability to rename flags: Contributor Onboarding.
Dec 13 2016, 11:41 AM · Contributor Onboarding, Restricted Project, Flags

Aug 7 2016

eadler added a project to T5657: Ability to rename flags: Restricted Project.
Aug 7 2016, 8:06 PM · Contributor Onboarding, Restricted Project, Flags

Aug 5 2016

eadler added a project to T7500: Documentation for flags: Restricted Project.
Aug 5 2016, 5:23 PM · Restricted Project, Flags, Documentation
eadler added a project to T8840: Flag query with color filter has inconsistent order: Restricted Project.
Aug 5 2016, 5:09 PM · Restricted Project, Flags

Jul 4 2016

eadler moved T9149: Flagging commits via Herald no longer generates flag note from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:18 PM · Restricted Project, Flags, Herald

Apr 17 2016

eadler moved T9149: Flagging commits via Herald no longer generates flag note from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 17 2016, 6:24 PM · Restricted Project, Flags, Herald

Apr 11 2016

eadler added a project to T9149: Flagging commits via Herald no longer generates flag note: Restricted Project.
Apr 11 2016, 9:41 PM · Restricted Project, Flags, Herald

Mar 15 2016

isfs added a comment to T10585: Add "Flag for Later" to projects/workboards.

Touché!

Mar 15 2016, 7:12 AM · Projects, Flags, Feature Request

Mar 14 2016

chad added a comment to T10585: Add "Flag for Later" to projects/workboards.

It was a bug that it disappeared.

Mar 14 2016, 10:20 PM · Projects, Flags, Feature Request
isfs added a comment to T10585: Add "Flag for Later" to projects/workboards.

Ah. Looks like I just needed to upgrade as this change was made in the last month or so (I last upgraded late Feb). Didn't see this change mentioned in the changelog, or a task for it, so assumed it still wasn't possible. What you have implemented is perfect for us. Sorry for the noise.

Mar 14 2016, 10:08 PM · Projects, Flags, Feature Request
chad closed T10585: Add "Flag for Later" to projects/workboards as Resolved.

Projects are flaggable under the manage page. We have no plans to make Workboards flaggable.

Mar 14 2016, 1:52 PM · Projects, Flags, Feature Request
isfs created T10585: Add "Flag for Later" to projects/workboards.
Mar 14 2016, 12:51 PM · Projects, Flags, Feature Request

Mar 9 2016

chad closed T10545: People and Projects are no longer flaggable as Resolved by committing rP2da9fcafbf7d: Update project manage page for two column.
Mar 9 2016, 5:11 PM · Flags, Bug Report
chad added a revision to T10545: People and Projects are no longer flaggable: D15450: Update project manage page for two column.
Mar 9 2016, 5:11 PM · Flags, Bug Report
chad added a revision to T10545: People and Projects are no longer flaggable: D15449: Convert people manage page to two column.
Mar 9 2016, 4:52 PM · Flags, Bug Report
dpaola2 created T10545: People and Projects are no longer flaggable.
Mar 9 2016, 1:36 AM · Flags, Bug Report

Jan 6 2016

epriestley updated subscribers of T9084: Use a typeaheads for querying Object Types in Flags.

Flags currently has this unwieldy dropdown, which will only get worse over time as more applications and object types are added. It would be better to use a typeahead, like the one in global search:

Jan 6 2016, 3:25 AM · Contributor Onboarding, Flags
epriestley moved T9084: Use a typeaheads for querying Object Types in Flags from Backlog to vNext on the Flags board.
Jan 6 2016, 3:21 AM · Contributor Onboarding, Flags
epriestley triaged T9149: Flagging commits via Herald no longer generates flag note as Low priority.

I removed this because the implementation was pretty hacky (saved the rule as a text string, wasn't translatable).

Jan 6 2016, 3:21 AM · Restricted Project, Flags, Herald
epriestley moved T9149: Flagging commits via Herald no longer generates flag note from Backlog to vNext on the Flags board.
Jan 6 2016, 3:18 AM · Restricted Project, Flags, Herald
epriestley moved T10084: Flag notes should be visible in object properties from Backlog to vNext on the Flags board.
Jan 6 2016, 3:18 AM · Flags, Feature Request
chad added a comment to T10084: Flag notes should be visible in object properties.

good enough for me

Jan 6 2016, 3:12 AM · Flags, Feature Request
epriestley updated subscribers of T10084: Flag notes should be visible in object properties.

@chad, not sure if you have design thoughts here, but I think this is broadly reasonable.

Jan 6 2016, 3:09 AM · Flags, Feature Request
epriestley renamed T10084: Flag notes should be visible in object properties from Flag notes should be visible in Maniphest UI to Flag notes should be visible in object properties.
Jan 6 2016, 2:54 AM · Flags, Feature Request
epriestley closed T10085: Phabricator should ask if it should remove a flag when the flag's owner changes a task as Wontfix.

I think it's too hard for us to guess user intent here. There's nothing a user can do which strongly signals that their flag is obsolete, since flags mean a lot of different things (in your use case, it sounds like there's no single action you take which clears the flag, just "the next action after you added the flag"). Other users (myself included) use flags for different reasons, including as long-term bookmarks. Guessing intent is also difficult because you can flag many kinds of objects, not just tasks, and we'd strongly prefer features which can be implemented globally.

Jan 6 2016, 2:50 AM · Flags, Feature Request
hach-que added a comment to T10084: Flag notes should be visible in object properties.

This would make flags actually useful. I think the last time I used them was years ago, and I've just been adding comments to tasks whenever I need to add personal reminders.

Jan 6 2016, 12:53 AM · Flags, Feature Request

Jan 5 2016

scfc created T10085: Phabricator should ask if it should remove a flag when the flag's owner changes a task.
Jan 5 2016, 10:22 AM · Flags, Feature Request
scfc created T10084: Flag notes should be visible in object properties.
Jan 5 2016, 10:19 AM · Flags, Feature Request

Dec 9 2015

epriestley removed a project from T5529: Clear Flags on Accept: Herald.
Dec 9 2015, 1:38 PM · Flags

Nov 21 2015

terrismotox merged T9825: Remarkup is rendered literally in Diviner into T9149: Flagging commits via Herald no longer generates flag note.
Nov 21 2015, 10:16 PM · Restricted Project, Flags, Herald

Nov 12 2015

michaeloa added a comment to T5867: Move Quick Create to MenuItemEngine.

As mentioned in T9775, we think this would be a very useful feature for those of us who need to work on multiple projects. Having it tied to the flags application would make it awesomely customizable (and make Flags a much more useful application).

Nov 12 2015, 10:59 PM · Design
chad renamed T5867: Move Quick Create to MenuItemEngine from Add Flags icon and dropdown to global header? to Add Flags/Phurl dropdown to global header?.
Nov 12 2015, 10:39 PM · Design
chad updated subscribers of T5867: Move Quick Create to MenuItemEngine.
Nov 12 2015, 10:35 PM · Design
chad merged T9775: Quick project navigation from the main UI into T5867: Move Quick Create to MenuItemEngine.
Nov 12 2015, 10:22 PM · Design
chad merged task T9775: Quick project navigation from the main UI into T5867: Move Quick Create to MenuItemEngine.
Nov 12 2015, 10:22 PM · Flags, Projects
michaeloa created T9775: Quick project navigation from the main UI.
Nov 12 2015, 9:36 PM · Flags, Projects

Aug 23 2015

joshuaspence claimed T9084: Use a typeaheads for querying Object Types in Flags.
Aug 23 2015, 11:29 AM · Contributor Onboarding, Flags
joshuaspence updated the task description for T9084: Use a typeaheads for querying Object Types in Flags.
Aug 23 2015, 11:28 AM · Contributor Onboarding, Flags

Aug 22 2015

joshuaspence added a project to T9179: flag queries cause exceptions: Flags.
Aug 22 2015, 8:31 AM · Flags
dpaola2 closed T8888: Ability to flag dashboards and users as Resolved.
Aug 22 2015, 12:18 AM · Flags

Aug 12 2015

aik099 updated the task description for T9149: Flagging commits via Herald no longer generates flag note.
Aug 12 2015, 3:40 PM · Restricted Project, Flags, Herald
aik099 created T9149: Flagging commits via Herald no longer generates flag note.
Aug 12 2015, 3:19 PM · Restricted Project, Flags, Herald

Aug 5 2015

chad triaged T9084: Use a typeaheads for querying Object Types in Flags as Low priority.
Aug 5 2015, 9:45 PM · Contributor Onboarding, Flags
joshuaspence created T9084: Use a typeaheads for querying Object Types in Flags.
Aug 5 2015, 9:44 PM · Contributor Onboarding, Flags

Jul 19 2015

joshuaspence added a comment to T8888: Ability to flag dashboards and users.
Jul 19 2015, 1:00 AM · Flags

Jul 18 2015

chad added a revision to T8888: Ability to flag dashboards and users: D13655: Make Passphrase Credentials Flaggable.
Jul 18 2015, 7:25 PM · Flags
chad added a revision to T8888: Ability to flag dashboards and users: D13654: Allow People to be Flagged.
Jul 18 2015, 7:18 PM · Flags
chad added a revision to T8888: Ability to flag dashboards and users: D13653: Make Countdown Flaggable.
Jul 18 2015, 7:12 PM · Flags
chad added a revision to T8888: Ability to flag dashboards and users: D13652: Make Dashboards and Panels Flaggable.
Jul 18 2015, 7:08 PM · Flags
eadler added a project to T8888: Ability to flag dashboards and users: Flags.
Jul 18 2015, 5:44 PM · Flags

Jul 14 2015

sshannin added a comment to T8840: Flag query with color filter has inconsistent order.

Specifically, it seems to order by color, but not by flag time within each color

Jul 14 2015, 9:04 PM · Restricted Project, Flags
sshannin created T8840: Flag query with color filter has inconsistent order.
Jul 14 2015, 3:59 PM · Restricted Project, Flags

Jun 1 2015

epriestley added a revision to T7703: Policy checks may execute incompletely for non-viewers: D13104: Add support for "Extended Policies".
Jun 1 2015, 9:44 PM · Policy, Herald, Flags
epriestley added a parent task for T7703: Policy checks may execute incompletely for non-viewers: T8377: Build the core "Spaces" Application.
Jun 1 2015, 9:37 PM · Policy, Herald, Flags
epriestley added a revision to T7703: Policy checks may execute incompletely for non-viewers: D13070: Add repositories to Diviner.
Jun 1 2015, 2:44 PM · Policy, Herald, Flags

Apr 28 2015

lpriestley closed T7947: Implement PhabricatorFlaggableInterface in Calendar as Resolved by committing rP39954c1eb6de: Calendar events should be flaggable.
Apr 28 2015, 10:27 PM · Flags, Calendar
lpriestley added a revision to T7947: Implement PhabricatorFlaggableInterface in Calendar: D12602: Calendar events should be flaggable.
Apr 28 2015, 10:22 PM · Flags, Calendar
lpriestley closed T5464: Use ApplicationTransactions in Calendar, a subtask of T7947: Implement PhabricatorFlaggableInterface in Calendar, as Resolved.
Apr 28 2015, 1:27 PM · Flags, Calendar

Apr 26 2015

epriestley moved T7947: Implement PhabricatorFlaggableInterface in Calendar from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 1:42 PM · Flags, Calendar
epriestley added a subtask for T7947: Implement PhabricatorFlaggableInterface in Calendar: T5464: Use ApplicationTransactions in Calendar.
Apr 26 2015, 1:35 PM · Flags, Calendar
epriestley created T7947: Implement PhabricatorFlaggableInterface in Calendar.
Apr 26 2015, 1:35 PM · Flags, Calendar

Apr 11 2015

epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

This seems structurally correct but is a lot of work.

Apr 11 2015, 8:23 PM · Policy, Herald, Flags
epriestley added a parent task for T7703: Policy checks may execute incompletely for non-viewers: T6183: Allow any user to watch projects.
Apr 11 2015, 8:20 PM · Policy, Herald, Flags
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

Project watchers are affected in the same way; see T6183.

Apr 11 2015, 8:19 PM · Policy, Herald, Flags
epriestley renamed T7703: Policy checks may execute incompletely for non-viewers from Flagged Unknown Object to Policy checks may execute incompletely for non-viewers.
Apr 11 2015, 8:18 PM · Policy, Herald, Flags

Mar 30 2015

sshannin added a comment to T7703: Policy checks may execute incompletely for non-viewers.

To your question @chad (although it seems like the clarity is not needed anymore), it just flags any newly created diff.

Mar 30 2015, 11:27 PM · Policy, Herald, Flags
epriestley triaged T7703: Policy checks may execute incompletely for non-viewers as Normal priority.
Mar 30 2015, 11:12 PM · Policy, Herald, Flags
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

We are doing a policy check here, but it's an unusual check and it's not fully effective.

Mar 30 2015, 11:08 PM · Policy, Herald, Flags
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

The expectation is that the rule will fail to run when the user can't see the object. The code is consistent with this expectation, looking into it..

Mar 30 2015, 10:44 PM · Policy, Herald, Flags
epriestley claimed T7703: Policy checks may execute incompletely for non-viewers.
Mar 30 2015, 10:43 PM · Policy, Herald, Flags
chad added a project to T7703: Policy checks may execute incompletely for non-viewers: Herald.
Mar 30 2015, 10:27 PM · Policy, Herald, Flags
chad added a comment to T7703: Policy checks may execute incompletely for non-viewers.

Actually, I'm probably wrong. It looks like (based on Feed in the screenshot) there is plenty of activity you don't have access to see. I'm not really sure we should let you flag an object you can't see. What specifically is the Herald rule?

Mar 30 2015, 10:26 PM · Policy, Herald, Flags
chad added a comment to T7703: Policy checks may execute incompletely for non-viewers.

I presume this to be a deleted item.

Mar 30 2015, 9:55 PM · Policy, Herald, Flags
sshannin added a comment to T7703: Policy checks may execute incompletely for non-viewers.

26.0 build for linux mint (aka mint build 1.0)

Mar 30 2015, 9:53 PM · Policy, Herald, Flags
chad added a comment to T7703: Policy checks may execute incompletely for non-viewers.

what browser is that?

Mar 30 2015, 9:53 PM · Policy, Herald, Flags