Page MenuHomePhabricator

Allow People to be Flagged
ClosedPublic

Authored by chad on Jul 18 2015, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 5:31 AM
Unknown Object (File)
Feb 20 2024, 10:28 PM
Unknown Object (File)
Feb 20 2024, 10:28 PM
Unknown Object (File)
Feb 13 2024, 11:01 PM
Unknown Object (File)
Feb 13 2024, 10:15 PM
Unknown Object (File)
Feb 12 2024, 9:05 PM
Unknown Object (File)
Feb 12 2024, 6:08 PM
Unknown Object (File)
Feb 12 2024, 4:35 PM

Details

Summary

Ref T8888, Makes People Flaggable (and makes me wonder if we should rename Flags->Bookmarks).

Test Plan

Flag myself. Get excited.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Allow People to be Flagged.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.

As an aside, "flagging" a user sounds like something negative to me. Bookmark sounds much friendlier.

epriestley edited edge metadata.

This change is technically correct.

Like @joshuaspence, I'm not totally sure I'm 100% onboard with it from a product perspective (it feels a little weird to me to flag users, too) but I guess the use case in T8888 looks legit enough. This does improve consistency and I don't think it's likely to be particularly confusing, even if it's maybe a little off product-wise.

This revision is now accepted and ready to land.Jul 20 2015, 8:23 PM
This revision was automatically updated to reflect the committed changes.