Page MenuHomePhabricator

Convert people manage page to two column
ClosedPublic

Authored by chad on Mar 9 2016, 4:52 PM.

Details

Summary

Ref T10545, this brings flags back? and converts the layout to two column w/curtain

Test Plan

View a few manage pages.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 37231.Mar 9 2016, 4:52 PM
chad retitled this revision from to Convert people manage page to two column.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added inline comments.Mar 9 2016, 4:53 PM
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
97–98

is this still actually needed? I've seen it left in other conversions.

epriestley accepted this revision.Mar 9 2016, 4:55 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
97–98

No. If I left it, it was accidental.

This revision is now accepted and ready to land.Mar 9 2016, 4:55 PM
This revision was automatically updated to reflect the committed changes.