Page MenuHomePhabricator
Feed Advanced Search

Jan 4 2016

joshuaspence added a comment to T10004: ApplicationEditor Errata.

Yeah, I can't reproduce it anymore either. I definitely saw it earlier today on a different install (which is up-to-date within a couple of hours) but I don't know what was special then.

Jan 4 2016, 7:37 AM · ApplicationEditor

Dec 31 2015

joshuaspence added a comment to T10004: ApplicationEditor Errata.

Yeah, I can't reproduce it anymore either. I definitely saw it earlier today on a different install (which is up-to-date within a couple of hours) but I don't know what was special then.

Dec 31 2015, 2:21 PM · ApplicationEditor
joshuaspence reopened T10004: ApplicationEditor Errata as "Open".
Dec 31 2015, 2:20 PM · ApplicationEditor
joshuaspence closed T10004: ApplicationEditor Errata as Resolved.

This is a test.

Dec 31 2015, 2:20 PM · ApplicationEditor
epriestley added a comment to T10004: ApplicationEditor Errata.

I can't reproduce that. Here's what I did:

Dec 31 2015, 2:04 PM · ApplicationEditor
joshuaspence added a comment to T10004: ApplicationEditor Errata.

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

Dec 31 2015, 7:31 AM · ApplicationEditor

Dec 30 2015

epriestley added a revision to T10004: ApplicationEditor Errata: D14911: Give IconSetControl a meaningful disabled state.
Dec 30 2015, 11:26 AM · ApplicationEditor
epriestley added a comment to T10004: ApplicationEditor Errata.

Ah, thanks. I think it's just missing a disabled state -- I wouldn't expect the edit to actually go through when you save (or are you seeing the edit work, too?).

Dec 30 2015, 11:16 AM · ApplicationEditor
20after4 added a comment to T10004: ApplicationEditor Errata.

Locking the icon field in projects doesn't actually work, it's still possible to edit the icon when that field is locked.

Dec 30 2015, 5:21 AM · ApplicationEditor

Dec 26 2015

epriestley added a revision to T10004: ApplicationEditor Errata: D14887: Support field previews in EditEngine.
Dec 26 2015, 9:08 PM · ApplicationEditor

Dec 23 2015

epriestley added a revision to T10004: ApplicationEditor Errata: D14865: Always show "Change Priority" Maniphest stacked action, even for closed tasks.
Dec 23 2015, 9:19 PM · ApplicationEditor
chad added a comment to T10004: ApplicationEditor Errata.

Change Priority only appears in Maniphest if the Status is OPEN. I ran into a case where I wanted to re-open a task and assign it a priority.

Dec 23 2015, 9:08 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 23 2015, 2:39 AM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14858: Fix incorrect rendering of "Spaces" dropdown control when configuring EditEngine defaults.
Dec 23 2015, 2:22 AM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 23 2015, 2:15 AM · ApplicationEditor
epriestley updated subscribers of T10004: ApplicationEditor Errata.
Dec 23 2015, 2:15 AM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 23 2015, 2:14 AM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14857: Allow users to swipe away stacked actions on mobile.
Dec 23 2015, 2:14 AM · ApplicationEditor

Dec 22 2015

epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 22 2015, 12:31 AM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14849: Improve strings for creating blocking subtasks.
Dec 22 2015, 12:29 AM · ApplicationEditor

Dec 21 2015

epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 21 2015, 11:56 PM · ApplicationEditor

Dec 19 2015

epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 19 2015, 2:37 PM · ApplicationEditor

Dec 18 2015

epriestley added a revision to T10004: ApplicationEditor Errata: D14822: Clean up "HTTP Parameters" view a bit for EditEngine forms.
Dec 18 2015, 6:53 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 18 2015, 6:53 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14821: Fix value reading in custom Text and Remarkup fields in EditEngine.
Dec 18 2015, 6:47 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 18 2015, 6:47 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14820: Restore "Create" transactions.
Dec 18 2015, 6:39 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 18 2015, 6:36 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 18 2015, 6:32 PM · ApplicationEditor
epriestley moved T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges from Backlog to vNext on the Transactions board.
Dec 18 2015, 1:07 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 18 2015, 12:57 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 18 2015, 12:39 PM · ApplicationEditor
epriestley added a comment to T10005: Implement an ApplicationEditor-based Bulk Editor.

I have no plans to pursue this anytime soon, but one of the goals of ApplicationEditor is enabling universal bulk editors, and I expect to pursue that and generalize bulk editors before implementing new bulk editor features.

Dec 18 2015, 10:26 AM · ApplicationEditor

Dec 17 2015

epriestley closed T9871: Some PHUI form controls do not have identifiable "disabled" states, a subtask of T9132: Build an ApplicationEditor abstraction, as Resolved.
Dec 17 2015, 11:13 PM · Restricted Project, ApplicationEditor, Transactions
epriestley closed T9871: Some PHUI form controls do not have identifiable "disabled" states as Resolved by committing rPa07a06ab0895: Give custom controls passable disabled states.
Dec 17 2015, 11:13 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 17 2015, 10:32 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14815: Indent multiple items from the same application in Quick Create menu.
Dec 17 2015, 10:29 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 17 2015, 9:39 PM · ApplicationEditor
epriestley added a revision to T9871: Some PHUI form controls do not have identifiable "disabled" states: D14814: Give custom controls passable disabled states.
Dec 17 2015, 9:32 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14814: Give custom controls passable disabled states.
Dec 17 2015, 9:32 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 17 2015, 7:04 PM · ApplicationEditor
epriestley renamed T10004: ApplicationEditor Errata from ApplicationEditor Errata to ApplicationEditor Errata.
Dec 17 2015, 7:03 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 17 2015, 6:53 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14811: Improve the clarity of transactions that affect policies and spaces during object creation.
Dec 17 2015, 6:36 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14809: Make configured and EditEngine defaults work correctly for custom fields.
Dec 17 2015, 5:36 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 17 2015, 4:28 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14808: Improve UX for customizing EditEngine forms a little bit.
Dec 17 2015, 3:27 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 17 2015, 3:05 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 17 2015, 3:05 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 17 2015, 3:05 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14806: Improve handling of multiple edit forms when logged out.
Dec 17 2015, 2:55 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14805: Remove all setObjectURI() from ActionListViews.
Dec 17 2015, 2:37 PM · ApplicationEditor
epriestley added a revision to T10004: ApplicationEditor Errata: D14804: When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI.
Dec 17 2015, 2:25 PM · ApplicationEditor
joshuaspence updated the task description for T10005: Implement an ApplicationEditor-based Bulk Editor.
Dec 17 2015, 2:33 AM · ApplicationEditor

Dec 16 2015

epriestley updated the task description for T10005: Implement an ApplicationEditor-based Bulk Editor.
Dec 16 2015, 9:46 PM · ApplicationEditor
epriestley added subtasks for T10005: Implement an ApplicationEditor-based Bulk Editor: T5689: Batch edit of Maniphest custom fields, T8152: Allow Batch Edit of Blocking Task Field, T8740: Batch edit Add Project does not perform the action requested, T4675: Support bulk editing object policies and other fields with complex UI controls, T5450: Add support for adding / removing dependent tasks when batch editing tasks.
Dec 16 2015, 9:45 PM · ApplicationEditor
epriestley created T10005: Implement an ApplicationEditor-based Bulk Editor.
Dec 16 2015, 9:43 PM · ApplicationEditor
epriestley moved T5307: UX for taking actions with search results from Backlog to v2 on the ApplicationEditor board.
Dec 16 2015, 9:42 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley moved T4768: Phabricator silently overwrites concurrent changes (no conflict detection) from Backlog to v2 on the ApplicationEditor board.
Dec 16 2015, 9:41 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley moved T10004: ApplicationEditor Errata from Backlog to v1 on the ApplicationEditor board.
Dec 16 2015, 9:41 PM · ApplicationEditor
epriestley updated the task description for T10004: ApplicationEditor Errata.
Dec 16 2015, 9:41 PM · ApplicationEditor
epriestley moved T9871: Some PHUI form controls do not have identifiable "disabled" states from Backlog to v1 on the ApplicationEditor board.
Dec 16 2015, 9:41 PM · ApplicationEditor
epriestley added a comment to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.

Reading Custom Fields is now supported in new *.search endpoints (paste.search, maniphest.search, owners.search).

Dec 16 2015, 9:03 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley closed T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter as Resolved.

The "Can Edit Task Status" thing is now covered in T10003. I'm going to spin the remaining errata out into a followup since most of this chatter is now obsolete.

Dec 16 2015, 7:04 PM · ApplicationEditor
chad added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Confirmed via IRC:

Dec 16 2015, 5:19 PM · ApplicationEditor

Dec 15 2015

epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14789: Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in comment actions.
Dec 15 2015, 4:46 PM · ApplicationEditor
chad added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

T9986 is reproducible:

Dec 15 2015, 3:41 PM · ApplicationEditor
chad updated subscribers of T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
Dec 15 2015, 3:39 PM · ApplicationEditor

Dec 14 2015

epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14783: Clean up an issue with meta-editing of edit engines.
Dec 14 2015, 9:32 PM · ApplicationEditor

Dec 13 2015

joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
In T9908#148901, @chad wrote:

I can reproduce it on Windows 10 / Chrome, but not Mac / Chrome.

Dec 13 2015, 8:39 PM · ApplicationEditor
chad added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

I can reproduce it on Windows 10 / Chrome, but not Mac / Chrome.

Dec 13 2015, 8:38 PM · ApplicationEditor
avivey added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

I can reproduce on Windows/Chrome: As long as the Actions field is in focus and not open, hitting "down arrow" adds an action.

Dec 13 2015, 8:38 PM · ApplicationEditor
chad added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

My question was more what OS should I be testing.

Dec 13 2015, 8:37 PM · ApplicationEditor
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
In T9908#148885, @chad wrote:

Doesn't reproduce for me on Mac at least, should I be testing something more specific?

Dec 13 2015, 8:34 PM · ApplicationEditor
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

I can't reproduce this. Does it reproduce for you on this install?

Dec 13 2015, 8:32 PM · ApplicationEditor
chad added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Doesn't reproduce for me on Mac at least, should I be testing something more specific?

Dec 13 2015, 8:30 PM · ApplicationEditor
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
In T9908#148608, @chad wrote:

A minor usability issue as well... If you click on the "Add Action" drop down and continually press the down key then you end up adding every action. Maybe we can just disable this behavior?

This doesn't reproduce for me, can you provide more details? It just goes down the select list (and I have to hit <enter> to make it trigger)

Dec 13 2015, 8:27 PM · ApplicationEditor

Dec 12 2015

epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14746: Clarify that the "Add Comment" button might not literally add a comment if you haven't typed a comment.
Dec 12 2015, 1:03 AM · ApplicationEditor
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

I can't reproduce this. Does it reproduce for you on this install?

Dec 12 2015, 1:02 AM · ApplicationEditor
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
In T9908#148608, @chad wrote:

A minor usability issue as well... If you click on the "Add Action" drop down and continually press the down key then you end up adding every action. Maybe we can just disable this behavior?

This doesn't reproduce for me, can you provide more details? It just goes down the select list (and I have to hit <enter> to make it trigger)

Dec 12 2015, 1:00 AM · ApplicationEditor
chad added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

A minor usability issue as well... If you click on the "Add Action" drop down and continually press the down key then you end up adding every action. Maybe we can just disable this behavior?

Dec 12 2015, 12:55 AM · ApplicationEditor
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

Dec 12 2015, 12:54 AM · ApplicationEditor
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

I noticed a few minor issues after deploying this on our install.

Dec 12 2015, 12:44 AM · ApplicationEditor

Dec 10 2015

epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Wording on this feed story isn't quite right, not sure if that's new or not:

Dec 10 2015, 9:04 PM · ApplicationEditor
angie moved T9132: Build an ApplicationEditor abstraction from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 10 2015, 6:51 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.

Broad update here after T9132:

Dec 10 2015, 2:00 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges, as Resolved.
Dec 10 2015, 1:43 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley closed T9132: Build an ApplicationEditor abstraction as Resolved.

I'm going to close this out since the infrastructure work it describes is now substantially complete, although a great deal of work remains to be done to bring this infrastructure to all applications and implement the full set of features it enables (mostly described in tasks blocked by this one).

Dec 10 2015, 1:43 PM · Restricted Project, ApplicationEditor, Transactions
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T4768: Phabricator silently overwrites concurrent changes (no conflict detection), as Resolved.
Dec 10 2015, 1:43 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction

Dec 9 2015

epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Additional errata:

Dec 9 2015, 2:50 PM · ApplicationEditor
epriestley moved T9132: Build an ApplicationEditor abstraction from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:30 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: D14718: Document how to customize forms in ApplicationEditor.
Dec 9 2015, 1:01 PM · Restricted Project, ApplicationEditor, Transactions
chad updated subscribers of T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
Dec 9 2015, 4:31 AM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14717: Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest.
Dec 9 2015, 12:57 AM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14716: Delete old Maniphest edit controller.
Dec 9 2015, 12:53 AM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14715: Replace workboard task creation with EditEngine.
Dec 9 2015, 12:48 AM · ApplicationEditor

Dec 8 2015

epriestley moved T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges from Backlog to vNext on the Conduit board.
Dec 8 2015, 10:53 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14712: Move workboard card edits to EditEngine in Maniphest.
Dec 8 2015, 10:47 PM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14711: Move inline edit from task lists to EditEngine.
Dec 8 2015, 10:32 PM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: D14708: Swap Maniphest to new edit form.
Dec 8 2015, 8:54 PM · ApplicationEditor