Page MenuHomePhabricator

Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in comment actions
ClosedPublic

Authored by epriestley on Dec 15 2015, 4:46 PM.

Details

Summary

Ref T9908. Fixes T6205.

This is largely some refactoring to improve the code. The new structure is:

  • Each EditField has zero or one "submit" (normal edit form) controls.
  • Each EditField has zero or one "comment" (stacked actions) controls.
    • If we want more than one in the future, we'd just add two fields.
  • Each EditField can have multiple EditTypes which provide Conduit transactions.
  • EditTypes are now lower-level and less involved on the Submit/Comment pathways.
Test Plan
  • Added and removed projects and subscribers.
  • Changed task statuses.
  • In two windows: added some subscribers in one, removed different ones in the other. The changes did not conflict.
  • Applied changes via Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in comment actions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

If we want more than one in the future, we'd just add two fields.

This has some slightly weird implications, like if we wanted "Add Projects" and "Change Projects" for some reason we'd need to say that they're both bound to the locked/hidden status of whichever one gets a web UI control, but that's fairly reasonable and I'm pretty sure that will be very rare or wholly nonexistent anyway.

  • Fix some more initialValue vs originalValue consistency issues.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2015, 9:01 PM
This revision was automatically updated to reflect the committed changes.